RFR: JDK-8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow [v2]

Thomas Stuefe stuefe at openjdk.java.net
Fri Oct 29 09:59:56 UTC 2021


On Fri, 29 Oct 2021 09:00:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adapt copyrights
>
> test/hotspot/jtreg/runtime/Metaspace/elastic/MetaspaceTestManyArenasManyThreads.java line 66:
> 
>> 64: 
>> 65:             for (RandomAllocatorThread t: threads) {
>> 66:                 if (t.allocator.arena.numAllocationFailures > 1000) {
> 
> Feels like `numAllocationFailures` should be `volatile` (actually, `VarHandles.getOpaque` would be enough, but you probably don't want to bring all that fuss in)?

Good point. I made it volatile, that should be sufficient here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6041


More information about the hotspot-runtime-dev mailing list