<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 14, 2012, at 11:08 AM, Daniel D. Daugherty wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">

  
    <meta content="text/html; charset=windows-1252" http-equiv="Content-Type">
  
  <div bgcolor="#ffffff" text="#000000">
    <tt>
      <blockquote type="cite">
        <div># JRE version: Java(TM) SE Runtime Environment (7.0_04-b20)</div>
        <div># Java VM &nbsp; &nbsp;: Java HotSpot(TM) Server VM
          (24.0-b14-internal-jvmg mixed mode linux-x86 )</div>
      </blockquote>
      <br>
      I think the above lines indicate that white space was added<br>
      before the ':' on the "Java VM" line. You need to be careful<br>
      about changing stuff like that since lots of folks have<br>
      scripts that parse output like this.<br></tt></div></blockquote><div><br></div>I tried :-) &nbsp;But then I hope nobody is parsing the "JRE version" line...</div><div><br></div><div>-- Chris</div><div><br><blockquote type="cite"><div bgcolor="#ffffff" text="#000000"><tt>
      <br>
      Dan<br>
      <br>
      <br>
      <br>
    </tt><br>
    On 6/14/12 11:57 AM, Christian Thalinger wrote:
    <blockquote cite="mid:CF6F2F38-457E-4C15-B308-42D618550A27@oracle.com" type="cite"><br>
      <div>
        <div>On Jun 13, 2012, at 7:27 PM, Krystal Mok wrote:</div>
        <br class="Apple-interchange-newline">
        <blockquote type="cite">Thank you for the reviews, Chris, Coleen
          and John!<br>
          <br>
          <div class="gmail_quote">On Thu, Jun 14, 2012 at 9:38 AM, John
            Rose <span dir="ltr">&lt;<a moz-do-not-send="true" href="mailto:john.r.rose@oracle.com" target="_blank">john.r.rose@oracle.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
              0.8ex; border-left: 1px solid rgb(204, 204, 204);
              padding-left: 1ex;">
              <div style="word-wrap: break-word;">
                <div>
                  <div class="im">
                    <div>On May 16, 2012, at 1:26 PM, Christian
                      Thalinger wrote:</div>
                    <br>
                  </div>
                  <div class="im">
                    <blockquote type="cite"><span style="border-collapse: separate; font-family:
                        Helvetica; font-style: normal; font-variant:
                        normal; font-weight: normal; letter-spacing:
                        normal; line-height: normal; text-indent: 0px;
                        text-transform: none; white-space: normal;
                        word-spacing: 0px; font-size: medium;">
                        <div>
                          I looked at the changes and I think this is
                          the right way to implement it. &nbsp;It will
                          definitely help debugging some strange crashes
                          like the one mentioned.</div>
                      </span></blockquote>
                    <br>
                  </div>
                </div>
                <div>I suggest that the following should be turned into
                  real code the returns NULL:</div>
                <div>&nbsp; assert(name_oop != NULL, "java_runtime_name
                  shouldn't be null")</div>
                <div><br>
                </div>
                <div>(When the JVM crashes is exactly when such asserts
                  prove false. &nbsp;At that point we want all the crash
                  info.)</div>
                <span class="HOEnZb"><font color="#888888">
                    <div><br>
                    </div>
                  </font></span></div>
            </blockquote>
            <div>Ahh...yes, you're right. I agree this line should be
              changed to just returning NULL.</div>
            <div>Chris, could you please take care of this when pushing?</div>
          </div>
        </blockquote>
        <div><br>
        </div>
        Sure. &nbsp;I also changed the output format slightly to be more like
        -version:</div>
      <div><br>
      </div>
      <div>
        <div>#</div>
        <div># A fatal error has been detected by the Java Runtime
          Environment:</div>
        <div>#</div>
        <div># &nbsp;SIGSEGV (0xb) at pc=0x0135f581, pid=9986, tid=2819574640</div>
        <div>#</div>
        <div># JRE version: Java(TM) SE Runtime Environment (7.0_04-b20)</div>
        <div># Java VM &nbsp; &nbsp;: Java HotSpot(TM) Server VM
          (24.0-b14-internal-jvmg mixed mode linux-x86 )</div>
        <div># Problematic frame:</div>
        <div># V &nbsp;[libjvm.so+0x4a0581]
          &nbsp;frame::oops_do_internal(OopClosure*, CodeBlobClosure*,
          RegisterMap*, bool)+0x2f</div>
        <div>#</div>
        <div><br>
        </div>
        <div>
          <div>$ java -version</div>
          <div>java version "1.7.0_04"</div>
          <div>Java(TM) SE Runtime Environment (build 1.7.0_04-b20)</div>
          <div>Java HotSpot(TM) Server VM (build 24.0-b14-internal-jvmg,
            mixed mode)</div>
        </div>
      </div>
      <div><br>
      </div>
      <div>Here is the webrev:</div>
      <div><br>
      </div>
      <div><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Etwisti/7176856/">http://cr.openjdk.java.net/~twisti/7176856/</a></div>
      <div><br>
      </div>
      <div>-- Chris</div>
      <div><br>
        <blockquote type="cite">
          <div class="gmail_quote">
            <div><br>
            </div>
            <div>Thanks,</div>
            <div>Kris</div>
            <div>&nbsp;</div>
            <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
              0.8ex; border-left: 1px solid rgb(204, 204, 204);
              padding-left: 1ex;">
              <div style="word-wrap: break-word;"><span class="HOEnZb"><font color="#888888">
                    <div>
                    </div>
                    <div> John</div>
                    <br>
                  </font></span></div>
            </blockquote>
          </div>
          <br>
        </blockquote>
      </div>
      <br>
    </blockquote>
  </div>

</blockquote></div><br></body></html>