<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#CCCCCC" text="#000000">
<div class="moz-cite-prefix">On 7/5/12 9:32 AM,
<a class="moz-txt-link-abbreviated" href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br>
</div>
<blockquote cite="mid:4FF5C1AE.5090100@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Frederic,<br>
<br>
<br>
Thank you a lot for fixing this issue!<br>
The fix looks good, just a couple of nits below.<br>
I also wonder if the SA cares about this attribute.<br>
If so, it'd make sense to file a bug.<br>
</div>
</blockquote>
<br>
The following comments belong to the file:<br>
src/share/vm/oops/instanceKlass.cpp<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<blockquote cite="mid:4FF5C1AE.5090100@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
<br>
(1) Nit: I guess, the type should be char, not u1:<br>
<br>
1949 if (_source_debug_extension != NULL)
FREE_C_HEAP_ARRAY(u1, _source_debug_extension, mtClass);<br>
<br>
<br>
(2) Nit: No need to cast at 1971:<br>
<br>
1966 char* sde = NEW_C_HEAP_ARRAY(char, (length + 1),
mtClass);<br>
. . .<br>
1971 _source_debug_extension = (char*)sde;<br>
<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 7/5/12 5:22 AM, Frederic Parain wrote:<br>
</div>
<blockquote cite="mid:4FF58711.8010709@oracle.com" type="cite">Greetings,
<br>
<br>
The bug is described in details in the CR below. <br>
<br>
CR: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277</a>
<br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Efparain/6294277/webrev.00/">http://cr.openjdk.java.net/~fparain/6294277/webrev.00/</a>
<br>
<br>
Tested with JPRT, sajdi and quick-jvmti. <br>
<br>
Thanks, <br>
<br>
Fred <br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
<br>
</body>
</html>