<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.changed
{mso-style-name:changed;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>You are correct <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thx Ron<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> Serguei Spitsyn <br><b>Sent:</b> Thursday, December 13, 2012 1:23 PM<br><b>To:</b> Daniel Daugherty<br><b>Cc:</b> build-dev; serviceability-dev@openjdk.java.net; hotspot-runtime-dev@openjdk.java.net; Ron Durbin<br><b>Subject:</b> Re: code review request for 7153050 remove crufty '_g' support<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Dan,<br><br>It is nice fix and simplified many places.<br><br>Just one minor comment:<br><br>make/bsd/makefiles/dtrace.make<o:p></o:p></p><pre><o:p> </o:p></pre><pre> 41 #LIBJVM_DB = libjvm_db.dylib<o:p></o:p></pre><pre><span class=changed> 42 LIBJVM_DB = libjvm_db.dylib</span><o:p></o:p></pre><pre><o:p> </o:p></pre><pre> 45 #LIBJVM_DTRACE = libjvm_dtrace.dylib<o:p></o:p></pre><pre><span class=changed> 46 LIBJVM_DTRACE = libjvm_dtrace.dylib</span><o:p></o:p></pre><p class=MsoNormal> The lines #41 and #45 can be removed.<br><br><br>Thanks,<br>Serguei<br><br><br>On 12/13/12 10:53 AM, Daniel D. Daugherty wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Greetings, <br><br>I'm sponsoring this code review request from Ron Durbin. This change <br>is targeted at JDK8/HSX-25 in the RT_Baseline repo. Please make sure <br>you include Ron on any e-mail replies since he is not yet on the <br>OpenJDK aliases. <br><br>Dan <br><br><br>Intro: <br><br>This set of changes removes the makefile support for generation of debug <br>versions that follow _g semantics. <br><br>Defect: <br><br>7153050 “remove crufty '_g' support from HotSpot repo” <br><a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153050">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153050</a> <br><a href="https://jbs.oracle.com/bugs/browse/JDK-7153050">https://jbs.oracle.com/bugs/browse/JDK-7153050</a> <br><br><br>Webrev <br><br><a href="http://cr.openjdk.java.net/~dcubed/for_rdurbin/7153050-webrev/0">http://cr.openjdk.java.net/~dcubed/for_rdurbin/7153050-webrev/0</a> <br><br>Details: <br><br>Many makefiles have been modified to remove all reference and support <br>for debug versions that follow _g semantics. <o:p></o:p></p></blockquote><p class=MsoNormal><o:p> </o:p></p></div></body></html>