<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Look good to me.<br>
<br>
Thanks,<br>
<br>
-Zhengyu<br>
<br>
On 12/17/2012 1:32 PM, harold seigel wrote:
<blockquote cite="mid:50CF6555.6010904@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Request for review 8005075: CDS archive with one
alignment causes crash when run with different alignment</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Mon, 17 Dec 2012 10:23:59 -0500</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>harold seigel <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:harold.seigel@oracle.com"><harold.seigel@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Organization:
</th>
<td>Oracle Corporation</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td><a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:hotspot-runtime-dev@openjdk.java.net">hotspot-runtime-dev@openjdk.java.net</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Please review the following change to fix bug 8005075.<br>
<br>
Summary: This change prevents a crash when a CDS archive is
created with a value for -XX:+ObjectAlignmentInBytes that is
smaller than the ObjectAlignmentInBytes value used when running
with -Xshare:on. This fix stores the ObjectAlignmentInBytes in
the CDS archive so that when the archive is read, hotspot can
compare the archive's alignment with the current alignment and
issue the following diagnostic if the archive's alignment is too
small:<br>
<blockquote>An error has occurred while processing the shared
archive file.<br>
The shared archive file was created with a smaller Object
Alignment value.<br>
</blockquote>
This webrev also cleans up some text in globals.hpp and fixes a
small problem with -XX:SharedReadOnlySize. The existing code was
always setting SharedReadOnlySize to 14M regardless of what was
requested. This prevented users from being able to expand the CDS
archive's SharedReadOnly section.<br>
<br>
Open webrev at <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ehseigel/bug_8005076/">http://cr.openjdk.java.net/~hseigel/bug_8005076/</a><br>
<br>
Bug link at <a moz-do-not-send="true"
href="http://bugs.sun.com/view_bug.do?bug_id=8005076">http://bugs.sun.com/view_bug.do?bug_id=8005076</a><br>
<br>
The changes were tested with JCK, JPRT, JTREG, and UTE tests, and
with hand-run tests using different ObjectAlignmentInBytes values.<br>
<br>
Thanks, Harold<br>
<br>
</blockquote>
</body>
</html>