<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Adding back in the other aliases...<br>
<br>
<tt><tt>Coleen, t</tt>hanks for the fast review!<br>
<br>
<tt>Dan<br>
<br>
<br>
</tt></tt><br>
</tt>
<div class="moz-cite-prefix">On 12/18/12 2:29 PM, Coleen Phillimore
wrote:<br>
</div>
<blockquote cite="mid:50D0E021.30505@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
This looks good. Thank you for doing this.<br>
Coleen<br>
<br>
<div class="moz-cite-prefix">On 12/18/2012 03:46 PM, Daniel D.
Daugherty wrote:<br>
</div>
<blockquote cite="mid:50D0D618.6020001@oracle.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Cambria;
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Lucida Console";
panose-1:2 11 6 9 4 5 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
tt
{mso-style-priority:99;
font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1"><tt><span style="font-size: 11pt;"><o:p>Greetings,<br>
<br>
I'm sponsoring this code review request from Ron Durbin.
This change<br>
is targeted at JDK8/HSX-25 in the RT_Baseline repo.<br>
<br>
Dan<br>
<br>
Sending again with correct subject line, bug URLs and
webrev URL.<br>
<br>
</o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Intro:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">This set of changes
removes the </span></tt><tt><span style="font-size:
10pt;">runtime</span></tt><tt><span style="font-size:
10pt;"> support for generation of debug versions that
follow _g semantics.<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Defect:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 9pt;">JDK-8005044 remove
crufty '_g' support from HS runtime code</span></tt><tt><br>
</tt><tt><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005044">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005044</a></tt><tt><br>
</tt><tt><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8005044">https://jbs.oracle.com/bugs/browse/JDK-8005044</a></tt><tt><br>
</tt><tt><span style="font-size: 9pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Webrev<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 9pt;"></span></tt><tt><span
style="font-size: 10pt;"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edcubed/for_rdurbin/8005044-webrev/0">http://cr.openjdk.java.net/~dcubed/for_rdurbin/8005044-webrev/0</a>
<br>
<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Details:</span></tt><tt><span
style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Files </span></tt><tt><span
style="font-size: 10pt;">have been modified to remove all
reference and support for debug versions that follow _g
semantics.</span></tt><tt><span style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Testing:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Passed JPRT last
night:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Additional Testing In
process: (suggested by Dan)</span></tt><tt><span
style="font-size:10.0pt">:</span></tt><tt><span
style="font-size: 10pt;"><br>
<br>
src/share/vm/runtime/arguments.cpp<br>
- test with shared archive creation and use; see the
e-mail<br>
from Coleen<br>
<br>
src/share/tools/ProjectCreator/ProjectCreator.java<br>
- just a usage message; visual inspection of the code<br>
<br>
src/os/windows/vm/os_windows.cpp<br>
- comments only; no testing needed<br>
<br>
src/os/{bsd,linux,solaris}/vm/os_{bsd,linux,solaris}.cpp<br>
- the only code changes come into play when the
"gamma"<br>
launcher is used<br>
- and when JAVA_HOME refers to a valid JDK, the
function<br>
fakes up a JVM path so that callers using the JVM
path<br>
to find other things in the JDK will work.<br>
- I can't find any way that the actual JVM path value<br>
that is returned is exposed<br>
- I don't see a way to test this other than have a
debug<br>
printf() or manual code inspection.<br>
</span></tt><tt><span style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 10pt;"><o:p></o:p></span></tt></div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>