<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Just for the record: I have reviewed all of Ron's changes<br>
and I approve them.</tt><tt><br>
<br>
<tt>One thing I noticed of interest to launcher folks that<br>
<tt>is not due to any changes that Ron made</tt>:<br>
<br>
<tt>src/os/windows/vm/os_windows.cpp:<br>
<br>
</tt><tt>1718 // Find the full path to the current module,
jvm.dll<br>
1719 void os::jvm_path(char *buf, jint buflen) {<br>
1720 // Error checking.<br>
1721 if (buflen < MAX_PATH) {<br>
1722 assert(false, "must use a large-enough buffer");<br>
1723 buf[0] = '\0';<br>
1724 return;<br>
1725 }<br>
1726 // Lazy resolve the path to current module.<br>
1727 if (saved_jvm_path[0] != 0) {<br>
1728 strcpy(buf, saved_jvm_path);<br>
1729 return;<br>
1730 }<br>
1731 <br>
1732 buf[0] = '\0';<br>
1733 if (Arguments::created_by_gamma_launcher()) {<br>
1734 // Support for the gamma launcher. Check for an<br>
1735 // JAVA_HOME environment variable<br>
1736 // and fix up the path so it looks like<br>
1737 // libjvm.so is installed there (append a fake
suffix<br>
1738 // hotspot/libjvm.so).<br>
1739 char* java_home_var = ::getenv("JAVA_HOME");<br>
1740 if (java_home_var != NULL &&
java_home_var[0] != 0) {<br>
1741 <br>
1742 strncpy(buf, java_home_var, buflen);<br>
1743 <br>
1744 // determine if this is a legacy image or modules
image<br>
1745 // modules image doesn't have "jre" subdirectory<br>
1746 size_t len = strlen(buf);<br>
1747 char* jrebin_p = buf + len;<br>
1748 jio_snprintf(jrebin_p, buflen-len,
"\\jre\\bin\\");<br>
1749 if (0 != _access(buf, 0)) {<br>
1750 jio_snprintf(jrebin_p, buflen-len, "\\bin\\");<br>
1751 }<br>
1752 len = strlen(buf);<br>
1753 jio_snprintf(buf + len, buflen-len,
"hotspot\\jvm.dll");<br>
1754 }<br>
1755 }<br>
1756 <br>
1757 if(buf[0] == '\0') {<br>
1758 GetModuleFileName(vm_lib_handle, buf, buflen);<br>
1759 }<br>
1760 strcpy(saved_jvm_path, buf);<br>
1761 }<br>
<br>
<tt>the block from line 17<tt>33 -> 1755 is <tt>dead code
on Windows.<br>
<tt>The launcher on Windows is now called "hotspot" and
is not<br>
<tt>called "gamma" so
Arguments::created_by_gamma_launcher()<br>
<tt>will not return true on Windows.<br>
<br>
<tt>And <tt>one more launc<tt>her </tt>nit:<br>
<br>
$ grep gamma
make/windows/makefiles/launcher.make <br>
/D LAUNCHER_TYPE=\"gamma\" \<br>
</tt></tt></tt></tt></tt></tt></tt></tt></tt></tt></tt><tt><br>
</tt><tt>Dan</tt><br>
<tt><tt><br>
<br>
</tt></tt>
<div class="moz-cite-prefix">On 12/18/12 1:46 PM, Daniel D.
Daugherty wrote:<br>
</div>
<blockquote cite="mid:50D0D618.6020001@oracle.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Cambria;
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Lucida Console";
panose-1:2 11 6 9 4 5 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
tt
{mso-style-priority:99;
font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1"><tt><span style="font-size: 11pt;"><o:p>Greetings,<br>
<br>
I'm sponsoring this code review request from Ron Durbin.
This change<br>
is targeted at JDK8/HSX-25 in the RT_Baseline repo.<br>
<br>
Dan<br>
<br>
Sending again with correct subject line, bug URLs and
webrev URL.<br>
<br>
</o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Intro:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">This set of changes
removes the </span></tt><tt><span style="font-size: 10pt;">runtime</span></tt><tt><span
style="font-size: 10pt;"> support for generation of debug
versions that follow _g semantics.<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Defect:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 9pt;">JDK-8005044 remove crufty
'_g' support from HS runtime code</span></tt><tt><br>
</tt><tt><a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005044">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005044</a></tt><tt><br>
</tt><tt><a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://jbs.oracle.com/bugs/browse/JDK-8005044">https://jbs.oracle.com/bugs/browse/JDK-8005044</a></tt><tt><br>
</tt><tt><span style="font-size: 9pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Webrev<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 9pt;"></span></tt><tt><span
style="font-size: 10pt;"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edcubed/for_rdurbin/8005044-webrev/0">http://cr.openjdk.java.net/~dcubed/for_rdurbin/8005044-webrev/0</a>
<br>
<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 10pt;">Details:</span></tt><tt><span
style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Files </span></tt><tt><span
style="font-size: 10pt;">have been modified to remove all
reference and support for debug versions that follow _g
semantics.</span></tt><tt><span style="font-size: 10pt;"><o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Testing:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Passed JPRT last night:<o:p></o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;"><o:p> </o:p></span></tt><tt><br>
</tt><tt><span style="font-size: 11pt;">Additional Testing In
process: (suggested by Dan)</span></tt><tt><span
style="font-size:10.0pt">:</span></tt><tt><span
style="font-size: 10pt;"><br>
<br>
src/share/vm/runtime/arguments.cpp<br>
- test with shared archive creation and use; see the
e-mail<br>
from Coleen<br>
<br>
src/share/tools/ProjectCreator/ProjectCreator.java<br>
- just a usage message; visual inspection of the code<br>
<br>
src/os/windows/vm/os_windows.cpp<br>
- comments only; no testing needed<br>
<br>
src/os/{bsd,linux,solaris}/vm/os_{bsd,linux,solaris}.cpp<br>
- the only code changes come into play when the "gamma"<br>
launcher is used<br>
- and when JAVA_HOME refers to a valid JDK, the function<br>
fakes up a JVM path so that callers using the JVM path<br>
to find other things in the JDK will work.<br>
- I can't find any way that the actual JVM path value<br>
that is returned is exposed<br>
- I don't see a way to test this other than have a debug<br>
printf() or manual code inspection.<br>
</span></tt><tt><span style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 11pt;"><o:p></o:p></span></tt><tt><span
style="font-size: 10pt;"><o:p></o:p></span></tt></div>
</blockquote>
<br>
</body>
</html>