<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
This looks good.<br>
<br>
<div class="moz-cite-prefix">On 12/18/2012 02:58 PM, harold seigel
wrote:<br>
</div>
<blockquote cite="mid:50D0CAD5.9090608@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Please review the modified fix for bug 8005076. The modified fix
can be viewed at <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ehseigel/bug_8005076_2/">http://cr.openjdk.java.net/~hseigel/bug_8005076_2/</a><br>
<br>
It contains two changes from the previous fix.<br>
<br>
As requested by Vitaly, the diagnostic in filemap.cpp has been
changed to include the incompatible ObjectAlignmentInBytes
values. Here's sample new message:<br>
<blockquote>The shared archive file's ObjectAlignmentInBytes of 8
is too small for the current ObjectAlignmentInBytes of 16.<br>
</blockquote>
Also, the change to arguments.cpp no longer sets a minimum value
for -XX:+ObjectAlignmentInBytes. (This was requested by Coleen.)<br>
</blockquote>
<br>
^^ -XX:SharedReadOnlySize.<br>
<br>
Thanks,<br>
Coleen<br>
<blockquote cite="mid:50D0CAD5.9090608@oracle.com" type="cite"> <br>
Thanks, Harold<br>
<br>
<br>
On 12/17/2012 7:10 PM, Vitaly Davidovich wrote:
<blockquote
cite="mid:CAHjP37F5bvJHauKVOTt3qcr-Fw0cPoN_YL6P6-RsX_r3Gjw7EA@mail.gmail.com"
type="cite">
<p dir="ltr">Hi Harold,</p>
<p dir="ltr">It might be useful to report the recorded alignment
in the CDS archive in the diagnostic message that you print
out. What do you think?</p>
<p dir="ltr">Thanks</p>
<p dir="ltr">Sent from my phone</p>
<div class="gmail_quote">On Dec 17, 2012 10:24 AM, "harold
seigel" <<a moz-do-not-send="true"
href="mailto:harold.seigel@oracle.com">harold.seigel@oracle.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Please review the
following change to fix bug 8005075.<br>
<br>
Summary: This change prevents a crash when a CDS archive
is created with a value for -XX:+ObjectAlignmentInBytes
that is smaller than the ObjectAlignmentInBytes value used
when running with -Xshare:on. This fix stores the
ObjectAlignmentInBytes in the CDS archive so that when the
archive is read, hotspot can compare the archive's
alignment with the current alignment and issue the
following diagnostic if the archive's alignment is too
small:<br>
<blockquote>An error has occurred while processing the
shared archive file.<br>
The shared archive file was created with a smaller
Object Alignment value.<br>
</blockquote>
This webrev also cleans up some text in globals.hpp and
fixes a small problem with -XX:SharedReadOnlySize. The
existing code was always setting SharedReadOnlySize to 14M
regardless of what was requested. This prevented users
from being able to expand the CDS archive's SharedReadOnly
section.<br>
<br>
Open webrev at <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ehseigel/bug_8005076/"
target="_blank">http://cr.openjdk.java.net/~hseigel/bug_8005076/</a><br>
<br>
Bug link at <a moz-do-not-send="true"
href="http://bugs.sun.com/view_bug.do?bug_id=8005076"
target="_blank">http://bugs.sun.com/view_bug.do?bug_id=8005076</a><br>
<br>
The changes were tested with JCK, JPRT, JTREG, and UTE
tests, and with hand-run tests using different
ObjectAlignmentInBytes values.<br>
<br>
Thanks, Harold<br>
</div>
</blockquote>
</div>
</blockquote>
</blockquote>
<br>
</body>
</html>