<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
This looks good. It looks like the webrev was updated to get rid
of the unused variable, so that is good. Is there a test for
ErrorHandlerTest in our repository already?<br>
Thanks,<br>
Coleen<span style="color: rgb(0, 0, 0); font-family: Arial,
FreeSans, Helvetica, sans-serif; font-size: 13px; font-style:
normal; font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 17px; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;
background-color: rgb(240, 240, 240); display: inline
!important; float: none;"></span><br>
<br>
On 2/19/2013 6:48 PM, Daniel D. Daugherty wrote:<br>
</div>
<blockquote cite="mid:51240F3A.6060004@oracle.com" type="cite">Greetings,
<br>
<br>
I'm sponsoring this code review request from Ron Durbin. This
change
<br>
is targeted at JDK8/HSX-25 in the RT_Baseline repo.
<br>
<br>
Dan
<br>
<br>
<br>
I have a proposed fix for the following bug:
<br>
<br>
6799919 Recursive calls to report_vm_out_of_memory are handled
incorrectly
<br>
<a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6799919">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6799919</a>
<br>
<a class="moz-txt-link-freetext" href="https://jbs.oracle.com/bugs/browse/JDK-6799919">https://jbs.oracle.com/bugs/browse/JDK-6799919</a>
<br>
<br>
This is one of those bug fixes where the commit message nicely
describes
<br>
the change:
<br>
<br>
6799919: Recursive calls to report_vm_out_of_memory are handled
incorrectly
<br>
Summary: report_vm_out_of_memory() should allow
VMError.report_and_die() to handle multiple out of native memory
errors.
<br>
Reviewed-by: dcubed, <other-reviewers>
<br>
Contributed-by <a class="moz-txt-link-abbreviated" href="mailto:ron.durbin@oracle.com">ron.durbin@oracle.com</a>
<br>
<br>
Here is the webrev URL:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/for_rdurbin/6799919-webrev/0-hsx25">http://cr.openjdk.java.net/~dcubed/for_rdurbin/6799919-webrev/0-hsx25</a>
<br>
<br>
Testing:
<br>
- See the READ_ME file attached to the JDK-6799919 for the gory
details
<br>
of the testing needed to reproduce this failure and verify
the fix
<br>
- regular JPRT test job is in process
<br>
<br>
Comments, questions and suggestions are welcome.
<br>
<br>
Ron
<br>
</blockquote>
<br>
</body>
</html>