<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
Nice catch. <br>
Looks good.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
<br>
On 2/21/13 9:09 PM, Coleen Phillimore wrote:<br>
</div>
<blockquote cite="mid:5126FD9D.2000302@oracle.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
I'm sorry about this but I need one more review. I omitted one
instance of JVM_CONSTANT_Object in templateTable_sparc.cpp and I
forgot that you can't make any edit to the VM without making a
duplicate edit to the serviceability agent.<br>
<br>
open webrev at <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecoleenp/8000797_3/">http://cr.openjdk.java.net/~coleenp/8000797_3/</a><br>
<br>
Reran runThese jcks and sajdi and mlvm tests on solaris/sparc.<br>
<br>
Thanks,<br>
Coleen<br>
<br>
On 2/21/2013 6:22 PM, John Rose wrote:<br>
</div>
<blockquote
cite="mid:50E59DA5-1F3E-4A7E-8F83-A6AF970DF6C2@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div>
<div>On Feb 20, 2013, at 8:11 PM, Coleen Phillimore <<a
moz-do-not-send="true"
href="mailto:coleen.phillimore@oracle.com">coleen.phillimore@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span style="font-family: Helvetica;
font-size: medium; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: 2; text-align: -webkit-auto;
text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; display: inline !important; float: none; ">Thanks to
John's feedback, I've modified this change again to revert
back to my original change to zero out the Symbol* to
indicate pseudo string (could be thought of as "patched
string"). Also cleaned up unused constant pool Object
constant and unused flags. Reran all the tests.</span><br
style="font-family: Helvetica; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">
<br style="font-family: Helvetica; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ecoleenp/8000797_2/"
style="font-family: Helvetica; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">http://cr.openjdk.java.net/~coleenp/8000797_2/</a><br
style="font-family: Helvetica; font-size: medium;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-size-adjust: auto;
-webkit-text-stroke-width: 0px; ">
</blockquote>
</div>
<br>
<div>Good; lots of nice deletions. You can use me as a
reviewer. — John</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>