<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
You could change this line to be the nicer Java way to iterate over
arrays:<br>
<br>
<pre><span class="new">+ for (int f = 0; f < flags.length; f++) {
</span></pre>
Otherwise, looks good.<br>
<br>
Coleen<br>
<br>
<div class="moz-cite-prefix">On 11/14/2013 02:34 AM, Staffan Larsen
wrote:<br>
</div>
<blockquote
cite="mid:0351D9FE-7E6E-4D50-A97D-02635F74F8C7@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Still looking for an official Review of this change.
<div><br>
</div>
<div>
<div>Thanks,</div>
<div>/Staffan</div>
</div>
<div><br>
</div>
<div>
<div>On 11 Nov 2013, at 21:25, Staffan Larsen <<a
moz-do-not-send="true"
href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space;">Ah, good catch.
<div><br>
</div>
<div>Here is an updated review: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Esla/6606002/webrev.01/">http://cr.openjdk.java.net/~sla/6606002/webrev.01/</a></div>
<div><br>
</div>
<div>
<div>Thanks,</div>
<div>/Staffan</div>
<div><br>
</div>
<div>
<div>
<div>On 11 Nov 2013, at 21:06, <a
moz-do-not-send="true"
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">It looks good.<br>
<br>
The only one nit is about the line:<br>
<meta http-equiv="content-type"
content="text/html; charset=windows-1252">
<pre><span class="new"> 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags());</span></pre>
<br>
If one or both of<span class="new">
Arguments.getJVMArgs() and
Arguments.getJVMFlags()</span> return null<br>
(not sure if it is the case) then the output
will have "null" like this:<br>
"Command line: nullnull"<br>
<br>
Would it make sense to keep the original checks
for non-null strings?<br>
<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 11/11/13 11:28 AM, Staffan Larsen wrote:<br>
</div>
<blockquote
cite="mid:9C61822B-201F-4A73-B2F5-E2D82A06244A@oracle.com"
type="cite">
<pre wrap="">The problem here is that ‘jinfo -flags’ only looks at the command line, but if a user has changed a flag after the VM started (for example by using ‘jinfo -flag’) that new value does not show up.
I am changing the output so that ‘jinfo -flags’ now prints something like this:
Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC
Command line: -XX:+PrintGCDetails
webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Esla/6606002/webrev.00/">http://cr.openjdk.java.net/~sla/6606002/webrev.00/</a>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-6606002">https://bugs.openjdk.java.net/browse/JDK-6606002</a>
Thanks,
/Staffan</pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>