<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Hi Lois,<br>
    <br>
    The changes look good.<br>
    <br>
    Harold<br>
    <br>
    <div class="moz-cite-prefix">On 11/25/2013 2:53 PM, Karen Kinnear
      wrote:<br>
    </div>
    <blockquote
      cite="mid:FD9A2307-398F-4269-8E55-69CE3738004C@oracle.com"
      type="cite">Lois,
      <div><br>
      </div>
      <div>Looks much better - many thanks for the modification. Ship
        it.</div>
      <div><br>
      </div>
      <div>thanks,</div>
      <div>Karen</div>
      <div><br>
        <div>
          <div>On Nov 25, 2013, at 1:37 PM, Lois Foltan wrote:</div>
          <br class="Apple-interchange-newline">
          <blockquote type="cite">
            <meta content="text/html; charset=ISO-8859-1"
              http-equiv="Content-Type">
            <div text="#000000" bgcolor="#FFFFFF"> <br>
              Hi Karen,<br>
              <br>
              Thank you!&nbsp; See below my answer concerning running tests
              with -noverify.&nbsp; I have incorporated your suggestion
              below.&nbsp; <br>
              Please review the following updated webrev:<br>
              <br>
              &nbsp;&nbsp;&nbsp; <a moz-do-not-send="true"
                class="moz-txt-link-freetext"
                href="http://cr.openjdk.java.net/%7Elfoltan/bug_jdk8026065_1/">http://cr.openjdk.java.net/~lfoltan/bug_jdk8026065_1/</a><br>
              <br>
              JDK java.util &amp; lang, along with default method tests
              have passed against this webrev.&nbsp; Currently running JCK *.<br>
              <br>
              Lois<br>
              <br>
              <div class="moz-cite-prefix">On 11/24/2013 5:10 PM, Karen
                Kinnear wrote:<br>
              </div>
              <blockquote
                cite="mid:CAFE9CD6-A776-4904-8591-F62D2896D126@oracle.com"
                type="cite">Lois,
                <div><br>
                </div>
                <div>This looks great! And thank you.</div>
                <div><br>
                </div>
                <div>I assume you ran some set of test examples with and
                  without the verifier?</div>
              </blockquote>
              <br>
              Since JDK java.util &amp; lang proved to flush out the
              most issues with this change I chose to run those with and
              without verification as well as the default method tests.<br>
              <br>
              <blockquote
                cite="mid:CAFE9CD6-A776-4904-8591-F62D2896D126@oracle.com"
                type="cite">
                <div><br>
                </div>
                <div>One question in verifier.cpp:</div>
                <div>&nbsp; You only need the is_same_or_direct check if
                  cp-&gt;tag_at(index).value() ==
                  JVM_CONSTANT_InterfaceMethodef right?</div>
                <div>If so, would it make sense to check that before
                  doing the extra checking rather than before throwing
                  the exception?</div>
                <div>This would maybe be a bit quicker and less risk of
                  breaking existing code.</div>
                <div>The code logic here gets awkwardly nested, so I
                  understand if you tried that and this was cleaner.</div>
                <div><br>
                </div>
                <div>thanks,</div>
                <div>Karen</div>
                <div><br>
                  <div>
                    <div>On Nov 24, 2013, at 4:34 PM, Lois Foltan wrote:</div>
                    <br class="Apple-interchange-newline">
                    <blockquote type="cite">
                      <meta http-equiv="content-type"
                        content="text/html; charset=ISO-8859-1">
                      <div text="#000000" bgcolor="#FFFFFF"> Please
                        review the following fix:<br>
                        <br>
                        Webrev:<br>
                        &nbsp;&nbsp;&nbsp; <a moz-do-not-send="true"
                          class="moz-txt-link-freetext"
                          href="http://cr.openjdk.java.net/%7Elfoltan/bug_jdk8026065/">http://cr.openjdk.java.net/~lfoltan/bug_jdk8026065/</a><br>
                        <br>
                        Bug: InterfaceMethodref for invokespecial must
                        name a direct superinterface<br>
                        &nbsp;&nbsp;&nbsp; <a moz-do-not-send="true"
                          class="moz-txt-link-freetext"
                          href="https://bugs.openjdk.java.net/browse/JDK-8026065">https://bugs.openjdk.java.net/browse/JDK-8026065</a><br>
                        <br>
                        Summary of fix: <br>
                        &nbsp;&nbsp; Add verification to check that
                        InterfaceMethodref for invokespecial names a
                        method in a <br>
                        &nbsp;&nbsp; direct superinterface of the current class or
                        interface.&nbsp; See (JVMS draft 0.7.0) 4.9.2
                        Structural Constraints, <br>
                        <blockquote>&nbsp;&nbsp; "Each invokespecial instruction
                          must name an instance initialization method
                          (2.9), or <br>
                          &nbsp;&nbsp;&nbsp;&nbsp; must reference a method in the current
                          class or interface, a method in a superclass
                          of the <br>
                          &nbsp;&nbsp;&nbsp;&nbsp; current class or interface, or a method
                          in a direct superinterface of the current
                          class or interface." <br>
                        </blockquote>
                        Tests: <br>
                        &nbsp;&nbsp;&nbsp; jtreg hotspot/test/*, JDK java.lang &amp;
                        java.util, vm.quick.testlist, JCK 8 *, JDK1.4
                        JCKs, defmeth tests <br>
                        <br>
                        Thank you, Lois </div>
                    </blockquote>
                  </div>
                  <br>
                </div>
              </blockquote>
              <br>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>