<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Goetz,<br>
<br>
<font size="+1">This is great. Thank you for this cleanup!<br>
Coleen<br>
<br>
</font>
<div class="moz-cite-prefix">On 2/14/14 2:24 AM, Lindenmaier, Goetz
wrote:<br>
</div>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CEA225B@DEWDFEMB12A.global.corp.sap"
type="cite">
<pre wrap="">Hi Jon,
Thanks for your review!
Best regards,
Goetz.
-----Original Message-----
From: Jon Masamitsu [<a class="moz-txt-link-freetext" href="mailto:jon.masamitsu@oracle.com">mailto:jon.masamitsu@oracle.com</a>]
Sent: Donnerstag, 13. Februar 2014 22:39
To: Lindenmaier, Goetz; '<a class="moz-txt-link-abbreviated" href="mailto:hotspot-dev@openjdk.java.net">hotspot-dev@openjdk.java.net</a>'; '<a class="moz-txt-link-abbreviated" href="mailto:hotspot-runtime-dev@openjdk.java.net">hotspot-runtime-dev@openjdk.java.net</a>'; 'Mikael Gerdin (<a class="moz-txt-link-abbreviated" href="mailto:mikael.gerdin@oracle.com">mikael.gerdin@oracle.com</a>)'
Cc: Baesken, Matthias
Subject: Re: RFR(M): 8034171: Remove use of template template parameters from binaryTreeDictionary.
This is a very nice change. Thanks.
Looks good.
Jon
On 02/11/2014 01:02 AM, Lindenmaier, Goetz wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
The template template parameters in the binaryTreeDictionary are not
needed to express its functionality. This change replaces them by simple
class templates and explicit instantiation. This simplifies consumption of
the openJDK in scenarios requiring older C++ compilers.
This change also removes dead get_chunk() from binaryTreeDictionary.cpp.
Bug:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8034171">https://bugs.openjdk.java.net/browse/JDK-8034171</a>
webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~goetz/webrevs/8034171-1-templ/">http://cr.openjdk.java.net/~goetz/webrevs/8034171-1-templ/</a>
Please review and test this change. Unfortunately I don't have access
to JPRT, so I need a sponsor.
I compiled this change on linuxx86_64 with gcc 4.3.4 and 4.8, and on sparcv9 with SS12u1,
on windows amd64 and on sparc. I tested dbg, fdbg and opt builds. The change ran with all our tests
on the ppc port, including jbb2013, jvm2008 and parts of a well-known, publicly
not available test suite without problems.
I would like to downport this change to jdk8u targeting u20 later on.
Could you please also check whether I filed the bug correctly? What should
I put into "affected versions"?
Thanks and best regards,
Goetz.
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>