<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Good point,<br>
<br>
Updated: <a href="http://cr.openjdk.java.net/%7Edsimms/6664815/">http://cr.openjdk.java.net/~dsimms/6664815/</a><br>
<br>
Still looking for one more review for this.<br>
<br>
Thanks,<br>
Marcus<br>
<br>
<div class="moz-cite-prefix">On 04/04/2014 09:30 AM, Ivan Gerasimov
wrote:<br>
</div>
<blockquote cite="mid:533E5FA9.2030909@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Marcus!<br>
<br>
While it's not critical and not really connected to the issue
you're solving, wouldn't it be better to replace<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(238, 238, 238);">344 p = utf8_write(p, base[index]);</pre>
with<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(238, 238, 238);">344 p = utf8_write(p, <b>c</b>);
</pre>
in src/share/vm/utilities/utf8.cpp?<br>
<br>
Sincerely yours,<br>
Ivan<br>
<br>
<br>
<div class="moz-cite-prefix">On 03.04.2014 17:17, Marcus Larsson
wrote:<br>
</div>
<blockquote cite="mid:533D5F54.4060202@oracle.com" type="cite">Hello,
<br>
<br>
I would like reviews for the following bugfix removing a
redundant memcpy. <br>
Built on all platforms and tested with JCK. <br>
<br>
Webrev: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edsimms/6664815/">http://cr.openjdk.java.net/~dsimms/6664815/</a>
<br>
<br>
Bug: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-6664815">https://bugs.openjdk.java.net/browse/JDK-6664815</a>
<br>
<br>
Regards, <br>
Marcus <br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>