From naoto.sato at oracle.com  Tue Jul 10 13:42:55 2012
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 10 Jul 2012 13:42:55 -0700
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
Message-ID: <4FFC93CF.40105@oracle.com>

Hello,

Please review the JDK8 changes for JEP 127: Improve Locale Data 
Packaging and Adopt Unicode CLDR Data 
(http://openjdk.java.net/jeps/127). The webrev is located at:

http://cr.openjdk.java.net/~naoto/6336885/webrev.00/

The main bug id for this enhancement is:

6336885: RFE: Locale Data Deployment Enhancements

Along with this, the following bugs/enhancements are also implemented in 
this change:

4609153 Provide locale data for Indic locales
5104387 Support for gl_ES locale (galician language)
6337471 desktop/system locale preferences support
7056139 (cal) SPI support for locale-dependent Calendar parameters
7058206 Provide CalendarData SPI for week params and display field value 
names
7073852 Support multiple scripts for digits and decimal symbols per locale
7079560 [Fmt-Da] Context dependent month names support in SimpleDateFormat
7171324 getAvailableLocales() of locale sensitive services should return 
the actual availability of locales
7151414 (cal) Support calendar type identification
7168528 LocaleServiceProvider needs to be aware of Locale extensions
7171372 (cal) locale's default Calendar should be created if unknown 
calendar is specified

Please note that packaging changes that relate to Jigsaw module system 
aren't included in this changeset.

Naoto Sato and Masayoshi Okutsu

From Alan.Bateman at oracle.com  Fri Jul 13 08:02:38 2012
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Fri, 13 Jul 2012 16:02:38 +0100
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
In-Reply-To: <4FFC93CF.40105@oracle.com>
References: <4FFC93CF.40105@oracle.com>
Message-ID: <5000388E.3030400@oracle.com>

On 10/07/2012 21:42, Naoto Sato wrote:
> Hello,
>
> Please review the JDK8 changes for JEP 127: Improve Locale Data 
> Packaging and Adopt Unicode CLDR Data 
> (http://openjdk.java.net/jeps/127). The webrev is located at:
>
> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
There's a lot here, lots of good work but way too much for me to review. 
However just one comment to say that the new layout for the resources 
and locales will make it a lot easier to modularize so this aspect is 
very welcome.

-Alan.


From iris.clark at oracle.com  Fri Jul 13 11:32:56 2012
From: iris.clark at oracle.com (Iris Clark)
Date: Fri, 13 Jul 2012 11:32:56 -0700 (PDT)
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
In-Reply-To: <5000388E.3030400@oracle.com>
References: <4FFC93CF.40105@oracle.com> <5000388E.3030400@oracle.com>
Message-ID: <1f9802b5-fb93-42d8-80e5-b4a262969ef9@default>

Hi, Naoto.

Wow.  Tons of fantastic work!

Looks like many files contain fairly trivial changes related to resources being moved to another package, but there are many others which require more careful review.  

Scanning the list of files in the webrev, one comment pops to mind.  You've made changes to the current make files and some of the tools used during make.  Does the build-infra team need to make similar/appropriate changes in the new system?  If they haven't already been brought into the loop, you might want to do so soon.

Thanks,
iris

-----Original Message-----
From: Alan Bateman 
Sent: Friday, July 13, 2012 8:03 AM
To: Naoto Sato
Cc: Java Core Libs; i18n-dev
Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

On 10/07/2012 21:42, Naoto Sato wrote:
> Hello,
>
> Please review the JDK8 changes for JEP 127: Improve Locale Data 
> Packaging and Adopt Unicode CLDR Data 
> (http://openjdk.java.net/jeps/127). The webrev is located at:
>
> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
There's a lot here, lots of good work but way too much for me to review. 
However just one comment to say that the new layout for the resources and locales will make it a lot easier to modularize so this aspect is very welcome.

-Alan.


From naoto.sato at oracle.com  Fri Jul 13 11:59:22 2012
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 13 Jul 2012 11:59:22 -0700
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
In-Reply-To: <1f9802b5-fb93-42d8-80e5-b4a262969ef9@default>
References: <4FFC93CF.40105@oracle.com> <5000388E.3030400@oracle.com>
	<1f9802b5-fb93-42d8-80e5-b4a262969ef9@default>
Message-ID: <5000700A.20301@oracle.com>

Hi Iris,

Thank you for your comment. We had a meeting with the build infra team 
when Erik was here last week, so they are aware of this change. The 
initial review request actually involved 'build-dev' alias besides 
'i18n-dev' and 'core-libs-dev'.

Naoto

On 12/07/13 11:32, Iris Clark wrote:
> Hi, Naoto.
>
> Wow.  Tons of fantastic work!
>
> Looks like many files contain fairly trivial changes related to resources being moved to another package, but there are many others which require more careful review.
>
> Scanning the list of files in the webrev, one comment pops to mind.  You've made changes to the current make files and some of the tools used during make.  Does the build-infra team need to make similar/appropriate changes in the new system?  If they haven't already been brought into the loop, you might want to do so soon.
>
> Thanks,
> iris
>
> -----Original Message-----
> From: Alan Bateman
> Sent: Friday, July 13, 2012 8:03 AM
> To: Naoto Sato
> Cc: Java Core Libs; i18n-dev
> Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data
>
> On 10/07/2012 21:42, Naoto Sato wrote:
>> Hello,
>>
>> Please review the JDK8 changes for JEP 127: Improve Locale Data
>> Packaging and Adopt Unicode CLDR Data
>> (http://openjdk.java.net/jeps/127). The webrev is located at:
>>
>> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
> There's a lot here, lots of good work but way too much for me to review.
> However just one comment to say that the new layout for the resources and locales will make it a lot easier to modularize so this aspect is very welcome.
>
> -Alan.
>



From iris.clark at oracle.com  Fri Jul 13 12:10:14 2012
From: iris.clark at oracle.com (Iris Clark)
Date: Fri, 13 Jul 2012 12:10:14 -0700 (PDT)
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
In-Reply-To: <5000700A.20301@oracle.com>
References: <4FFC93CF.40105@oracle.com> <5000388E.3030400@oracle.com>
	<1f9802b5-fb93-42d8-80e5-b4a262969ef9@default>
	<5000700A.20301@oracle.com>
Message-ID: <6048aea9-c524-48e1-8bfa-490480264679@default>

Hi, Naoto.

Fantastic!  Sorry I didn?t catch that 'build-dev' was in the set of reviewers.

Thanks for being on top of this.

iris

-----Original Message-----
From: Naoto Sato 
Sent: Friday, July 13, 2012 11:59 AM
To: Iris Clark
Cc: Alan Bateman; Java Core Libs; i18n-dev
Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi Iris,

Thank you for your comment. We had a meeting with the build infra team when Erik was here last week, so they are aware of this change. The initial review request actually involved 'build-dev' alias besides 'i18n-dev' and 'core-libs-dev'.

Naoto

On 12/07/13 11:32, Iris Clark wrote:
> Hi, Naoto.
>
> Wow.  Tons of fantastic work!
>
> Looks like many files contain fairly trivial changes related to resources being moved to another package, but there are many others which require more careful review.
>
> Scanning the list of files in the webrev, one comment pops to mind.  You've made changes to the current make files and some of the tools used during make.  Does the build-infra team need to make similar/appropriate changes in the new system?  If they haven't already been brought into the loop, you might want to do so soon.
>
> Thanks,
> iris
>
> -----Original Message-----
> From: Alan Bateman
> Sent: Friday, July 13, 2012 8:03 AM
> To: Naoto Sato
> Cc: Java Core Libs; i18n-dev
> Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale 
> Data Packaging and Adopt Unicode CLDR Data
>
> On 10/07/2012 21:42, Naoto Sato wrote:
>> Hello,
>>
>> Please review the JDK8 changes for JEP 127: Improve Locale Data 
>> Packaging and Adopt Unicode CLDR Data 
>> (http://openjdk.java.net/jeps/127). The webrev is located at:
>>
>> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
> There's a lot here, lots of good work but way too much for me to review.
> However just one comment to say that the new layout for the resources and locales will make it a lot easier to modularize so this aspect is very welcome.
>
> -Alan.
>



From kelly.ohair at oracle.com  Fri Jul 13 13:20:03 2012
From: kelly.ohair at oracle.com (Kelly O'Hair)
Date: Fri, 13 Jul 2012 13:20:03 -0700
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
	Packaging and Adopt Unicode CLDR Data
In-Reply-To: <4FFC93CF.40105@oracle.com>
References: <4FFC93CF.40105@oracle.com>
Message-ID: <FD1B35D1-908F-4F14-8264-1A03BED7FECA@oracle.com>


Something seems strange here:
   http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
It's like someone was avoiding overall quotes, but using them to add spaces somehow...
I sure would like to get rid of this shell logic, seems like there are lots repeated logic that
this script does over and over or could be done with makefile pattern subst's instead of exec's.
---

Overall, just looking at the makefiles, the build-infra team may need some time to fully absorb this into the
new makefiles, some of it will be trivial, not sure all of it will be.

Not sure how to proceed here, the build-infra team does need an action item to deal with this, maybe
before it gets integrated because I suspect the new makefiles will break with all the filename or
directory changes. But I hate to hold up your integration plans.

I'd like to get some advice from Erik on this before saying anything further.

-kto

On Jul 10, 2012, at 1:42 PM, Naoto Sato wrote:

> Hello,
> 
> Please review the JDK8 changes for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data (http://openjdk.java.net/jeps/127). The webrev is located at:
> 
> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
> 
> The main bug id for this enhancement is:
> 
> 6336885: RFE: Locale Data Deployment Enhancements
> 
> Along with this, the following bugs/enhancements are also implemented in this change:
> 
> 4609153 Provide locale data for Indic locales
> 5104387 Support for gl_ES locale (galician language)
> 6337471 desktop/system locale preferences support
> 7056139 (cal) SPI support for locale-dependent Calendar parameters
> 7058206 Provide CalendarData SPI for week params and display field value names
> 7073852 Support multiple scripts for digits and decimal symbols per locale
> 7079560 [Fmt-Da] Context dependent month names support in SimpleDateFormat
> 7171324 getAvailableLocales() of locale sensitive services should return the actual availability of locales
> 7151414 (cal) Support calendar type identification
> 7168528 LocaleServiceProvider needs to be aware of Locale extensions
> 7171372 (cal) locale's default Calendar should be created if unknown calendar is specified
> 
> Please note that packaging changes that relate to Jigsaw module system aren't included in this changeset.
> 
> Naoto Sato and Masayoshi Okutsu


From naoto.sato at oracle.com  Fri Jul 13 14:22:18 2012
From: naoto.sato at oracle.com (Naoto Sato)
Date: Fri, 13 Jul 2012 14:22:18 -0700
Subject: <i18n dev> [8] Review request for JEP 127: Improve Locale Data
 Packaging and Adopt Unicode CLDR Data
In-Reply-To: <FD1B35D1-908F-4F14-8264-1A03BED7FECA@oracle.com>
References: <4FFC93CF.40105@oracle.com>
	<FD1B35D1-908F-4F14-8264-1A03BED7FECA@oracle.com>
Message-ID: <5000918A.708@oracle.com>

Hi Kelly,

The shell script in question is pretty likely to be removed, or at least 
rewritten when we make modifications for Jigsaw packaging of the locale 
data. Right now the script creates the pre-baked locale list based on 
the existing resource bundle source files in the repository, but that 
locale list will have to be created at the run time, not build time.

Naoto

On 12/07/13 13:20, Kelly O'Hair wrote:
>
> Something seems strange here:
>     http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
> It's like someone was avoiding overall quotes, but using them to add spaces somehow...
> I sure would like to get rid of this shell logic, seems like there are lots repeated logic that
> this script does over and over or could be done with makefile pattern subst's instead of exec's.
> ---
>
> Overall, just looking at the makefiles, the build-infra team may need some time to fully absorb this into the
> new makefiles, some of it will be trivial, not sure all of it will be.
>
> Not sure how to proceed here, the build-infra team does need an action item to deal with this, maybe
> before it gets integrated because I suspect the new makefiles will break with all the filename or
> directory changes. But I hate to hold up your integration plans.
>
> I'd like to get some advice from Erik on this before saying anything further.
>
> -kto
>
> On Jul 10, 2012, at 1:42 PM, Naoto Sato wrote:
>
>> Hello,
>>
>> Please review the JDK8 changes for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data (http://openjdk.java.net/jeps/127). The webrev is located at:
>>
>> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
>>
>> The main bug id for this enhancement is:
>>
>> 6336885: RFE: Locale Data Deployment Enhancements
>>
>> Along with this, the following bugs/enhancements are also implemented in this change:
>>
>> 4609153 Provide locale data for Indic locales
>> 5104387 Support for gl_ES locale (galician language)
>> 6337471 desktop/system locale preferences support
>> 7056139 (cal) SPI support for locale-dependent Calendar parameters
>> 7058206 Provide CalendarData SPI for week params and display field value names
>> 7073852 Support multiple scripts for digits and decimal symbols per locale
>> 7079560 [Fmt-Da] Context dependent month names support in SimpleDateFormat
>> 7171324 getAvailableLocales() of locale sensitive services should return the actual availability of locales
>> 7151414 (cal) Support calendar type identification
>> 7168528 LocaleServiceProvider needs to be aware of Locale extensions
>> 7171372 (cal) locale's default Calendar should be created if unknown calendar is specified
>>
>> Please note that packaging changes that relate to Jigsaw module system aren't included in this changeset.
>>
>> Naoto Sato and Masayoshi Okutsu
>