From naoto.sato at oracle.com Mon Jul 1 15:51:51 2013 From: naoto.sato at oracle.com (Naoto Sato) Date: Mon, 01 Jul 2013 15:51:51 -0700 Subject: Preedit string is still exist after focus change operation In-Reply-To: <51D11FB0.6030708@linux.vnet.ibm.com> References: <518B5156.7060205@linux.vnet.ibm.com> <51922E4A.4080004@oracle.com> <51928469.6090009@oracle.com> <51D11FB0.6030708@linux.vnet.ibm.com> Message-ID: <51D20807.3080008@oracle.com> Hi Deven, Looks like the webrev link is broken. Anyway, I briefly looked at the original webrev (embedded down below). I believe that the endComposition on switching the focus to different input context should work on any platforms that Java supports (does not matter the pre-edit is discarded or committed), so fixing Windows depending code does not sound right to me. This issue should be fixed at the Java (platform independent) level. Naoto On 6/30/13 11:20 PM, Deven You wrote: > Hi Anthony and Naoto, > > Thanks very much for your suggestions and help! > > I have created a jtreg test[1] according to the example of > SpuriousExitEnter.java. > > The more detail information about the test could still be inspected by [2]. > > Please review the updated webrev[1]. > > Thanks a lot! > > [1] http://cr.openjdk.java.net/~youdwei/ojdk-687/webrev0.2/ > [2] http://cr.openjdk.java.net/~youdwei/ojdk-687/IMF4/ > On 05/15/2013 02:37 AM, Naoto Sato wrote: >> It does sound like a bug. Moved the web incidents into a JDK bug >> (8014558) >> >> Naoto >> >> On 5/14/13 5:30 AM, Anthony Petrov wrote: >>> Hi Deven, >>> >>> I'm copying i18n-dev@ because they manage the IM code. >>> >>> As to a test, jtreg supports manual tests. See [1] for a lot of tips >>> about using manual tests. An example of a manual test is at: >>> >>> jdk/test/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter.java >>> >>> >>> [1] http://openjdk.java.net/jtreg/faq.html >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 05/09/2013 11:33 AM, Deven You wrote: >>>> Hi All, >>>> >>>> I found there is a problem with our IMF(Input Methods Framework) when >>>> dealing with DBCS input like Chinese and Japanese on Windows 7 32bit >>>> env. >>>> >>>> The simple scenario is if your application has 2 windows and then: >>>> >>>> 1: focus on first window, change to microsoft pinyin input method >>>> Chinese mode. >>>> 2: Input some words, leave some words in preedit string not committed. >>>> 3: Move focus to the other window, change to English mode and input >>>> something >>>> 4: Move back to the first window. It is in English mode, but the >>>> preedit >>>> string is still there(this is the bug). >>>> 5: Delete the preedit string with backspace and press enter, it appears >>>> again. >>>> >>>> I have raised a sunbug for this issue, the internal ID is: 9002399 >>>> >>>> I have written a test case[1] to reproduce this problem on windows 7 32 >>>> bit machine with latest OpenJDK 8. >>>> Since I am not clear how to run this test case as a jtreg, I just >>>> put it >>>> to cr.openjdk.java.net. There are several files within this test case: >>>> >>>> actual-step*.png Steps reproducing the bug. (can >>>> not ) >>>> JTextAreaTest3.java The test case. >>>> Readme.txt Simple description >>>> IMF_04_69120.txt More detail. >>>> >>>> I also made possible patch[2] for this problem. >>>> >>>> Please anyone take a look at this issue and give your suggestion. >>>> >>>> [1] http://cr.openjdk.java.net/~youdwei/ojdk-687/IMF4/ >>>> >>>> [2] http://cr.openjdk.java.net/~youdwei/ojdk-687/webrev/ >>>> >>>> >>>> Thanks a lot! >> > From yuka.kamiya at oracle.com Thu Jul 25 07:42:26 2013 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Thu, 25 Jul 2013 23:42:26 +0900 Subject: Request for review - 8021108: Clean up doclint warnings and errors in java.text package Message-ID: <51F13952.4070909@oracle.com> Hello, Please review the fix for 8021108: Clean up doclint warnings and errors in java.text package for JDK 8. http://cr.openjdk.java.net/~peytoia/8021108/webrev.00/ Joe, Because java.text is not listed in TL team's feature area, ( http://openjdk.java.net/groups/core-libs/ ) I don't send this request to core-libs-dev but to you directly. I'd appreciate it if you could do the final check. Thanks, -- Yuka From joe.darcy at oracle.com Thu Jul 25 11:08:31 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 25 Jul 2013 11:08:31 -0700 Subject: Request for review - 8021108: Clean up doclint warnings and errors in java.text package In-Reply-To: <51F13952.4070909@oracle.com> References: <51F13952.4070909@oracle.com> Message-ID: <51F1699F.5000700@oracle.com> Hi Yuka, Your patch looks good; approved to be back. Thanks, -Joe On 07/25/2013 07:42 AM, Yuka Kamiya wrote: > Hello, > > Please review the fix for > 8021108: Clean up doclint warnings and errors in java.text package > for JDK 8. > > http://cr.openjdk.java.net/~peytoia/8021108/webrev.00/ > > > Joe, > Because java.text is not listed in TL team's feature area, > ( http://openjdk.java.net/groups/core-libs/ ) > I don't send this request to core-libs-dev but to you directly. > I'd appreciate it if you could do the final check. > > Thanks, > -- > Yuka > From masayoshi.okutsu at oracle.com Fri Jul 26 00:03:59 2013 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Fri, 26 Jul 2013 16:03:59 +0900 Subject: Request for review - 8021108: Clean up doclint warnings and errors in java.text package In-Reply-To: <51F13952.4070909@oracle.com> References: <51F13952.4070909@oracle.com> Message-ID: <51F21F5F.80300@oracle.com> java/text/DateFormat.java: /** * Get a default date/time formatter that uses the SHORT style for both the * date and the time. + * + * @return a date formatter */ public final static DateFormat getInstance() { This method returns a DateFormat for both date and time. "a date formatter" may be confusing. "date/time", which isn't very clear, is used in the getDateTimeInstance method. So "a date/time formatter" should be fine (for this doclint cleanup). Otherwise, the fixes look good to me. Masayoshi On 7/25/2013 11:42 PM, Yuka Kamiya wrote: > Hello, > > Please review the fix for > 8021108: Clean up doclint warnings and errors in java.text package > for JDK 8. > > http://cr.openjdk.java.net/~peytoia/8021108/webrev.00/ > > > Joe, > Because java.text is not listed in TL team's feature area, > ( http://openjdk.java.net/groups/core-libs/ ) > I don't send this request to core-libs-dev but to you directly. > I'd appreciate it if you could do the final check. > > Thanks, > -- > Yuka > From yuka.kamiya at oracle.com Fri Jul 26 00:12:37 2013 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Fri, 26 Jul 2013 16:12:37 +0900 Subject: Request for review - 8021108: Clean up doclint warnings and errors in java.text package In-Reply-To: <51F21F5F.80300@oracle.com> References: <51F13952.4070909@oracle.com> <51F21F5F.80300@oracle.com> Message-ID: <51F22165.4000906@oracle.com> Thank you for your reviews, Joe and Masayoshi. I'll reflect Masayoshi's comment in my fix. Thanks, -- Yuka (2013/07/26 16:03), Masayoshi Okutsu wrote: > java/text/DateFormat.java: > > /** > * Get a default date/time formatter that uses the SHORT style for both the > * date and the time. > + * > + * @return a date formatter > */ > public final static DateFormat getInstance() { > > This method returns a DateFormat for both date and time. "a date > formatter" may be confusing. "date/time", which isn't very clear, is > used in the getDateTimeInstance method. So "a date/time formatter" > should be fine (for this doclint cleanup). > > Otherwise, the fixes look good to me. > > Masayoshi > > On 7/25/2013 11:42 PM, Yuka Kamiya wrote: >> Hello, >> >> Please review the fix for >> 8021108: Clean up doclint warnings and errors in java.text package >> for JDK 8. >> >> http://cr.openjdk.java.net/~peytoia/8021108/webrev.00/ >> >> >> Joe, >> Because java.text is not listed in TL team's feature area, >> ( http://openjdk.java.net/groups/core-libs/ ) >> I don't send this request to core-libs-dev but to you directly. >> I'd appreciate it if you could do the final check. >> >> Thanks, >> -- >> Yuka >>