<i18n dev> [8] Request for Review: 6863624 : java/util/Currency/PropertiesTest.sh writable check is incorrect

Alan Bateman Alan.Bateman at oracle.com
Fri Jun 21 13:03:36 PDT 2013


As the test might copy a currency.data into the JDK under test then it 
makes me wonder if this might cause interference for tests that are 
running concurrently (in other VMs). We might have to adding this 
directory to the exclusiveAccess.dir list (I don't know if there is an 
equivalent option that can be added to the @run tag).

Otherwise, I'm scratching my head a bit on why the changes are needed. 
Clearly it fixes the case where $TESTJAVA is writable but the lib or 
jre/lib directory is not. Or is the main fix the cygpath -u ${TESTJAVA} 
so that TESTJAVA has the right path for -w ? If so then the changes look 
fine to me.


On 21/06/2013 18:30, Naoto Sato wrote:
> Still need a reviewer for this one.
> Naoto
> On 6/18/13 1:35 PM, Naoto Sato wrote:
>> Hello,
>> Please review this test case fix:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6863624
>> http://cr.openjdk.java.net/~naoto/6863624/webrev.00/
>> Basically it enforces the check for non-writable JDKs, with a workaround
>> for Cygwin's inconsistent behavior for `test` command. Changes for
>> LocaleProviders are irrelevant for this fix, just the left over from
>> previous fix for 8015960.
>> Naoto

More information about the i18n-dev mailing list