<i18n dev> RFR :8023563: Bottleneck in java.util.TimeZone.getDefaultInAppContext

[Chris Hegarty]

On 2 Sep 2013, at 20:07, Seán Coffey <sean.coffey at oracle.com> wrote:

> Chris -
> 
> you're right on the redundant checks. Had to re-read it! Will get those removed. Thanks.

Otherwise looks fine to me.

-Chris.


> 
> regards,
> Sean.
> 
> On 02/09/13 19:15, Chris Hegarty wrote:
>> On 09/02/2013 07:06 PM, Seán Coffey wrote:
>>> This might be a slightly easier one to read. (fast path logic code first)
>>> 
>>> http://cr.openjdk.java.net/~coffeys/webrev.8023563.2/webrev/
>> 
>> The 'javaAWTAccess != null ' checks are redundant. It will always be the case, right?
>> 
>> -Chris.
>> 
>>> 
>>> regards,
>>> Sean.
>>> 
>>> 
>>> On 02/09/13 16:47, Seán Coffey wrote:
>>>> Performance regression reported where a high number of threads calling
>>>> TimeZone.getDefault can run into a bottleneck on AppContext accessor
>>>> calls. The bug ID is 8023563 but it's not visible on bugs.sun.com yet.
>>>> 
>>>> Turns out that we're unnecessarily going through the AppContext in
>>>> certain scenarios. Main aim is to use AppContext when using applets.
>>>> We should check for presence of security manager (along with loading
>>>> for AppContext class) in such cases.
>>>> 
>>>> http://cr.openjdk.java.net/~coffeys/webrev.8023563/webrev/
>>>> 
>>>> This fix is not applicable to jdk8 as new code is currently being
>>>> worked on there which eliminates AppContext use.
>>>> 
>>>> Regards,
>>>> Sean.
>