<i18n dev> RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Tue May 24 14:49:45 UTC 2016


Changed all binary files (serialized objects) into hex dump text files 
(with ".ser.txt" suffix) and added a utility class to read it as an 
InputStream.

Updated webrev:
http://javasoft.jp.oracle.com/~mokutsu/9/8031145/webrev.01/

Thanks,
Masayoshi

On 5/23/2016 7:02 PM, Alan Bateman wrote:
>
>
> On 23/05/2016 10:12, Masayoshi Okutsu wrote:
>> On 5/23/2016 5:10 PM, Alan Bateman wrote:
>>> Is there anything that we can do with the binary files? In the case 
>>> of the .ser file then could it be a byte[] in the test with an 
>>> execution mode that re-generates it? There is also at least one 
>>> .data file that looks to be the serialized version of a bad 
>>> ChoiceFormat and maybe that could be moved into the source too.
>>
>> I think it's OK for these tests to use ByteArrayInputStream to test 
>> serialization compatibility. I will convert the binary files to 
>> source files.
> Thanks, that would be great and should avoid needing to checking in 
> any binary files.
>
> -Alan



More information about the i18n-dev mailing list