From naoto.sato at oracle.com  Tue May 16 18:14:25 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Tue, 16 May 2017 11:14:25 -0700
Subject: <i18n dev> [9] RFR: 8180375: Rename <baseName>Provider to
 <packagename>.spi.<simpleName>Provider
Message-ID: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>

Hello,

Please review the changes to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8180375

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8180375/webrev.00/

This is to change the package name of the resource bundle provider to a 
different one, by appending ".spi" to the original package name. This 
change effectively avoids possible split package issue if resource 
bundles are provided from other named modules.

Naoto

From mandy.chung at oracle.com  Tue May 16 21:52:15 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Tue, 16 May 2017 14:52:15 -0700
Subject: <i18n dev> [9] RFR: 8180375: Rename <baseName>Provider to
	<packagename>.spi.<simpleName>Provider
In-Reply-To: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>
References: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>
Message-ID: <28128F8D-879C-499C-ADFF-D53DE838A4C9@oracle.com>


> On May 16, 2017, at 11:14 AM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> Hello,
> 
> Please review the changes to the following issue:
> 
> https://bugs.openjdk.java.net/browse/JDK-8180375
> 
> The proposed fix is located at:
> 
> http://cr.openjdk.java.net/~naoto/8180375/webrev.00/
> 
> This is to change the package name of the resource bundle provider to a different one, by appending ".spi" to the original package name. This change effectively avoids possible split package issue if resource bundles are provided from other named modules.

This would ease migration in particular when the provider modules are loaded in a layer defined to multiple loader.  Existing resource bundles can be kept in the same package.

 247  * The service type is designated by {@code package name + ".spi." + simple name +"Provider"}. For

It may be clearer to say {@code <package name> + ?.spi.? + <simple name> + ?Provider?}.


test/java/util/ResourceBundle/modules/appbasic/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
test/java/util/ResourceBundle/modules/appbasic2/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
   - they are provider implmentation classes.  They don?t need to be renamed. If you want to rename them, maybe better to move them to jdk.test.resources.internal package.

test/java/util/ResourceBundle/modules/layer/src/Main.java
test/java/util/ResourceBundle/modules/layer/src/m1/p/Main.java
   Nit: several long lines that can be wrapped.

Otherwise looks fine.

Mandy

From mandy.chung at oracle.com  Tue May 16 22:09:13 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Tue, 16 May 2017 15:09:13 -0700
Subject: <i18n dev> [9] RFR: 8180375: Rename <baseName>Provider to
	<packagename>.spi.<simpleName>Provider
In-Reply-To: <28128F8D-879C-499C-ADFF-D53DE838A4C9@oracle.com>
References: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>
 <28128F8D-879C-499C-ADFF-D53DE838A4C9@oracle.com>
Message-ID: <35C52E7A-539C-4AF2-B123-BC500357383F@oracle.com>

Naoto,

The javadoc of getBundle(String, Module) and getBundle(String,Locale,Module) methods also mention the service type ?baseName?Provider that needs update as well.

Mandy

> On May 16, 2017, at 2:52 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On May 16, 2017, at 11:14 AM, Naoto Sato <naoto.sato at oracle.com> wrote:
>> 
>> Hello,
>> 
>> Please review the changes to the following issue:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8180375
>> 
>> The proposed fix is located at:
>> 
>> http://cr.openjdk.java.net/~naoto/8180375/webrev.00/
>> 
>> This is to change the package name of the resource bundle provider to a different one, by appending ".spi" to the original package name. This change effectively avoids possible split package issue if resource bundles are provided from other named modules.
> 
> This would ease migration in particular when the provider modules are loaded in a layer defined to multiple loader.  Existing resource bundles can be kept in the same package.
> 
> 247  * The service type is designated by {@code package name + ".spi." + simple name +"Provider"}. For
> 
> It may be clearer to say {@code <package name> + ?.spi.? + <simple name> + ?Provider?}.
> 
> 
> test/java/util/ResourceBundle/modules/appbasic/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
> test/java/util/ResourceBundle/modules/appbasic2/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
>   - they are provider implmentation classes.  They don?t need to be renamed. If you want to rename them, maybe better to move them to jdk.test.resources.internal package.
> 
> test/java/util/ResourceBundle/modules/layer/src/Main.java
> test/java/util/ResourceBundle/modules/layer/src/m1/p/Main.java
>   Nit: several long lines that can be wrapped.
> 
> Otherwise looks fine.
> 
> Mandy


From naoto.sato at oracle.com  Wed May 17 22:06:28 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 17 May 2017 15:06:28 -0700
Subject: <i18n dev> [9] RFR: 8180375: Rename <baseName>Provider to
 <packagename>.spi.<simpleName>Provider
In-Reply-To: <35C52E7A-539C-4AF2-B123-BC500357383F@oracle.com>
References: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>
 <28128F8D-879C-499C-ADFF-D53DE838A4C9@oracle.com>
 <35C52E7A-539C-4AF2-B123-BC500357383F@oracle.com>
Message-ID: <234e2f91-3f64-c3ab-cbbe-5eb7b3848697@oracle.com>

Revised the fix according to your suggestions:

http://cr.openjdk.java.net/~naoto/8180375/webrev.01/
http://cr.openjdk.java.net/~naoto/8180375/webrev.01-00/ (change since 
ver.00)

Naoto

On 5/16/17 3:09 PM, Mandy Chung wrote:
> Naoto,
>
> The javadoc of getBundle(String, Module) and getBundle(String,Locale,Module) methods also mention the service type ?baseName?Provider that needs update as well.
>
> Mandy
>
>> On May 16, 2017, at 2:52 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>>
>>> On May 16, 2017, at 11:14 AM, Naoto Sato <naoto.sato at oracle.com> wrote:
>>>
>>> Hello,
>>>
>>> Please review the changes to the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8180375
>>>
>>> The proposed fix is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8180375/webrev.00/
>>>
>>> This is to change the package name of the resource bundle provider to a different one, by appending ".spi" to the original package name. This change effectively avoids possible split package issue if resource bundles are provided from other named modules.
>>
>> This would ease migration in particular when the provider modules are loaded in a layer defined to multiple loader.  Existing resource bundles can be kept in the same package.
>>
>> 247  * The service type is designated by {@code package name + ".spi." + simple name +"Provider"}. For
>>
>> It may be clearer to say {@code <package name> + ?.spi.? + <simple name> + ?Provider?}.
>>
>>
>> test/java/util/ResourceBundle/modules/appbasic/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
>> test/java/util/ResourceBundle/modules/appbasic2/src/test/jdk/test/resources/spi/MyResourcesProviderImpl.java
>>   - they are provider implmentation classes.  They don?t need to be renamed. If you want to rename them, maybe better to move them to jdk.test.resources.internal package.
>>
>> test/java/util/ResourceBundle/modules/layer/src/Main.java
>> test/java/util/ResourceBundle/modules/layer/src/m1/p/Main.java
>>   Nit: several long lines that can be wrapped.
>>
>> Otherwise looks fine.
>>
>> Mandy
>

From mandy.chung at oracle.com  Wed May 17 22:11:23 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Wed, 17 May 2017 15:11:23 -0700
Subject: <i18n dev> [9] RFR: 8180375: Rename <baseName>Provider to
	<packagename>.spi.<simpleName>Provider
In-Reply-To: <234e2f91-3f64-c3ab-cbbe-5eb7b3848697@oracle.com>
References: <10786411-aef4-2035-3063-c40ae67d4bbc@oracle.com>
 <28128F8D-879C-499C-ADFF-D53DE838A4C9@oracle.com>
 <35C52E7A-539C-4AF2-B123-BC500357383F@oracle.com>
 <234e2f91-3f64-c3ab-cbbe-5eb7b3848697@oracle.com>
Message-ID: <34A2D59C-06CD-4854-A55C-51C4DC8C598A@oracle.com>


> On May 17, 2017, at 3:06 PM, Naoto Sato <naoto.sato at oracle.com> wrote:
> 
> Revised the fix according to your suggestions:
> 
> http://cr.openjdk.java.net/~naoto/8180375/webrev.01/
> http://cr.openjdk.java.net/~naoto/8180375/webrev.01-00/ (change since ver.00)

Looks okay to me.

Thanks
Mandy

From nishit.jain at oracle.com  Thu May 18 08:07:06 2017
From: nishit.jain at oracle.com (Nishit Jain)
Date: Thu, 18 May 2017 13:37:06 +0530
Subject: <i18n dev> JDK 10 Review Request for JDK-6609740: [Fmt-De] format
 error in DecimalFormat
Message-ID: <c5762a14-1017-74fd-4924-c3bcd8422b20@oracle.com>

Hi,

Please review the fix for JDK-6609740.

Bug: https://bugs.openjdk.java.net/browse/JDK-6609740
Webrev: http://cr.openjdk.java.net/~nishjain/6609740/webrev.02/

Issue: The negative sub-pattern is not handled properly as specified in 
the API specof DecimalFormat
Fix: Ignore all the special characters e.g. digits, zeroDigit, 
groupingSeparator, decimalSeparator, exponent in a negative 
sub-patternand consider only prefix and suffix part.

Regards,
Nishit Jain

From naoto.sato at oracle.com  Thu May 18 16:59:49 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Thu, 18 May 2017 09:59:49 -0700
Subject: <i18n dev> JDK 10 Review Request for JDK-6609740: [Fmt-De]
 format error in DecimalFormat
In-Reply-To: <c5762a14-1017-74fd-4924-c3bcd8422b20@oracle.com>
References: <c5762a14-1017-74fd-4924-c3bcd8422b20@oracle.com>
Message-ID: <06b89419-681b-709f-bb49-269e0e4c9a32@oracle.com>

Looks fine, Nishit.

Naoto

On 5/18/17 1:07 AM, Nishit Jain wrote:
> Hi,
>
> Please review the fix for JDK-6609740.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6609740
> Webrev: http://cr.openjdk.java.net/~nishjain/6609740/webrev.02/
>
> Issue: The negative sub-pattern is not handled properly as specified in
> the API specof DecimalFormat
> Fix: Ignore all the special characters e.g. digits, zeroDigit,
> groupingSeparator, decimalSeparator, exponent in a negative
> sub-patternand consider only prefix and suffix part.
>
> Regards,
> Nishit Jain

From naoto.sato at oracle.com  Wed May 31 19:41:18 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 31 May 2017 12:41:18 -0700
Subject: <i18n dev> [10] RFR: 8176160, 8176847, 8176853
Message-ID: <63d6a52e-2666-6fd4-9188-207224c5ed79@oracle.com>

Hi Martin,

These are the issues you filed with proposed fixes. I supplemented the 
tests to them. Can you please review these changes:

https://bugs.openjdk.java.net/browse/JDK-8176160
http://cr.openjdk.java.net/~naoto/8176160/webrev.00/

https://bugs.openjdk.java.net/browse/JDK-8176847
http://cr.openjdk.java.net/~naoto/8176847/webrev.00/

https://bugs.openjdk.java.net/browse/JDK-8176853
http://cr.openjdk.java.net/~naoto/8176853/webrev.00/

Naoto


From martinrb at google.com  Wed May 31 20:00:34 2017
From: martinrb at google.com (Martin Buchholz)
Date: Wed, 31 May 2017 13:00:34 -0700
Subject: <i18n dev> [10] RFR: 8176160, 8176847, 8176853
In-Reply-To: <63d6a52e-2666-6fd4-9188-207224c5ed79@oracle.com>
References: <63d6a52e-2666-6fd4-9188-207224c5ed79@oracle.com>
Message-ID: <CA+kOe0-5bMSimN9GfdXPW-py8w=j5m-d9xCvbVxi5LLmT0-5fw@mail.gmail.com>

Thanks - looks good.

---

+    private final static List<String> cals =
+        List.of("gregorian", "japanese", "julian");

If you inline this into main, your beautiful stream pipeline will be even
more beautiful!

---

+import static java.util.Calendar.Builder;

My colleagues would frown upon static importing a builder - just use
"Calendar.Builder" !



On Wed, May 31, 2017 at 12:41 PM, Naoto Sato <naoto.sato at oracle.com> wrote:

> Hi Martin,
>
> These are the issues you filed with proposed fixes. I supplemented the
> tests to them. Can you please review these changes:
>
> https://bugs.openjdk.java.net/browse/JDK-8176160
> http://cr.openjdk.java.net/~naoto/8176160/webrev.00/
>
> https://bugs.openjdk.java.net/browse/JDK-8176847
> http://cr.openjdk.java.net/~naoto/8176847/webrev.00/
>
> https://bugs.openjdk.java.net/browse/JDK-8176853
> http://cr.openjdk.java.net/~naoto/8176853/webrev.00/
>
> Naoto
>
>

From naoto.sato at oracle.com  Wed May 31 21:20:56 2017
From: naoto.sato at oracle.com (Naoto Sato)
Date: Wed, 31 May 2017 14:20:56 -0700
Subject: <i18n dev> [10] RFR: 8176160, 8176847, 8176853
In-Reply-To: <CA+kOe0-5bMSimN9GfdXPW-py8w=j5m-d9xCvbVxi5LLmT0-5fw@mail.gmail.com>
References: <63d6a52e-2666-6fd4-9188-207224c5ed79@oracle.com>
 <CA+kOe0-5bMSimN9GfdXPW-py8w=j5m-d9xCvbVxi5LLmT0-5fw@mail.gmail.com>
Message-ID: <8f961c43-6def-2bbb-9d73-da287a59e01a@oracle.com>

Thanks, Martin. Updated the webrev for each:

http://cr.openjdk.java.net/~naoto/8176160/webrev.01/
http://cr.openjdk.java.net/~naoto/8176847/webrev.01/

Naoto

On 5/31/17 1:00 PM, Martin Buchholz wrote:
> Thanks - looks good.
> 
> ---
> 
> +    private final static List<String> cals =
> +        List.of("gregorian", "japanese", "julian");
> 
> If you inline this into main, your beautiful stream pipeline will be 
> even more beautiful!
> 
> ---
> 
> +import static java.util.Calendar.Builder;
> 
> My colleagues would frown upon static importing a builder - just use 
> "Calendar.Builder" !
> 
> 
> 
> On Wed, May 31, 2017 at 12:41 PM, Naoto Sato <naoto.sato at oracle.com 
> <mailto:naoto.sato at oracle.com>> wrote:
> 
>     Hi Martin,
> 
>     These are the issues you filed with proposed fixes. I supplemented
>     the tests to them. Can you please review these changes:
> 
>     https://bugs.openjdk.java.net/browse/JDK-8176160
>     <https://bugs.openjdk.java.net/browse/JDK-8176160>
>     http://cr.openjdk.java.net/~naoto/8176160/webrev.00/
>     <http://cr.openjdk.java.net/~naoto/8176160/webrev.00/>
> 
>     https://bugs.openjdk.java.net/browse/JDK-8176847
>     <https://bugs.openjdk.java.net/browse/JDK-8176847>
>     http://cr.openjdk.java.net/~naoto/8176847/webrev.00/
>     <http://cr.openjdk.java.net/~naoto/8176847/webrev.00/>
> 
>     https://bugs.openjdk.java.net/browse/JDK-8176853
>     <https://bugs.openjdk.java.net/browse/JDK-8176853>
>     http://cr.openjdk.java.net/~naoto/8176853/webrev.00/
>     <http://cr.openjdk.java.net/~naoto/8176853/webrev.00/>
> 
>     Naoto
> 
>