<i18n dev> RFR: [11] 8202537: CLDR 33

Naoto Sato naoto.sato at oracle.com
Thu Jun 14 19:42:54 UTC 2018


Looks good to me.

Naoto

On 6/14/18 7:01 AM, Rachna Goel wrote:
> Hi Naoto,
> 
> Thanks a lot for the review.
> 
> I have made suggested changes, Kindly have a look at : 
> http://cr.openjdk.java.net/~rgoel/JDK-8202537/webrev.07/
> 
> - Updated NumberingSystemsParseHandler.java
> 
> - Updated LocaleData.cldr for new test case.
> 
> Thanks,
> 
> Rachna
> 
> 
> On 6/13/18 10:33 PM, naoto.sato at oracle.com wrote:
>> Hi Rachna,
>>
>> A couple of comments:
>>
>> - NumberingSystemsParseHandler.java
>>
>> Since the code substitutes latin digits for supplementary digits, it 
>> can skip line 68-79.
>>
>> - A test should be written for the above substitution.
>>
>> Naoto
>>
>> On 6/12/18 10:33 PM, Rachna Goel wrote:
>>> Hi,
>>>
>>> Kindly review fix for JDK-8202537. Fix is to upgrade Unicode 
>>> consortium's CLDR data into JDK from current version 29 to 33.
>>>
>>> For more info : http://cldr.unicode.org/index/downloads/cldr-33
>>>
>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8202537
>>>
>>> Patch: 
>>> http://cr.openjdk.java.net/~rgoel/JDK-8202537/webrev.06/index.html
>>>
> 
> -- 
> Thanks,
> Rachna
> 


More information about the i18n-dev mailing list