From naoto.sato at oracle.com Tue Mar 5 23:20:55 2019 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 5 Mar 2019 15:20:55 -0800 Subject: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time Message-ID: <42f5f5f7-e8bf-9d12-7bbc-0429c9312ad7@oracle.com> Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8218948 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ This is a follow on fix to 8217366. There are several root causes included in this bug, when the runtime supplements missing display names in non-US locales :- - Retrieve the names for the requested id first, before it maps to the canonical id, and on canonicalizing the id, use unique way (canonicalTZID()) to canonicalize. - Retrieve the names in the same manner, between DateFormatSymbols.getZoneStrings() and TimeZone.getDisplayName(). - Correctly map the Chinese locales between JDK and CLDR, in terms of Simplified/Traditional scripts. Naoto From nishit.jain at oracle.com Wed Mar 6 11:56:24 2019 From: nishit.jain at oracle.com (Nishit Jain) Date: Wed, 6 Mar 2019 17:26:24 +0530 Subject: =?utf-8?q?=5B13=5D_RFR_8217254=2C_8217721=3A_CompactNu?= =?utf-8?q?mberFormat=E2=80=8B=28=29_constructor_does_not_comply_with_spec?= =?utf-8?q?_and_format=E2=80=8B=28=29_method_spec_for_IAEx_is_not_complain?= =?utf-8?q?t?= Message-ID: Hi, Please review the fix for JDK-8217254 and JDK-8217721 Bug: https://bugs.openjdk.java.net/browse/JDK-8217254 ???? https://bugs.openjdk.java.net/browse/JDK-8217721 Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/ Issue: The exception thrown by constructor and format() method was not compliant with the specification Fix: Updated the constructor and format method to throw exception as per the specification Regards, Nishit Jain From naoto.sato at oracle.com Wed Mar 6 17:54:41 2019 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 6 Mar 2019 09:54:41 -0800 Subject: =?utf-8?q?=5B13=5D_RFR_8217254=2C_8217721=3A_CompactNu?= =?utf-8?q?mberFormat=E2=80=8B=28=29_constructor_does_not_comply_with_spec?= =?utf-8?q?_and_format=E2=80=8B=28=29_method_spec_for_IAEx_is_not_complain?= =?utf-8?q?t?= In-Reply-To: References: Message-ID: <8d2ca26c-fd85-87e7-3600-de36434612ed@oracle.com> Hi Nishit, Just one comment on j.t.CompactNumberFormat.java. At line 425, Null check can be done at the top of the method, as a parameter check, so that all the unnecessary "if-elseif" can be avoided. Others look good. Naoto On 3/6/19 3:56 AM, Nishit Jain wrote: > Hi, > > Please review the fix for JDK-8217254 and JDK-8217721 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8217254 > ???? https://bugs.openjdk.java.net/browse/JDK-8217721 > > Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/ > > > Issue: The exception thrown by constructor and format() method was not > compliant with the specification > Fix: Updated the constructor and format method to throw exception as per > the specification > > Regards, > Nishit Jain > From nishit.jain at oracle.com Thu Mar 7 11:51:04 2019 From: nishit.jain at oracle.com (Nishit Jain) Date: Thu, 7 Mar 2019 17:21:04 +0530 Subject: =?utf-8?q?=5B13=5D_RFR_8217254=2C_8217721=3A_CompactNu?= =?utf-8?q?mberFormat=E2=80=8B=28=29_constructor_does_not_comply_with_spec?= =?utf-8?q?_and_format=E2=80=8B=28=29_method_spec_for_IAEx_is_not_complain?= =?utf-8?q?t?= In-Reply-To: <8d2ca26c-fd85-87e7-3600-de36434612ed@oracle.com> References: <8d2ca26c-fd85-87e7-3600-de36434612ed@oracle.com> Message-ID: Thanks Naoto, Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/ Regards, Nishit Jain On 06-03-2019 23:24, naoto.sato at oracle.com wrote: > Hi Nishit, > > Just one comment on j.t.CompactNumberFormat.java. At line 425, Null > check can be done at the top of the method, as a parameter check, so > that all the unnecessary "if-elseif" can be avoided. Others look good. > > Naoto > > > On 3/6/19 3:56 AM, Nishit Jain wrote: >> Hi, >> >> Please review the fix for JDK-8217254 and JDK-8217721 >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8217254 >> ????? https://bugs.openjdk.java.net/browse/JDK-8217721 >> >> Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/ >> >> >> Issue: The exception thrown by constructor and format() method was >> not compliant with the specification >> Fix: Updated the constructor and format method to throw exception as >> per the specification >> >> Regards, >> Nishit Jain >> From rachna.goel at oracle.com Thu Mar 7 12:50:44 2019 From: rachna.goel at oracle.com (Rachna Goel) Date: Thu, 7 Mar 2019 18:20:44 +0530 Subject: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time In-Reply-To: <42f5f5f7-e8bf-9d12-7bbc-0429c9312ad7@oracle.com> References: <42f5f5f7-e8bf-9d12-7bbc-0429c9312ad7@oracle.com> Message-ID: <49c97d60-e4ee-e8b3-2ef4-936b0420a9df@oracle.com> Hi Naoto, This fix looks good to me. Thanks, Rachna On 3/6/19 4:50 AM, Naoto Sato wrote: > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8218948 > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ > > This is a follow on fix to 8217366. There are several root causes > included in this bug, when the runtime supplements missing display > names in non-US locales :- > > - Retrieve the names for the requested id first, before it maps to the > canonical id, and on canonicalizing the id, use unique way > (canonicalTZID()) to canonicalize. > > - Retrieve the names in the same manner, between > DateFormatSymbols.getZoneStrings() and TimeZone.getDisplayName(). > > - Correctly map the Chinese locales between JDK and CLDR, in terms of > Simplified/Traditional scripts. > > Naoto -- Thanks, Rachna From naoto.sato at oracle.com Thu Mar 7 17:47:18 2019 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 7 Mar 2019 09:47:18 -0800 Subject: =?utf-8?q?=5B13=5D_RFR_8217254=2C_8217721=3A_CompactNu?= =?utf-8?q?mberFormat=E2=80=8B=28=29_constructor_does_not_comply_with_spec?= =?utf-8?q?_and_format=E2=80=8B=28=29_method_spec_for_IAEx_is_not_complain?= =?utf-8?q?t?= In-Reply-To: References: <8d2ca26c-fd85-87e7-3600-de36434612ed@oracle.com> Message-ID: <81e4cf9f-404c-51fc-ae3b-c2b2cfdde6fa@oracle.com> Looks good. Naoto On 3/7/19 3:51 AM, Nishit Jain wrote: > Thanks Naoto, > > Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/ > > Regards, > Nishit Jain > On 06-03-2019 23:24, naoto.sato at oracle.com wrote: >> Hi Nishit, >> >> Just one comment on j.t.CompactNumberFormat.java. At line 425, Null >> check can be done at the top of the method, as a parameter check, so >> that all the unnecessary "if-elseif" can be avoided. Others look good. >> >> Naoto >> >> >> On 3/6/19 3:56 AM, Nishit Jain wrote: >>> Hi, >>> >>> Please review the fix for JDK-8217254 and JDK-8217721 >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217254 >>> ????? https://bugs.openjdk.java.net/browse/JDK-8217721 >>> >>> Webrev: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.00/ >>> >>> >>> Issue: The exception thrown by constructor and format() method was >>> not compliant with the specification >>> Fix: Updated the constructor and format method to throw exception as >>> per the specification >>> >>> Regards, >>> Nishit Jain >>> > From lance.andersen at oracle.com Thu Mar 7 19:20:54 2019 From: lance.andersen at oracle.com (Lance Andersen) Date: Thu, 7 Mar 2019 14:20:54 -0500 Subject: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time In-Reply-To: <42f5f5f7-e8bf-9d12-7bbc-0429c9312ad7@oracle.com> References: <42f5f5f7-e8bf-9d12-7bbc-0429c9312ad7@oracle.com> Message-ID: <718B49AA-9D7B-4A46-98F4-9FB4E8DFCFF1@oracle.com> Hi Naoto, Sorry for the late review, It looks good to me > On Mar 5, 2019, at 6:20 PM, Naoto Sato wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8218948 > > The proposed changeset is located at: > > http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ > > This is a follow on fix to 8217366. There are several root causes included in this bug, when the runtime supplements missing display names in non-US locales :- > > - Retrieve the names for the requested id first, before it maps to the canonical id, and on canonicalizing the id, use unique way (canonicalTZID()) to canonicalize. > > - Retrieve the names in the same manner, between DateFormatSymbols.getZoneStrings() and TimeZone.getDisplayName(). > > - Correctly map the Chinese locales between JDK and CLDR, in terms of Simplified/Traditional scripts. > > Naoto Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From TOSHIONA at jp.ibm.com Fri Mar 8 06:25:05 2019 From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura) Date: Fri, 8 Mar 2019 15:25:05 +0900 Subject: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 Message-ID: Hi, Could you review this fix? I'd like to have a sponsor of it, since I'm an author. Bug: https://bugs.openjdk.java.net/browse/JDK-8220227 Webrev: http://cr.openjdk.java.net/~tnakamura/8220227/webrev.00/ Issue: Under Windows 10 non-English, Locale.getDisplayCountry() shows an error message, if Host Locale Provider is used (-Djava.locale.providers=HOST). Fix proposal: The current code compares "Unknown Region (" with the result, but it could be translated. I believe we can compare it with "("+RegionCode+")", which covers all 38 Language Packs of Windows Server 2016. Thanks, Toshio Nakamura From naoto.sato at oracle.com Fri Mar 8 17:39:48 2019 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 8 Mar 2019 09:39:48 -0800 Subject: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 In-Reply-To: References: Message-ID: <052c5c92-2af7-2603-e913-2265e14b3781@oracle.com> Hi Nakamura-san, Thanks for fixing this. Since it is using a heuristic way to detect "unknown", I'd use String.endsWith() instead of String.contains() both in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which would be more accurate. Naoto On 3/7/19 10:25 PM, Toshio 5 Nakamura wrote: > > Hi, > > Could you review this fix? I'd like to have a sponsor of it, since I'm an > author. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220227 > Webrev: http://cr.openjdk.java.net/~tnakamura/8220227/webrev.00/ > > Issue: > Under Windows 10 non-English, Locale.getDisplayCountry() shows an error > message, > if Host Locale Provider is used (-Djava.locale.providers=HOST). > > Fix proposal: > The current code compares "Unknown Region (" with the result, but it could > be translated. > I believe we can compare it with "("+RegionCode+")", which covers all 38 > Language > Packs of Windows Server 2016. > > Thanks, > Toshio Nakamura > From TOSHIONA at jp.ibm.com Mon Mar 11 08:57:11 2019 From: TOSHIONA at jp.ibm.com (Toshio 5 Nakamura) Date: Mon, 11 Mar 2019 17:57:11 +0900 Subject: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 In-Reply-To: <052c5c92-2af7-2603-e913-2265e14b3781@oracle.com> References: <052c5c92-2af7-2603-e913-2265e14b3781@oracle.com> Message-ID: Hi Naoto-san, Thank you for reviewing the fix. Could you re-review the updated webrev? http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/ Thanks, Toshio Nakamura naoto.sato at oracle.com wrote on 2019/03/09 02:39:48: > From: naoto.sato at oracle.com > To: Toshio 5 Nakamura , 18n-dev dev at openjdk.java.net>, core-libs-dev > Date: 2019/03/09 02:39 > Subject: Re: [13] RFR: 8220227: Host Locale Provider > getDisplayCountry returns error message under non-English Win10 > > Hi Nakamura-san, > > Thanks for fixing this. Since it is using a heuristic way to detect > "unknown", I'd use String.endsWith() instead of String.contains() both > in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which > would be more accurate. > > Naoto > > On 3/7/19 10:25 PM, Toshio 5 Nakamura wrote: > > > > Hi, > > > > Could you review this fix? I'd like to have a sponsor of it, since I'm an > > author. > > > > Bug: https://urldefense.proofpoint.com/v2/url? > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8220227&d=DwICaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii-- > XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=8UA5DKmhd3SIIZmsX8JNOvaQ5wxcIq5bwdtHAnZLsPU&e= > > Webrev: https://urldefense.proofpoint.com/v2/url? > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8220227_webrev. > 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii-- > XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=kLSymGjxW5MrGtWY3zs7VEdg1BN6nYGQjue1w- > nPs7c&e= > > > > Issue: > > Under Windows 10 non-English, Locale.getDisplayCountry() shows an error > > message, > > if Host Locale Provider is used (-Djava.locale.providers=HOST). > > > > Fix proposal: > > The current code compares "Unknown Region (" with the result, but it could > > be translated. > > I believe we can compare it with "("+RegionCode+")", which covers all 38 > > Language > > Packs of Windows Server 2016. > > > > Thanks, > > Toshio Nakamura > > > From rachna.goel at oracle.com Mon Mar 11 10:06:12 2019 From: rachna.goel at oracle.com (Rachna Goel) Date: Mon, 11 Mar 2019 15:36:12 +0530 Subject: Fwd: RFR: JDK-8220414 :Correct copyright headers in Norm2AllModes.java and Normalizer2.java In-Reply-To: <6e95fc42-9c89-6eb8-849c-f8fc04e72703@oracle.com> References: <6e95fc42-9c89-6eb8-849c-f8fc04e72703@oracle.com> Message-ID: <6c966fe2-61d4-ab5e-6c69-017ee01d2fa4@oracle.com> Hi, Kindly review fix to JDK-8220414, which updates copyright header. Bug: https://bugs.openjdk.java.net/browse/JDK-8220414 diff -r 645ba889ee5f src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java --- a/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java Mon Jan 28 16:42:23 2019 +0100 +++ b/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java Mon Mar 11 13:02:59 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2018 Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it diff -r 645ba889ee5f src/java.base/share/classes/sun/text/normalizer/Normalizer2.java --- a/src/java.base/share/classes/sun/text/normalizer/Normalizer2.java Mon Jan 28 16:42:23 2019 +0100 +++ b/src/java.base/share/classes/sun/text/normalizer/Normalizer2.java Mon Mar 11 13:02:59 2019 +0530 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2018 Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it -- Thanks, Rachna From Alan.Bateman at oracle.com Mon Mar 11 10:23:15 2019 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 11 Mar 2019 10:23:15 +0000 Subject: Fwd: RFR: JDK-8220414 :Correct copyright headers in Norm2AllModes.java and Normalizer2.java In-Reply-To: <6c966fe2-61d4-ab5e-6c69-017ee01d2fa4@oracle.com> References: <6e95fc42-9c89-6eb8-849c-f8fc04e72703@oracle.com> <6c966fe2-61d4-ab5e-6c69-017ee01d2fa4@oracle.com> Message-ID: <945da3b0-95d7-393f-c6b0-94b178dcf273@oracle.com> Looks good. On 11/03/2019 10:06, Rachna Goel wrote: > Hi, > > Kindly review fix to JDK-8220414, which updates copyright header. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220414 > > diff -r 645ba889ee5f > src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java > --- > a/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java > Mon Jan 28 16:42:23 2019 +0100 > +++ > b/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java > Mon Mar 11 13:02:59 2019 +0530 > @@ -1,5 +1,5 @@ > ?/* > - * Copyright (c) 2015, 2018 Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights > reserved. > ? * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > ? * > ? * This code is free software; you can redistribute it and/or modify it > diff -r 645ba889ee5f > src/java.base/share/classes/sun/text/normalizer/Normalizer2.java > --- a/src/java.base/share/classes/sun/text/normalizer/Normalizer2.java > Mon Jan 28 16:42:23 2019 +0100 > +++ b/src/java.base/share/classes/sun/text/normalizer/Normalizer2.java > Mon Mar 11 13:02:59 2019 +0530 > @@ -1,5 +1,5 @@ > ?/* > - * Copyright (c) 2015, 2018 Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights > reserved. > ? * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > ? * > ? * This code is free software; you can redistribute it and/or modify it > From takiguc at linux.vnet.ibm.com Mon Mar 11 13:00:14 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Mon, 11 Mar 2019 22:00:14 +0900 Subject: RFR: 8213232 Unix/X11 setCompositionEnableNative issue In-Reply-To: <50e98ca5cbdc56a5a13b0754968521c2@linux.vnet.ibm.com> References: <9ad6f2166ea8eabcf7391feccf9d8915@linux.vnet.ibm.com> <0a651f1099a96e314573b6b8c9f60e6c@linux.vnet.ibm.com> <50e98ca5cbdc56a5a13b0754968521c2@linux.vnet.ibm.com> Message-ID: Hello. Could you review the fix and give me your suggestion, please ? Thanks, Ichiroh Takiguchi On 2019-02-26 22:08, Ichiroh Takiguchi wrote: > Hello. > > Could you review the fix ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213232 > Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.01/ > > JDK-8213232 [1] has movies. > Please check it. > > I applied following changes on webrev.01: > 1. According to "Xlib - C Language X Interface" [2] > See "Preedit State Callbacks" section: > PreeditStartCallback() should return int. > 2. Add 64bit Big Endian CPU support, like s390x > 3. Change copyright year > > [1] https://bugs.openjdk.java.net/browse/JDK-8213232 > [2] > https://www.x.org/releases/X11R7.6/doc/libX11/specs/libX11/libX11.html > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > On 2018-12-04 11:22, Ichiroh Takiguchi wrote: >> Hello. >> >> Could you review the fix ? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8213232 >> Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ >> >> This issue is related by wrong usage of XNPreeditState on >> XSetICValues(). >> Because of wrong usage, UnsupportedOperationException exception >> happened with Xlib bundled input method. >> Test instructions is in JDK-8213232. >> >> I'd like to obtain a sponsor for this issue. >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >> >> On 2018-06-19 02:15, Ichiroh Takiguchi wrote: >>> Hello, >>> IBM would like to contribute Unix/X11 setCompositionEnableNative >>> issue >>> patch to OpenJDK project. >>> >>> Issue: >>> To turn on or turn off IME via Java, XNPreeditState should be used >>> with XSetValues(). >>> But it should be nested via XVaCreateNestedList() since >>> XNPreeditState >>> is a part of XNPreeditAttributes. >>> Current code is, like: >>> - ret = XSetICValues(pX11IMData->current_ic, XNPreeditState, >>> - (enable ? XIMPreeditEnable : >>> XIMPreeditDisable), NULL); >>> But it should be, like: >>> + pr_atrb = XVaCreateNestedList(0, >>> + XNPreeditState, (enable ? XIMPreeditEnable : >>> XIMPreeditDisable), >>> + NULL); >>> + ret = XSetICValues(pX11IMData->current_ic, XNPreeditAttributes, >>> pr_atrb, NULL); >>> >>> On Linux platform, the issue can check with following test program >>> and >>> kinput2 XIM server and >>> Wnn8 for Linux/BSD (htt). >>> ================== >>> import java.awt.*; >>> import java.awt.event.*; >>> import javax.swing.*; >>> >>> public class CompositionEnabledTest extends JFrame { >>> CompositionEnabledTest() { >>> Container c = getContentPane(); >>> c.setLayout(new GridLayout(0,2)); >>> JButton btn; >>> JTextField tf; >>> btn = new JButton("Undefined"); >>> c.add(btn); >>> tf = new JTextField("Undefined"); >>> c.add(tf); >>> btn = new JButton("Disabled"); >>> btn.addFocusListener(new MyFocusListener(false)); >>> c.add(btn); >>> tf = new JTextField("Disabled"); >>> tf.addFocusListener(new MyFocusListener(false)); >>> c.add(tf); >>> btn = new JButton("Enabled"); >>> btn.addFocusListener(new MyFocusListener(true)); >>> c.add(btn); >>> tf = new JTextField("Enabled"); >>> tf.addFocusListener(new MyFocusListener(true)); >>> c.add(tf); >>> setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); >>> pack(); >>> setVisible(true); >>> } >>> class MyFocusListener implements FocusListener { >>> boolean state; >>> MyFocusListener(boolean state) { >>> this.state = state; >>> } >>> public void focusGained(FocusEvent fe) { >>> >>> fe.getComponent().getInputContext().setCompositionEnabled(state); >>> } >>> public void focusLost(FocusEvent fe) { } >>> } >>> public static void main(String[] args) { >>> new CompositionEnabledTest(); >>> } >>> } >>> ================== >>> >>> Click JTextField and JButton, then XIM server status may be changed. >>> If XIM server does not support XNPreeditState, it does not work. >>> >>> I'd like contribute following 3 files: >>> M src/java.desktop/share/classes/sun/awt/im/InputContext.java >>> M src/java.desktop/unix/classes/sun/awt/X11InputMethod.java >>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >>> >>> http://cr.openjdk.java.net/~aleonard/set_composition_enabled/webrev.00/ >>> >>> I appreciate any feedback please, and how I would go about obtaining >>> a >>> sponsor and contributor? >>> >>> Thanks, >>> Ichiroh Takiguchi >>> IBM Japan, Ltd. From naoto.sato at oracle.com Mon Mar 11 16:29:02 2019 From: naoto.sato at oracle.com (Naoto Sato) Date: Mon, 11 Mar 2019 09:29:02 -0700 Subject: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 In-Reply-To: References: <052c5c92-2af7-2603-e913-2265e14b3781@oracle.com> Message-ID: <8373556b-982d-b7e6-aa29-3344d9d563c7@oracle.com> Looks good to me. I can sponsor your fix. Naoto On 3/11/19 1:57 AM, Toshio 5 Nakamura wrote: > Hi Naoto-san, > > Thank you for reviewing the fix. > Could you re-review the updated webrev? > > http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/ > > Thanks, > Toshio Nakamura > > naoto.sato at oracle.com wrote on 2019/03/09 02:39:48: > > > From: naoto.sato at oracle.com > > To: Toshio 5 Nakamura , 18n-dev > dev at openjdk.java.net>, core-libs-dev > > Date: 2019/03/09 02:39 > > Subject: Re: [13] RFR: 8220227: Host Locale Provider > > getDisplayCountry returns error message under non-English Win10 > > > > Hi Nakamura-san, > > > > Thanks for fixing this. Since it is using a heuristic way to detect > > "unknown", I'd use String.endsWith() instead of String.contains() both > > in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which > > would be more accurate. > > > > Naoto > > > > On 3/7/19 10:25 PM, Toshio 5 Nakamura wrote: > > > > > > Hi, > > > > > > Could you review this fix? I'd like to have a sponsor of it, since > I'm an > > > author. > > > > > > Bug: INVALID URI REMOVED > > > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8220227&d=DwICaQ&c=jf_iaSHvJObTbx- > > siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii-- > > > XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=8UA5DKmhd3SIIZmsX8JNOvaQ5wxcIq5bwdtHAnZLsPU&e= > > > Webrev: INVALID URI REMOVED > > u=http-3A__cr.openjdk.java.net_-7Etnakamura_8220227_webrev. > > 00_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2- > > qsMtyulHUruf8lAzMlVpVRqw&m=cWI02BT4Ii-- > > XvWPkl7JnE5M_ShlPLTERbtkTMMn1mU&s=kLSymGjxW5MrGtWY3zs7VEdg1BN6nYGQjue1w- > > nPs7c&e= > > > > > > Issue: > > > Under Windows 10 non-English, Locale.getDisplayCountry() shows an error > > > message, > > > if Host Locale Provider is used (-Djava.locale.providers=HOST). > > > > > > Fix proposal: > > > The current code compares "Unknown Region (" with the result, but > it could > > > be translated. > > > I believe we can compare it with "("+RegionCode+")", which covers > all 38 > > > Language > > > Packs of Windows Server 2016. > > > > > > Thanks, > > > Toshio Nakamura > > > > > > From naoto.sato at oracle.com Thu Mar 21 20:54:50 2019 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 21 Mar 2019 13:54:50 -0700 Subject: [13] RFR: 8220224: With CLDR provider, NumberFormat.format could not handle locale with number extension correctly. Message-ID: <6dba7fd4-3bc1-fe5f-8a6d-c00b6078a659@oracle.com> Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8220224 Here is the CSR and proposed changeset: https://bugs.openjdk.java.net/browse/JDK-8220728 http://cr.openjdk.java.net/~naoto/8220224/webrev.01/ DecimalFormatSymbols assumes minus/percent/permille as a single character, which is not capable of supporting ones for BiDi languages that involve BiDi formatting characters. With this fix, DecimalFormatSymbols uses String variants of symbols from CLDR, and retains them for serialization. The above webrev contains tag cleanup which was suggested in the CSR. The following webrev only contains relevant changes to the issue (excluding those cleanup): http://cr.openjdk.java.net/~naoto/8220224/webrev.00/ Naoto From takiguc at linux.vnet.ibm.com Mon Mar 25 16:28:02 2019 From: takiguc at linux.vnet.ibm.com (Ichiroh Takiguchi) Date: Tue, 26 Mar 2019 01:28:02 +0900 Subject: RFR: 8213232 Unix/X11 setCompositionEnableNative issue In-Reply-To: References: <9ad6f2166ea8eabcf7391feccf9d8915@linux.vnet.ibm.com> <0a651f1099a96e314573b6b8c9f60e6c@linux.vnet.ibm.com> <50e98ca5cbdc56a5a13b0754968521c2@linux.vnet.ibm.com> Message-ID: <2a317b57477504d617ef46a0cbfc28a9@linux.vnet.ibm.com> Hello. Could you review the fix and give me your suggestion, please ? I really appreciate your feedback. Currently, UnsupportedOperationException happens because of invalid usage by input method operation. And I'd like to obtain a sponsor for this issue. Thanks, Ichiroh Takiguchi On 2019-03-11 22:00, Ichiroh Takiguchi wrote: > Hello. > > Could you review the fix and give me your suggestion, please ? > > Thanks, > Ichiroh Takiguchi > > On 2019-02-26 22:08, Ichiroh Takiguchi wrote: >> Hello. >> >> Could you review the fix ? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8213232 >> Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.01/ >> >> JDK-8213232 [1] has movies. >> Please check it. >> >> I applied following changes on webrev.01: >> 1. According to "Xlib - C Language X Interface" [2] >> See "Preedit State Callbacks" section: >> PreeditStartCallback() should return int. >> 2. Add 64bit Big Endian CPU support, like s390x >> 3. Change copyright year >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8213232 >> [2] >> https://www.x.org/releases/X11R7.6/doc/libX11/specs/libX11/libX11.html >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >> >> On 2018-12-04 11:22, Ichiroh Takiguchi wrote: >>> Hello. >>> >>> Could you review the fix ? >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213232 >>> Change: https://cr.openjdk.java.net/~itakiguchi/8213232/webrev.00/ >>> >>> This issue is related by wrong usage of XNPreeditState on >>> XSetICValues(). >>> Because of wrong usage, UnsupportedOperationException exception >>> happened with Xlib bundled input method. >>> Test instructions is in JDK-8213232. >>> >>> I'd like to obtain a sponsor for this issue. >>> >>> Thanks, >>> Ichiroh Takiguchi >>> IBM Japan, Ltd. >>> >>> On 2018-06-19 02:15, Ichiroh Takiguchi wrote: >>>> Hello, >>>> IBM would like to contribute Unix/X11 setCompositionEnableNative >>>> issue >>>> patch to OpenJDK project. >>>> >>>> Issue: >>>> To turn on or turn off IME via Java, XNPreeditState should be used >>>> with XSetValues(). >>>> But it should be nested via XVaCreateNestedList() since >>>> XNPreeditState >>>> is a part of XNPreeditAttributes. >>>> Current code is, like: >>>> - ret = XSetICValues(pX11IMData->current_ic, XNPreeditState, >>>> - (enable ? XIMPreeditEnable : >>>> XIMPreeditDisable), NULL); >>>> But it should be, like: >>>> + pr_atrb = XVaCreateNestedList(0, >>>> + XNPreeditState, (enable ? XIMPreeditEnable : >>>> XIMPreeditDisable), >>>> + NULL); >>>> + ret = XSetICValues(pX11IMData->current_ic, XNPreeditAttributes, >>>> pr_atrb, NULL); >>>> >>>> On Linux platform, the issue can check with following test program >>>> and >>>> kinput2 XIM server and >>>> Wnn8 for Linux/BSD (htt). >>>> ================== >>>> import java.awt.*; >>>> import java.awt.event.*; >>>> import javax.swing.*; >>>> >>>> public class CompositionEnabledTest extends JFrame { >>>> CompositionEnabledTest() { >>>> Container c = getContentPane(); >>>> c.setLayout(new GridLayout(0,2)); >>>> JButton btn; >>>> JTextField tf; >>>> btn = new JButton("Undefined"); >>>> c.add(btn); >>>> tf = new JTextField("Undefined"); >>>> c.add(tf); >>>> btn = new JButton("Disabled"); >>>> btn.addFocusListener(new MyFocusListener(false)); >>>> c.add(btn); >>>> tf = new JTextField("Disabled"); >>>> tf.addFocusListener(new MyFocusListener(false)); >>>> c.add(tf); >>>> btn = new JButton("Enabled"); >>>> btn.addFocusListener(new MyFocusListener(true)); >>>> c.add(btn); >>>> tf = new JTextField("Enabled"); >>>> tf.addFocusListener(new MyFocusListener(true)); >>>> c.add(tf); >>>> setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); >>>> pack(); >>>> setVisible(true); >>>> } >>>> class MyFocusListener implements FocusListener { >>>> boolean state; >>>> MyFocusListener(boolean state) { >>>> this.state = state; >>>> } >>>> public void focusGained(FocusEvent fe) { >>>> >>>> fe.getComponent().getInputContext().setCompositionEnabled(state); >>>> } >>>> public void focusLost(FocusEvent fe) { } >>>> } >>>> public static void main(String[] args) { >>>> new CompositionEnabledTest(); >>>> } >>>> } >>>> ================== >>>> >>>> Click JTextField and JButton, then XIM server status may be changed. >>>> If XIM server does not support XNPreeditState, it does not work. >>>> >>>> I'd like contribute following 3 files: >>>> M src/java.desktop/share/classes/sun/awt/im/InputContext.java >>>> M src/java.desktop/unix/classes/sun/awt/X11InputMethod.java >>>> M src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >>>> >>>> http://cr.openjdk.java.net/~aleonard/set_composition_enabled/webrev.00/ >>>> >>>> I appreciate any feedback please, and how I would go about obtaining >>>> a >>>> sponsor and contributor? >>>> >>>> Thanks, >>>> Ichiroh Takiguchi >>>> IBM Japan, Ltd.