<i18n dev> RFR: 8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark [v2]

Ian Graves igraves at openjdk.java.net
Fri Sep 10 21:02:45 UTC 2021

On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves <igraves at openjdk.org> wrote:

>> The duplicate condition in this chain of expressions needs to be shrunk to drop a couple of character that are not excluded spacing marks.
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>   Refactoring test to whitebox

Updating the tests here. Existing ones included code copy/pasted directly from the unit under test. Refactored to a whitebox-style testing that injects accessors into `java.util.regex` so we don't have to modify code in two places to keep it in sync. Also relaxed two private static methods in `java.util.regex.Grapheme` to package-private so the injected accessor class can reach them and expose them for the test.


PR: https://git.openjdk.java.net/jdk/pull/5425

More information about the i18n-dev mailing list