<i18n dev> RFR: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

Joe Wang joehw at openjdk.java.net
Tue Sep 21 22:09:00 UTC 2021


On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing an AIOOBE on normalizing the month value.

Marked as reviewed by joehw (Reviewer).

src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:

> 279:             month = 13 - (xm % 12);
> 280:             if (month == 13) {
> 281:                 year ++;

Not that it matters, just happen to see it ;-). Is it more common to have no space before the increment operator? Code convention seems to suggest no space before increment and their operands. 
No update needed should you decide to remove it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5611


More information about the i18n-dev mailing list