RFR 7902706: IntelliJ jtreg plugin crashes because of removal of deprecated icon
maurizio.cimadamore at oracle.com
Fri Oct 16 20:28:50 UTC 2020
On 16/10/2020 20:02, Jonathan Gibbons wrote:
> I'm not an expert on this code, but the changes look reasonable to me.
> Given that this code has been in use for a while, you can consider
> this as an approval.
> -- Jon
> On 6/18/20 3:07 AM, Maurizio Cimadamore wrote:
>> this is a path that fixes the crash in the intellij jtreg plugin
>> which started to occur in the latest version 2020.1.
>> This patch is based on some work submitted few weeks ago by John Rhee
>> ; I sprinkled the usual reflective goop on top to make sure that
>> the plugin keeps working against old versions too (as the new Target
>> icon is only defined for 2019.x).
>> I've also added an overload for a method whose implementation is
>> deprecated, namely ConfigurationFactory::getId; this should keep
>> things from breaking in the medium run.
>> As a general note, I see that the IDE is giving quite a bit of
>> warning around the plugin code - in many instances IntelliJ is trying
>> to move towards a lazier/more declarative way to register listener to
>> events . But I think a point will come in which we won't be able
>> to evolve the plugin in a compatible way - so at some point in the
>> future we should probably start thinking about dropping support for
>> older version and start using 2019 as base.
>>  -
>>  -
More information about the ide-support-dev