From ivan.gerasimov at oracle.com Mon Nov 3 13:16:51 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 03 Nov 2014 16:16:51 +0300 Subject: RFR 8062647: Wrong indentation of arguments of annotated methods In-Reply-To: <5456E8CD.1000107@oracle.com> References: <54539F0F.6030704@oracle.com> <5456E8CD.1000107@oracle.com> Message-ID: <54578043.1090708@oracle.com> Thanks David. Forwarding the request to the correct ML. Sincerely yours, Ivan On 03.11.2014 5:30, David Holmes wrote: > Ivan, > > javadoc tool changes need to be reviewed by the javadoc folk not > serviceability. > > David > > On 1/11/2014 12:39 AM, Ivan Gerasimov wrote: >> Hello everybody! >> >> I noticed that the javadoc tool may produce the doc with misaligned >> arguments of annotated methods in the 'method details' section. >> For example: >> http://jre.us.oracle.com/java/re/jdk/9/nightly/latest/docs/api/java/util/EnumSet.html#of-E-E...- >> >> >> >> Would you please help review the fix? >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8062647 >> WEBREV: http://cr.openjdk.java.net/~igerasim/8062647/0/webrev/ >> >> Sincerely yours, >> Ivan > > From jonathan.gibbons at oracle.com Mon Nov 3 18:00:55 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 03 Nov 2014 10:00:55 -0800 Subject: RFR 8062647: Wrong indentation of arguments of annotated methods In-Reply-To: <54578043.1090708@oracle.com> References: <54539F0F.6030704@oracle.com> <5456E8CD.1000107@oracle.com> <54578043.1090708@oracle.com> Message-ID: <5457C2D7.80202@oracle.com> Ivan, Changes to the source code like this require a corresponding test. -- Jon On 11/03/2014 05:16 AM, Ivan Gerasimov wrote: > Thanks David. > > Forwarding the request to the correct ML. > > Sincerely yours, > Ivan > > On 03.11.2014 5:30, David Holmes wrote: >> Ivan, >> >> javadoc tool changes need to be reviewed by the javadoc folk not >> serviceability. >> >> David >> >> On 1/11/2014 12:39 AM, Ivan Gerasimov wrote: >>> Hello everybody! >>> >>> I noticed that the javadoc tool may produce the doc with misaligned >>> arguments of annotated methods in the 'method details' section. >>> For example: >>> http://jre.us.oracle.com/java/re/jdk/9/nightly/latest/docs/api/java/util/EnumSet.html#of-E-E...- >>> >>> >>> >>> Would you please help review the fix? >>> >>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8062647 >>> WEBREV: http://cr.openjdk.java.net/~igerasim/8062647/0/webrev/ >>> >>> Sincerely yours, >>> Ivan >> >> > From jonathan.gibbons at oracle.com Fri Nov 7 19:01:10 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 07 Nov 2014 11:01:10 -0800 Subject: javadoc style question Message-ID: <545D16F6.101@oracle.com> Bhavesh, Check out this page: http://docs.oracle.com/javase/8/docs/api/java/lang/reflect/InvocationHandler.html#invoke-java.lang.Object-java.lang.reflect.Method-java.lang.Object:A- Look at the large paragraphs for the Parameters, Returns and Throws sections. Is there are good reason why the paragraph bodies are in monospace format? Would it make more sense to use the standard serif body font here? Is this worth an RFE in JBS? -- Jon From bhavesh.x.patel at oracle.com Fri Nov 7 22:04:43 2014 From: bhavesh.x.patel at oracle.com (Bhavesh Patel) Date: Fri, 7 Nov 2014 14:04:43 -0800 (PST) Subject: javadoc style question Message-ID: <0db2491d-dd60-4223-8959-20634e4e86a8@default> Yes. It does look different. There is no particular reason for the difference that I can think of. This is a part of the 2 different UI styles that Jeff Hoffman's team designed and was approved by Mark. But I think it should be using the standard serif font. I will file it as a P4 RFE. Regards, Bhavesh. ----- Original Message ----- From: jonathan.gibbons at oracle.com To: javadoc-dev at openjdk.java.net Sent: Friday, November 7, 2014 11:01:47 AM GMT -08:00 US/Canada Pacific Subject: javadoc style question Bhavesh, Check out this page: http://docs.oracle.com/javase/8/docs/api/java/lang/reflect/InvocationHandler.html#invoke-java.lang.Object-java.lang.reflect.Method-java.lang.Object:A- Look at the large paragraphs for the Parameters, Returns and Throws sections. Is there are good reason why the paragraph bodies are in monospace format? Would it make more sense to use the standard serif body font here? Is this worth an RFE in JBS? -- Jon From jonathan.gibbons at oracle.com Mon Nov 10 17:17:36 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 10 Nov 2014 09:17:36 -0800 Subject: javadoc style question In-Reply-To: <5460D930.2030202@oracle.com> References: <0db2491d-dd60-4223-8959-20634e4e86a8@default> <5460D930.2030202@oracle.com> Message-ID: <5460F330.9060606@oracle.com> This page is notable for having unusually long text (paragraphs) for these tags instead of the normally shorter text (phrases). That makes the different format more than usually obvious. -- Jon On 11/10/2014 07:26 AM, Kumar Srinivasan wrote: > Curiosity question: But why only this specific page ? All other pages > look ok ? > > Kumar > > > On 11/7/2014 2:04 PM, Bhavesh Patel wrote: >> Yes. It does look different. There is no particular reason for the >> difference that I can think of. This is a part of the 2 different UI >> styles that Jeff Hoffman's team designed and was approved by Mark. >> But I think it should be using the standard serif font. I will file >> it as a P4 RFE. >> >> Regards, >> Bhavesh. >> >> ----- Original Message ----- >> From: jonathan.gibbons at oracle.com >> To: javadoc-dev at openjdk.java.net >> Sent: Friday, November 7, 2014 11:01:47 AM GMT -08:00 US/Canada Pacific >> Subject: javadoc style question >> >> Bhavesh, >> >> Check out this page: >> http://docs.oracle.com/javase/8/docs/api/java/lang/reflect/InvocationHandler.html#invoke-java.lang.Object-java.lang.reflect.Method-java.lang.Object:A- >> >> >> Look at the large paragraphs for the Parameters, Returns and Throws >> sections. >> >> Is there are good reason why the paragraph bodies are in monospace >> format? Would it make more sense to use the standard serif body font >> here? >> >> Is this worth an RFE in JBS? >> >> -- Jon > From kumar.x.srinivasan at oracle.com Mon Nov 10 15:26:40 2014 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Mon, 10 Nov 2014 07:26:40 -0800 Subject: javadoc style question In-Reply-To: <0db2491d-dd60-4223-8959-20634e4e86a8@default> References: <0db2491d-dd60-4223-8959-20634e4e86a8@default> Message-ID: <5460D930.2030202@oracle.com> Curiosity question: But why only this specific page ? All other pages look ok ? Kumar On 11/7/2014 2:04 PM, Bhavesh Patel wrote: > Yes. It does look different. There is no particular reason for the difference that I can think of. This is a part of the 2 different UI styles that Jeff Hoffman's team designed and was approved by Mark. But I think it should be using the standard serif font. I will file it as a P4 RFE. > > Regards, > Bhavesh. > > ----- Original Message ----- > From: jonathan.gibbons at oracle.com > To: javadoc-dev at openjdk.java.net > Sent: Friday, November 7, 2014 11:01:47 AM GMT -08:00 US/Canada Pacific > Subject: javadoc style question > > Bhavesh, > > Check out this page: > http://docs.oracle.com/javase/8/docs/api/java/lang/reflect/InvocationHandler.html#invoke-java.lang.Object-java.lang.reflect.Method-java.lang.Object:A- > > Look at the large paragraphs for the Parameters, Returns and Throws > sections. > > Is there are good reason why the paragraph bodies are in monospace > format? Would it make more sense to use the standard serif body font here? > > Is this worth an RFE in JBS? > > -- Jon