From jonathan.gibbons at oracle.com Thu Aug 8 19:53:25 2019 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 8 Aug 2019 12:53:25 -0700 Subject: RFR: [doc-only] JDK-8227697,,Improve text in Taglet API spec for expected results with standard doclet Message-ID: <56436930-b714-5c2c-894c-d92c08c13c38@oracle.com> Please review a doc-only change to improve the documentation regarding user--defined taglets.? There is no change in behavior. The CSR for the change has been approved. JBS: https://bugs.openjdk.java.net/browse/JDK-8227697 CSR: https://bugs.openjdk.java.net/browse/JDK-8228561 Webrev: http://cr.openjdk.java.net/~jjg/8228561-taglet-stddoclet/webrev.00/ -- Jon From hannes.wallnoefer at oracle.com Fri Aug 9 14:56:20 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Fri, 9 Aug 2019 16:56:20 +0200 Subject: RFR: [doc-only] JDK-8227697, , Improve text in Taglet API spec for expected results with standard doclet In-Reply-To: <56436930-b714-5c2c-894c-d92c08c13c38@oracle.com> References: <56436930-b714-5c2c-894c-d92c08c13c38@oracle.com> Message-ID: Hi Jon, The Taglet#toString documentation gets a link to StandardDoclet.html#taglet-requirements which doesn?t exist. I guess the target anchor should be #user-defined-taglets, or did you plan to add another anchor to the paragraph and list with the requirements? Otherwise looks good. Hannes > Am 08.08.2019 um 21:53 schrieb Jonathan Gibbons : > > Please review a doc-only change to improve the documentation regarding user--defined taglets. There is no change in behavior. > > The CSR for the change has been approved. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8227697 > CSR: https://bugs.openjdk.java.net/browse/JDK-8228561 > Webrev: http://cr.openjdk.java.net/~jjg/8228561-taglet-stddoclet/webrev.00/ > > -- Jon > From jonathan.gibbons at oracle.com Fri Aug 9 15:42:54 2019 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 9 Aug 2019 08:42:54 -0700 Subject: RFR: [doc-only] JDK-8227697, , Improve text in Taglet API spec for expected results with standard doclet In-Reply-To: References: <56436930-b714-5c2c-894c-d92c08c13c38@oracle.com> Message-ID: <07c335c4-e0fe-bf74-0d16-996a19234a73@oracle.com> Thanks; I'll fix the link and push.?? I guess I forgot to run a link-checker after the last round of edits. -- Jon On 8/9/19 7:56 AM, Hannes Walln?fer wrote: > Hi Jon, > > The Taglet#toString documentation gets a link to StandardDoclet.html#taglet-requirements which doesn?t exist. I guess the target anchor should be #user-defined-taglets, or did you plan to add another anchor to the paragraph and list with the requirements? > > Otherwise looks good. > > Hannes > > >> Am 08.08.2019 um 21:53 schrieb Jonathan Gibbons : >> >> Please review a doc-only change to improve the documentation regarding user--defined taglets. There is no change in behavior. >> >> The CSR for the change has been approved. >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8227697 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8228561 >> Webrev: http://cr.openjdk.java.net/~jjg/8228561-taglet-stddoclet/webrev.00/ >> >> -- Jon >>