10 RFR 8192833: JEP 322: Time-Based Release Versioning

mark.reinhold at oracle.com mark.reinhold at oracle.com
Wed Dec 6 04:29:55 UTC 2017

2017/12/5 19:38:03 -0800, mandy.chung at oracle.com:
> On 12/5/17 8:18 AM, mark.reinhold at oracle.com wrote:
>> Specdiff: http://cr.openjdk.java.net/~mr/jeps/322/specdiff/
>> Webrev:   http://cr.openjdk.java.net/~mr/jeps/322/rev/
> @since 10 is missing in the new methods added in Runtime.Version methods.

Oops!  I'll add them.

> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java
>   The fix for JDK-8185130 was pushed today that has a couple new 
> calls to major/minor method. This file and GenerateJLIClassesPlugin 
> will need to be updated once you pull down the changeset.

Thanks for the warning.  I'll fix this when I rebase.

> A few MRJAR tests still call the deprecated methods (e.g. 
> test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java). It's 
> okay to leave it for future cleanup. I mentioned it just in case you 
> intend to do the renaming in the tests as well.

I don't plan to rename invocations of the old methods in existing tests,
other than what I've done in the test for `Runtime.Version` itself.


- Mark

More information about the jdk-dev mailing list