[10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception
Naoto Sato
naoto.sato at oracle.com
Wed Jan 17 13:06:25 UTC 2018
Looks good to me. As Rachna mentioned, please add @bug to
LocaleDataTest.java. No further review is needed.
Naoto
On 1/17/18 12:50 AM, Hamlin Li wrote:
> Hi Rachna,
>
> I'm not sure, but I think in this case (it's a test bug) @bug 8195478
> should not be added.
>
> Thank you
>
> -Hamlin
>
>
> On 17/01/2018 4:45 PM, Rachna Goel wrote:
>>
>> Hi Hamlin,
>>
>> Just one nit, Please add bug id 8195478 to
>> sun/text/resources/LocaleDataTest.java.
>>
>> Thanks,
>>
>> Rachna
>>
>>
>> On 1/17/2018 1:37 PM, Hamlin Li wrote:
>>> Would you please review the following patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8195478
>>>
>>> webrev as below
>>>
>>> I have tested it locally.
>>>
>>>
>>> Thank you
>>>
>>> -Hamlin
>>> ------------------------------------------------------------------------
>>>
>>> diff -r 19effb7970bc test/jdk/sun/text/resources/LocaleData
>>> --- a/test/jdk/sun/text/resources/LocaleData Thu Jan 11 20:19:50
>>> 2018 -0800
>>> +++ b/test/jdk/sun/text/resources/LocaleData Wed Jan 17 16:02:25
>>> 2018 +0800
>>> @@ -6396,7 +6396,6 @@
>>> CurrencyNames//ang=Netherlands Antillean Guilder
>>> CurrencyNames//awg=Aruban Florin
>>> CurrencyNames//azm=Azerbaijani Manat (1993-2006)
>>> -CurrencyNames//azn=Azerbaijani Manat
>>> CurrencyNames//bbd=Barbadian Dollar
>>> CurrencyNames//bdt=Bangladeshi Taka
>>> CurrencyNames//bgn=Bulgarian Lev
>>
>
More information about the jdk-dev
mailing list