[PATCH] JDK-8233680: JavacFileManager.close() doesn't clear some cache instance variables

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Dec 19 22:51:32 UTC 2019


dropping: jdk-dev at openjdk.java.net,
follow-ups to: compiler-dev at openjdk.java.net

Daniel,

While I appreciate that you have written a test, these days our policy 
is to not use shell script for writing compiler tests, unless it is 
absolutely necessary, which it almost never is.

It is also curious that your test depends on the use of javadoc, which 
is unusual for a compiler test.

Is it possible to write the test in Java, and to not depend on javadoc?

-- Jon


On 12/18/2019 11:35 PM, Daniel Le Duc Khoi Nguyen wrote:
> Hi everyone,
>
> I've already included all relevant information at
> https://bugs.openjdk.java.net/browse/JDK-8233680. I'm just going to
> attach the patch (with tests) below.
>
> Since this is my first patch, please help guide me through the
> process. Thank you.
>



More information about the jdk-dev mailing list