[PATCH] Properly (.hg)ignore the JTwork and JTreport directories
david.holmes at oracle.com
Sun Jun 30 05:33:23 UTC 2019
On 29/06/2019 5:16 am, Jaikiran Pai wrote:
> Can I please get a review and a sponsor for this patch which fixes
> the .hgignore file to take into account the JTreport and JTwork
> directories that can reside at the root of the repository.
I don't see any problem with current settings. I wonder if it is hg
> hg status -i | grep "I JT"
But this patch doesn't seem to cause me any problems either.
> In its current form (without this patch), if I have these directories at
> the root of my repo, then these aren't being ignored. I see output like
> below for commands like "hg st":
> $> hg st
> ? JTreport/html/config.html
> ? JTreport/html/env.html
> ? JTreport/html/error.html
> ? JTreport/html/error_gr.html
> ? JTreport/html/excluded.html
> ? JTreport/html/failed.html
> With the proposed patch, these directories are correctly ignored. With
> this patch, I also tested that similar directories which are within
> sub-directories of the repo are ignored too, by running arbitrary jtreg
> tests to generate such directories at different locations.
> The change in that patch uses the "glob" syntax noted in  to properly
> exclude these directories. I haven't explicitly tested it for the ".git"
> directory being ignored in that list, but I expect the change is needed
> for that directory too and hence decided to include it in the patch.
> I'm a bit new to the contribution process and don't know if changes like
> these need a JBS issue to be created. If it's needed, I can create one
> and regenerate a webrev to reference it. So please do let me know.
> FWIW, I am on:
> hg --version
> Mercurial Distributed SCM (version 4.3.1)
> (see https://mercurial-scm.org for more information)
>  http://cr.openjdk.java.net/~jpai/webrev/hgignore-patch/webrev/
>  https://www.selenic.com/mercurial/hgignore.5.html
More information about the jdk-dev