[14] RFR (l10n) 8238377 : JDK 14 L10n resource files update - msg drop 20

naoto.sato at oracle.com naoto.sato at oracle.com
Mon Feb 3 16:45:02 UTC 2020

Hi Leo,

On 2/3/20 7:21 AM, li.jiang at oracle.com wrote:
> Hi Naoto,
> For wxl file, the mentioned problems are not issue.
> 1.
> The wxl files are only working for window installer, so DOS format is 
> good for these files, or even better.

CRs should not be in source files in the OpenJDK repository. Here is the 
quote from jcheck (http://openjdk.java.net/projects/code-tools/jcheck/):

"Changeset comments and source files do not contain tabs, carriage 
returns, or trailing spaces;"

> 2.
> The localized wxl is generated by t9n system, so they may normalize (in 
> their standard) the text. If we keep the double quotes, they would be 
> converted to single quote again in next round of msg drop.
> I have checked the other wxl files in our repo, same as the line1 in 
> this review.

If the tool is normalizing as such, why the second line was not 
affected? It keeps the spaces and double quotes as they are.


> Thanks,
> Leo
> On 2/3/20 11:07 PM, naoto.sato at oracle.com wrote:
>> Hi Leo,
>> Those .properties files look good to me. For those two .wxl files:
>> - Files seem to be saved in DOS format (contains CR/LFs as new lines).
>> - Line no. 1 is incorrectly modified. Includes unnecessary spaces, and 
>> double quotes are changed to single quotes.
>> Naoto
>> On 2/2/20 7:46 PM, li.jiang at oracle.com wrote:
>>> Hi,
>>> Please review the update for L10n resource files in JDK 14 msg drop 
>>> 20. In this fix, we cover l10n resource files for the MSI installer 
>>> of jpackage and the latest update from jdeps and jshell.
>>> https://bugs.openjdk.java.net/browse/JDK-8238377
>>> http://cr.openjdk.java.net/~ljiang/8238377/webrev/read/
>>> Thanks,
>>> Leo

More information about the jdk-dev mailing list