Status of GitHub automatic tier1 testing

Robin Westberg robin.westberg at oracle.com
Fri Oct 2 14:03:14 UTC 2020


Hi Thomas,

> On 2 Oct 2020, at 15:48, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
> On 02.10.20 15:41, Robin Westberg wrote:
>> Hi all,
>> As you may have noticed when pushing changes to your personal forks recently, GitHub will now automatically trigger basic tier1 testing on the supported platforms (currently Linux, Windows and macOS, all x64). If all goes well you may not even notice it as it defaults to sending a notification only if anything should fail.
>> However, please note that the first version of this automatic test execution contained a problem that could cause it to not detect failing test cases. I know there have been a few test errors that have gone by unnoticed due to this for which I’m sorry. The good news is that the problem is now fixed starting with https://github.com/openjdk/jdk/commit/7dcdc1fbdd9d5b21253537ee59dd70f4e8f3d002 - so make sure that your branch contains this change if you plan to look at the test results!
>> Apart from this there are now no known issues with these pre-submit tests, so if you run into any problem, please let me know. If these tests turn out to be reasonably stable and trustworthy, the next step will be to present a summary of the results in the body of PRs to make them more visible.
>> Best regards,
>> Robi
> 
>  thanks for your effort.
> 
> I would like to ask for a way to opt out - the public personal may receive unfinished work that may not even compile in a lot of cases. So this pre-checking seems like a waste of cpu time in a lot of cases and another notification I do not want in my inbox.
> 
> After the fifth or so a day I'll probably just ignore it anyway.
> 
> Also there are a significant amount of pushes that are done just fixing a typo in a comment or such, again wasting time.
> 
> I can somewhat understand such testing for different situations.

Certainly, depending on how often you push changes, running these tests on every commit may indeed be quite wasteful. Fortunately, it’s possible to opt out in a few different ways! I’m planning to add this information to the Skara wiki soon, but in the meantime, here are your current options:

1) Disable GitHub Actions completely for your fork - https://github.com/<your_github_id>/jdk/settings/actions and select Disable.

2) Only run automatic testing for branches that start with “submit/“ - in this way you can trigger tests on selected branches from the command line with something like this:

$ git push origin mybranch:submit/test_of_my_branch

To enable this mode of operation, go to https://github.com/<your_github_id>/jdk/settings/secrets and click on “New secret”. Enter the name “JDK_SUBMIT_FILTER” and set the value to a non-empty random string, perhaps “yes, enable this”.

3) Only run automatic testing on a subset of available platforms to improve execution time. To enable this mode of operation, see #2, but instead create a secret named “JDK_SUBMIT_PLATFORMS” with a value like “Linux x64” or “macOS x64, Windows x64”.

I guess my recommendation would be #2 to begin with, in case you want to retain the ability to execute these tests manually on occasion.

Best regards,
Robin
> 
> Thanks,
>  Thomas



More information about the jdk-dev mailing list