Clarification regarding the GitHub Actions pre-submit testing
shade at redhat.com
Thu Mar 18 18:54:47 UTC 2021
On 3/18/21 7:31 PM, Andrew Haley wrote:
> Here's how I think it could work. If there is an obvious/trivial
> fix revealed by GHA testing, the committer should fix it,
> Otherwise, it should be fixed by the port maintainer. In the
> latter case, the committer should try to contact the port
> maintainer to explain the situation. The committer isn't required
> to wait for longer than X days.
Agreed, this seems like a good compromise.
This works well with the majority of problems that are easily resolvable (the point that I was
trying to stress in this thread), while leaving the contributor with the way to sidestep a hard
issue that only a port maintainer can resolve, *and* port maintainer gets heads-up to step in before
the avoidable breakage is introduced.
Port-maintainer view: contributing an addendum to the large feature PR that stubs out / unbreaks the
platform is much less stressful than fixing the post-integration build failures days after, while
CIs are in shambles and are missing other build/test bugs.
More information about the jdk-dev