RFR[11u] (XS) : 8215128 : Test library OSInfo.getSolarisVersion cannot determine Solaris version
igor.ignatyev at oracle.com
Thu Dec 13 22:10:19 UTC 2018
thanks for the review!
> On Dec 13, 2018, at 12:01 PM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>> On 12 Dec 2018, at 19:08, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 2 lines changed: 1 ins; 0 del; 1 mod;
>> Hi all,
>> could you please review this small patch for jdk.testlibrary.OSInfo::getSolarisVersion method? the method assumed that $(uname -v) output on Solaris can be parsed as double, which is not always true. the patch changes this method to remove all characters starting from the second dot if any.
>> webrev: http://cr.openjdk.java.net/~iignatyev//8215128/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215128
> The change looks good to me.
> Also, it is not applicable to JDK 12 ( or later ), since the code already
> handles this situation.
More information about the jdk-updates-dev