FYI: request backports for 8239091, 8238942, 8224109 and 8214481

Mario Torre neugens at redhat.com
Mon Apr 6 19:27:15 UTC 2020


On Mon, Apr 6, 2020 at 9:05 PM Langer, Christoph
<christoph.langer at sap.com> wrote:
>
> Hi Mario,
>
> thanks for being cautious here.

Hi Christoph,

> Looking at this change, however, it's hard to believe that it can have any functional effect, unless you had set your FREETYPE_PROPERTIES variable to the exact string "interpreter-version".

Ouch, I pasted the wrong bug ID before!! The patch I want to retire is
this (and sorry for the noise!):

https://bugs.openjdk.java.net/browse/JDK-8214481

While I still want to keep the others: 8224109, 8238942 and 8239091.

The FT_LOAD_NO_HINTING change is the problem for me. In some fonts and
with fractional metrics enabled it causes the rendering to be very
blurry. I do remember this to be the case in 8 or 7 at some point and
then it was finally fixed, so this change is a regression for me, this
is most likely tied to freetype but I don't understand why it's not
happening in 14+ with all the same code and compiled the same way, so
clearly I'm missing a patch somewhere and I would like to figure out
which one.

> Shall I withdraw the approval flags or do you just need a bit of time for further testing?

Yes, I think I'll take another day or two to test. I have built the
jdk with the default settings. I thought that the FREETYPE_PROPERTIES
thing was responsible at first but I didn't change this and is not set
in my build, but I'll need to do some more testing. I do remember we
had a couple of changes related to this as well as changes specific to
fractional metrics, but the code is actually the same at this stage
between 15-dev and 11-dev.

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898



More information about the jdk-updates-dev mailing list