RFR [jdk11]: 8211301: [macos] support full window content options
Langer, Christoph
christoph.langer at sap.com
Tue Apr 21 10:53:53 UTC 2020
Hi Matthias,
it would be nice if you could give a little hint on what place you had to modify . I assume it was the first hunk in src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m…
There, I think it would align better with the upstream patch, if you would as well change the indentation of “type |= NSClosableWindowMask” and “type |= NSResizableWindowMask” as was done upstream. Can you please do that before pushing?
Otherwise, looks good. No need to see another webrev.
Best regards
Christoph
From: Baesken, Matthias <matthias.baesken at sap.com>
Sent: Montag, 20. April 2020 10:05
To: jdk-updates-dev at openjdk.java.net
Cc: Langer, Christoph <christoph.langer at sap.com>
Subject: RFR [jdk11]: 8211301: [macos] support full window content options
Hello, please review the jdk11 backport of 8211301 . I had to adjust the change slightly compared to jdk/jdk .
Bug/ jdk11 webrev :
https://bugs.openjdk.java.net/browse/JDK-8211301
http://cr.openjdk.java.net/~mbaesken/webrevs/8211301_0_jdk11/
original jdk/jdk webrev :
http://hg.openjdk.java.net/jdk/jdk/rev/85fb403c0141
Best regards, Matthias
More information about the jdk-updates-dev
mailing list