RFR [jdk11]: 8211301: [macos] support full window content options

[Baesken, Matthias]

Thanks for the review !

I’ll do the adjustment you mentioned, before I push the change .

Best regards, Matthias

From: Langer, Christoph <christoph.langer at sap.com>
Sent: Dienstag, 21. April 2020 12:54
To: Baesken, Matthias <matthias.baesken at sap.com>; jdk-updates-dev at openjdk.java.net
Subject: RE: RFR [jdk11]: 8211301: [macos] support full window content options

Hi Matthias,

it would be nice if you could give a little hint on what place you had to modify ��. I assume it was the first hunk in src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m…

There, I think it would align better with the upstream patch, if you would as well change the indentation of “type |= NSClosableWindowMask” and “type |= NSResizableWindowMask” as was done upstream. Can you please do that before pushing?

Otherwise, looks good. No need to see another webrev.

Best regards
Christoph


From: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Sent: Montag, 20. April 2020 10:05
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Cc: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>
Subject: RFR [jdk11]: 8211301: [macos] support full window content options

Hello, please review the jdk11 backport of 8211301 .  I had to adjust the change slightly compared to jdk/jdk .


Bug/ jdk11 webrev :

https://bugs.openjdk.java.net/browse/JDK-8211301

http://cr.openjdk.java.net/~mbaesken/webrevs/8211301_0_jdk11/

original jdk/jdk webrev :

http://hg.openjdk.java.net/jdk/jdk/rev/85fb403c0141


Best regards, Matthias