[jdk11u-dev] RFR: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
Denghui Dong
ddong at openjdk.java.net
Mon Jun 21 03:20:05 UTC 2021
Could I have a review of this backport that fixes a crash problem?
Although there are many conflicts, I think it's necessary to backport it to 11u since the problem is very easy to reproduce.
And I hope JFR's folks could review it.
In addition to the different context of modified files, I think the following items we should review carefully:
1. use MaxJfrEventId + 100 instead of LAST_TYPE_ID + 1 as the klass id of void.class
2. jdk 11 doesn't support jfr streaming, so I removed the call `JfrTraceIdEpoch::set_changed_tag_state()` in `load_primitive`
3. the Class in jdk 11 doesn't have the file 'hidden', so I removed `writer->write<bool>(false);` in `write_primitive`
4. there are many differences in the API of JfrTraceId between 11u and tip
Thanks,
Denghui
-------------
Commit messages:
- Backport a9d2267f8d306522522c999ff584ccaa34c46456
Changes: https://git.openjdk.java.net/jdk11u-dev/pull/47/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk11u-dev&pr=47&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8260589
Stats: 218 lines in 6 files changed: 206 ins; 3 del; 9 mod
Patch: https://git.openjdk.java.net/jdk11u-dev/pull/47.diff
Fetch: git fetch https://git.openjdk.java.net/jdk11u-dev pull/47/head:pull/47
PR: https://git.openjdk.java.net/jdk11u-dev/pull/47
More information about the jdk-updates-dev
mailing list