[jdk17u-dev] RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

[Matthias Baesken]

On Wed, 20 Jul 2022 08:12:48 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

>> I backport this for parity with 17.0.5-oracle.
>> 
>> The localization file "de" patched by the original change is not in 17.
>> It was added in "8283805: [REDO] JDK 19 L10n resource files update - msgdrop 10"
>> I had a look at backporting that change, too. I think the localization updates are
>> a nice to have for the LTS. But it is a big change and does not apply well. Each new/removed entry would
>> have to be checked. So I decided not to do it.
>> Instead, I inlcude the de file for jpackage in this change, along with the two 
>> new Strings. This file matches the jpackage in 17 as there were no other addions to 
>> the ja and zh files between 17 and 8283805.
>> 
>> I had to adapt the copyright in the ja and zh files.
>
> Goetz Lindenmaier has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport b523c88480ba5c8f9d78537c9de0abcbf1f867c0

Looks okay to me thanks for backporting.
Just wondering why the german (_de) properties files contains english texts for the new entries like ERR_MacAppStoreRuntimeBinExists.
Shouldn't this be adjusted most (all?) of the other texts is in german so it looks a little strange to me and for the new properties we get the same like we would get with the english main properties file?

-------------

Marked as reviewed by mbaesken (Reviewer).

PR: https://git.openjdk.org/jdk17u-dev/pull/565