New project: getting rid of IcedTea local patches

[Andrew John Hughes]

2009/4/1 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
> Andrew John Hughes wrote:
>>
>> 2009/4/1 Andrew John Hughes <gnu_andrew at member.fsf.org>:
>>>
>>> 2009/4/1 Kelly O'Hair <Kelly.Ohair at sun.com>:
>>>>
>>>> Andrew Haley wrote:
>>>>>
>>>>> We at Red Hat have noticed that the list of IcedTea local patches has
>>>>> been getting large, with some local patches that should have been
>>>>> pushed upstream.  Also, some IcedTea patches have been committed to
>>>>> OpenJDK 7 but not OpenJDK 6.
>>>>>
>>>>> So, we're going to have a serious attempt to minimize the number of
>>>>> IcedTea patches.  We'll create a Wiki page at icedtea.classpath.org
>>>>> that is a list of the patches, and for every one we're going to
>>>>> discuss whether it should stay IcedTea local, be pushed upstream to
>>>>> OpenJDK, or be deleted altogether.  Then we will create OpenJDK
>>>>> bugzilla entries for the patches that we think should be integrated
>>>>> upstream and work with Sun engineers to get that done.
>>>>>
>>>>> I hope that it will be possible to reduce the number of patches to a
>>>>> fraction of what we have at the moment, while improving the quality of
>>>>> the upstream product.
>>>>>
>>>>> This is going to be quite a lot of work, so we'd appreciate help from
>>>>> anyone.
>>>>>
>>>>> I hope this will meet with everyone's approval.
>>>>>
>>>>> Andrew.
>>>>
>>>> Sounds great.
>>>>
>>>> I can certainly help out with any build related (makefiles etc.)
>>>> changes.
>>>>
>>>> -kto
>>>>
>>>>
>>> Good, because to my knowledge, those form the majority :)
>>> However, my guess would also be that some require extensive reworking
>>> to be generally acceptable (e.g. providing the option to build using
>>> system libraries rather than forcing it).
>>> --
>>> Andrew :-)
>>>
>>> Free Java Software Engineer
>>> Red Hat, Inc. (http://www.redhat.com)
>>>
>>> Support Free Java!
>>> Contribute to GNU Classpath and the OpenJDK
>>> http://www.gnu.org/software/classpath
>>> http://openjdk.java.net
>>>
>>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>>> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>>>
>>
>> On the other hand, there is some low-hanging fruit.  Andrew Haley
>> reminded me of this patch earlier today:
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6781583
>>
>> which went into OpenJDK7.  The patch itself should be trivial to
>> approve, given it has already been through the process once.  The main
>> issue is that it relies on OpenJDK6 being updated to hs14.  Is there
>> any news on this and of the public stable branch of this version?
>>
>
> I made sure there is a '6-open' version of this bug.
> Not sure what the state of hs14 in OpenJDK6 is, but if hs14 is
> 'done' we may need to apply this patch to OpenJDK6's hotspot,
> making it a hs14+ kind of.
> I'll pass this decision onto Joe. ;^)
>

Thanks.  To my knowledge, OpenJDK6 is still on hs11.  With IcedTea6
(which builds against OpenJDK6 b14), we do an rm -rf hotspot and
download the last hs14 changeset to use instead (fc6a5ae3fef5) from
http://hg.openjdk.java.net/jdk7/hotspot/hotspot.  We then apply three
patches to the newly acquired b14 hotspot which achieve the same as
the one attached to that bug report (these were developed
independently, two of them sometime before that changeset).

> -kto
>
>> As to committing, do those on the OpenJDK commit list have access to
>> all repositories (given patch approval obviously) or is it restricted
>> in some way?  As myself, Gary and Andrew Haley all are now on this
>> list, it would be good to start the process of committing patches
>> ourself once approved.
>>
>> Thanks,
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8