Request for approval for 7154030 - java.awt.Component.hide() does not repaint parent component

Jonathan Lu luchsh at linux.vnet.ibm.com
Sun Aug 5 19:15:01 PDT 2012


On 08/03/2012 10:46 PM, Pavel Porvatov wrote:
> Hi Jonathan,
>> Jonathan,
>>
>> A bug fix can introduce behavioural changes which should not be 
>> allowed in update releases.
>>
>> In fact, I've just noticed that this fix caused issue in JCK 
>> verification for JDK 8.
>> See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7168144 which 
>> is linked to 7154030
> Seán absolutely right. You should take into account fix of CR 7168144 
> while backportinng. Both CR should be backported together in one fix, 
> I believe.
>
> Regards, Pavel
>>
>> I think you may either have to get a swing engineer to review for 
>> this port to 7u or start a specific thread for it on swing-dev.
>> If swing reviewers do approve this for backporting, then 7168144 
>> changeset will also need porting (simple tag fix for JCK test issue)
>> http://mail.openjdk.java.net/pipermail/awt-dev/2012-May/002793.html
>>
>> Regards,
>> Sean.
>>
>> On 02/08/2012 08:41, Jonathan Lu wrote:
>>> Hello Sean,
>>>
>>> From my point of view, this backport only introduces a fix for a 
>>> existing bug 7154030.
>>>
>>> regards,
>>> Jonathan
>>>
>>> On 08/01/2012 12:05 AM, Seán Coffey wrote:
>>>> Hi Jonathan,
>>>>
>>>> does this backport introduce any behavioural changes that could 
>>>> cause issue for an update release (as opposed to a feature 
>>>> release/JDK8) ? I'm cc'ing the original reviewer here to confirm 
>>>> this is ok for an update release just to be sure.  Pavel, any 
>>>> issues with this going into 7u ? Granted, this is all around a 
>>>> deprecated API so hopefully many applications aren't using it anymore.
>>>>
>>>> regards,
>>>> Sean.
>>>>
>>>> On 30/07/2012 23:31, Jonathan Lu wrote:
>>>>> Hello,
>>>>>
>>>>> I'm requesting an approval to backport the fix for bug 7154030
>>>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7154030
>>>>>
>>>>> Change set from jdk8,
>>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/340cda7e1430
>>>>>
>>>>> the same patch is applicable for jdk7u8.
>>>>>
>>>>> The fix has been review here,
>>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2012-March/002362.html
>>>>>
>>>>> Thank you
>>>>>  Jonathan
>>>>>
>>>>
>>>
>
Thanks Pavel, I'm submitting a new fix with both changes.

Best regards
Jonathan




More information about the jdk7u-dev mailing list