7u40 Request for approval for CR 8013900: More warnings compiling jaxp.

Seán Coffey sean.coffey at oracle.com
Sat Jun 1 10:50:30 PDT 2013


Approved.

regards,
Sean.

On 31/05/13 09:31, Daniel Fuchs wrote:
> Hi,
>
> This is a request for approval to backport
> <https://jbs.oracle.com/bugs/browse/JDK-8013900>
> The fix adds several hashCode() methods to classes that were
> redefining equals without redefining hashCode().
>
> The changeset for jdk7u-dev [1] had to be altered on one count
> compared to the changes pushed in jdk8 [2]:
>
> Since jaxp needs to be compiled using the bootstrap
> compiler, it was not possible to use the new
> JDK 7 java.util.Objects API.
>
> In order to minimize the changes between the two
> changesets - I added an Objects class emulating
> the two 'hashCode' and 'equals' methods of java.util.Objects
> in the util packages of Xerces, Xalan, and Bcel.
>
> The altered changeset for JDK 7 was reviewed in this thread:
> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/017508.html> 
> and reviewed by Joe Wang (joehw) and Chris
> Hegarty (chegar).
>
> Here is the altered changeset for jdk7u-dev:
> [1] <http://cr.openjdk.java.net/~dfuchs/JDK-8013900/webrev-jdk7u-dev.00/>
>
> Here is the changeset that was pushed in jdk8:
> [2] <http://cr.openjdk.java.net/~dfuchs/JDK-8013900/webrev.01/>
>
> Best regards,
>
> -- daniel
>
> Review for the original jdk8 changeset [2] happened on core-libs-dev:
> <http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/017033.html> 
>




More information about the jdk7u-dev mailing list