[7u-dev] Request for approval for CR 7132378: Race in FutureTask if used with explicit set and get ( not Runnable )

[Seán Coffey]

Aleksey,

The code comments indicate that some behavioural change may be present 
with this fix :
> + * Revision notes: This differs from previous versions of this
> + * class that relied on AbstractQueuedSynchronizer, mainly to
> + * avoid surprising users about retaining interrupt status during
> + * cancellation races.

I'm cc'ing original reviewers (Chris and David) to see if they've got 
thoughts/concerns around porting this to 7u.
Was any further testing carried out other than FutureTask jtreg tests ?

regards,
Sean.

On 06/06/2013 11:43, Aleksey Shipilev wrote:
> Hi,
>
> Could you please approve the backport of CR 7132378 to 7u?
>
> External bug:
>    http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132378
>
> The fix was in JDK 8 for more than a year already:
>    http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9fb8c4b4550
>
> Testing:
>   - "hg import" applies cleanly to jdk7u
>   - Linux x86_64 build is OK
>   - Linux x86_64 passes test/java/util/concurrent/FutureTask jtreg
>
> -Aleksey.