RFR: [8049250]: (smartcardio) Need a flag to inverse the Card.disconnect(reset) argument

Valerie Peng valerie.peng at oracle.com
Fri Jul 11 18:10:00 UTC 2014


Looks fine.
Thanks,
Valerie
On 7/11/2014 6:23 AM, Ivan Gerasimov wrote:
> And another request for integrating the fix into 7u.
> This one is needed quite urgently, so if you could review the fix 
> until the end of the week, it would really be appreciated!
>
> The only difference from the 8u fix is the default value of "true".
>
> http://cr.openjdk.java.net/~igerasim/8049250/2/webrev/
>
> Sincerely yours,
> Ivan
>
> On 11.07.2014 15:09, Ivan Gerasimov wrote:
>> I updated the webrev - changed the option name to match one in ccc.
>> http://cr.openjdk.java.net/~igerasim/8049250/1/webrev/
>>
>> Would you please review/approve the fix, pending the ccc approval?
>>
>> Sincerely yours,
>> Ivan
>>
>>
>> On 06.07.2014 21:35, Ivan Gerasimov wrote:
>>> Hello!
>>>
>>> With the fix for JDK-7047033, the way Card.disconnect(boolean reset) 
>>> handles its argument was inverted.
>>> To provide compatibility, it is suggested to introduce an option, 
>>> which a user can use to revert to the old behavior.
>>>
>>> This fix is proposed for jdk8u only.
>>>
>>> In jdk8u the option will be false by default, so the reset argument 
>>> will not be inverted.
>>>
>>> CCC request has been filed.
>>>
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8049250
>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8049250/0/webrev/
>>>
>>> Sincerely yours,
>>> Ivan
>>>
>>>
>>
>>
>>
>


More information about the jdk8u-dev mailing list