From dalibor.topic at oracle.com Tue Nov 1 14:47:30 2016 From: dalibor.topic at oracle.com (dalibor topic) Date: Tue, 1 Nov 2016 15:47:30 +0100 Subject: the Minimum set when install jdk8u In-Reply-To: <20161031194317.GA25511@redhat.com> References: <20161031194317.GA25511@redhat.com> Message-ID: On 31.10.2016 20:43, Omair Majid wrote: > * Diaz Soho [2016-10-20 09:29]: >> when I finish build jdk8u, and try to install to a local directory, >> I find the folder /usr/local/jvm/ include a lots of files , the size >> is very large. >> >> is there any minimun set that I can select to install to my embedded platform? >> for example: >> if I would like to run "java -jar " on my embedded >> platform, then how to figure out the minimum set that should be >> installed ? > > I can't help with the produce-minimal-jre-for-my-app problem, You can use jdeps to determine the compact profile suitable for your app and its dependencies. See https://docs.oracle.com/javase/8/docs/technotes/tools/unix/jdeps.html for details. cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From naoto.sato at oracle.com Tue Nov 1 21:39:17 2016 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 1 Nov 2016 14:39:17 -0700 Subject: [8u-dev] Request for approval for backporting native code cleanup fixes in JDK9 Message-ID: <5fc68e4c-9657-e076-19cc-e7aafdd159a1@oracle.com> Hi, Please approve this bulk update for backporting the native code cleanup fixes in JDK9 into JDK8u-dev. Here is the list of JBS issues fixed in JDK9. 8025306: Inet[4|6]Address class and fieldID initialization in networking native code 8028725: [Parfait] warnings from b116 for jdk.src.solaris.native.java.net: JNI pending exceptions 8028769: Check src/share/native/java/lang/*.c for cases when JNI calls are used with pending warnings 8029018: (bf) Check src/share/native/java/nio/Bits.c for JNI pending exceptions 8030116: (process) Check Parfait warnings in src/solaris/native/java/lang/* 8031586: Check jdk/src/*/native/com/sun/security/auth/module for pending JNI exceptions 8031588: warnings from b03 for jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending 8033371: jdk/src/solaris/native/java/lang/ProcessEnvironment.c environ doesn't check for JNI pending exceptions 8033372: Check jdk/src/share/native/java/lang for JNI pending exception issues 8034102: Check solaris/native/sun/nio/fs/MacOSXNativeDispatcher.c for JNI pending exceptions 8037909: JNI warnings in jdk/src/windows/native/java/nio/MappedByteBuffer.c 8038075: JNI warnings in jdk/src/share/native/sun/misc/VMSupport.c 8046893: JNI exception pending in jdk/src/solaris/native/java/net: ExtendedOptionsImpl.c, PlainDatagramSocketImpl.c 8046901: Check jdk/src/solaris/native/sun/nio for Parfait flagged uninitialized memory 8055204: Memory leak in jdk/src/windows/native/java/lang/java_props_md.c 8064470: JNI exception pending in jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c 8073542: File Leak in jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c 8168405: Pending exceptions in java.base/windows/native Here is the webrev: http://cr.openjdk.java.net/~naoto/native_code_cleanup/webrev.00/ After unshuffling (if needed) the changesets in JDK9, fixes are applied to JDK8u-dev intact, or by resolving simple conflicts. Changes have been reviewed internally by Brian Burkhalter and Chris Hegarty. Naoto From rob.mckenna at oracle.com Wed Nov 2 01:21:04 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 2 Nov 2016 01:21:04 +0000 Subject: [8u-dev] Request for approval for backporting native code cleanup fixes in JDK9 In-Reply-To: <5fc68e4c-9657-e076-19cc-e7aafdd159a1@oracle.com> References: <5fc68e4c-9657-e076-19cc-e7aafdd159a1@oracle.com> Message-ID: <20161102012104.GC1922@vimes> Approved -Rob On 01/11/16 02:39, Naoto Sato wrote: > Hi, > > Please approve this bulk update for backporting the native code cleanup > fixes in JDK9 into JDK8u-dev. Here is the list of JBS issues fixed in JDK9. > > 8025306: Inet[4|6]Address class and fieldID initialization in networking > native code > 8028725: [Parfait] warnings from b116 for jdk.src.solaris.native.java.net: > JNI pending exceptions > 8028769: Check src/share/native/java/lang/*.c for cases when JNI calls are > used with pending warnings > 8029018: (bf) Check src/share/native/java/nio/Bits.c for JNI pending > exceptions > 8030116: (process) Check Parfait warnings in src/solaris/native/java/lang/* > 8031586: Check jdk/src/*/native/com/sun/security/auth/module for pending JNI > exceptions > 8031588: warnings from b03 for > jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending > 8033371: jdk/src/solaris/native/java/lang/ProcessEnvironment.c environ > doesn't check for JNI pending exceptions > 8033372: Check jdk/src/share/native/java/lang for JNI pending exception > issues > 8034102: Check solaris/native/sun/nio/fs/MacOSXNativeDispatcher.c for JNI > pending exceptions > 8037909: JNI warnings in jdk/src/windows/native/java/nio/MappedByteBuffer.c > 8038075: JNI warnings in jdk/src/share/native/sun/misc/VMSupport.c > 8046893: JNI exception pending in jdk/src/solaris/native/java/net: > ExtendedOptionsImpl.c, PlainDatagramSocketImpl.c > 8046901: Check jdk/src/solaris/native/sun/nio for Parfait flagged > uninitialized memory > 8055204: Memory leak in jdk/src/windows/native/java/lang/java_props_md.c > 8064470: JNI exception pending in > jdk/src/java/base/unix/native/libjava/FileDescriptor_md.c > 8073542: File Leak in > jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c > 8080486: JNI exception pending in > jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c > 8168405: Pending exceptions in java.base/windows/native > > Here is the webrev: > > http://cr.openjdk.java.net/~naoto/native_code_cleanup/webrev.00/ > > After unshuffling (if needed) the changesets in JDK9, fixes are applied to > JDK8u-dev intact, or by resolving simple conflicts. Changes have been > reviewed internally by Brian Burkhalter and Chris Hegarty. > > Naoto > From sean.coffey at oracle.com Thu Nov 3 13:42:08 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 3 Nov 2016 13:42:08 +0000 Subject: [8u communication] New changes for JDK 8 Update enhancement requests In-Reply-To: <4efc8b83-56a8-67e9-69d8-b4a1854d16e1@oracle.com> References: <4efc8b83-56a8-67e9-69d8-b4a1854d16e1@oracle.com> Message-ID: Hearing no objections to this proposal, I'll proceed to make the suggested edits to the OpenJDK 8 Updates Project page. For new enhancement requests in JDK 8 Updates, please use the new Enhancement request template from now on. regards, Sean. On 23/08/2016 11:57, Se?n Coffey wrote: > > As the JDK 9 GA date continues to grow closer[1], more efforts will go > into stabilizing the JDK 9 release. The latest feature release line serves > as a delivery mechanism for new enhancements that enter the JDK. > > With that in mind, I'd like to propose a change to how enhancements > are ported to JDK 8 Updates. > > Enhancements normally bring more code change and testing requirements > with them. With most efforts being focused on JDK 9, I'd like to > suggest that we recapitulate any enhancements being proposed for the > JDK 8 Updates Project. The proposed change just involves giving the > Project maintainers early notification of any proposed enhancement > work being planned for the Project. The maintainers can assess each > request and help make a decision on its suitability. > > In particular here are the proposed changes for the JDK 8 Updates > processes: > > ==== > In Ground Rules: [2] > > In Rule 3: > > Changes submitted for a JDK 8 Update forest MUST go through code > review, and MUST be approved by the maintainer for that forest. > The maintainer of a forest MAY delegate that authority, allowing for > approvals to happen in a more finely granular fashion - per > repository, for example. > > Add: > > If the change is an enhancement, then a separate enhancement backport > request MUST be approved by the maintainer for that forest prior to > the change being submitted for code review and final maintainer > approval. > > with "Enhancement backport request" linking to a new > > Enhancement Backport Approval Template: > > Use this template for requesting a backport of an enhancement to any > 8u release. Note that "critical fix approval" also needs to be > requested for any fixes targeted to an RDP2 release. Enhancement > backport approval requests for JDK 8 update releases MUST be sent to > the jdk8u-dev at openjdk.java.net mailing list prior to requesting code > review, and SHOULD follow this template: > > Subject: [8u$N] Request for enhancement backport approval for CR $NR > - $Synopsis > > With the body containing: > > * either a link to the publicly visible enhancement issue on the > bugs.java.com > site (or its equivalent), or a description of the change in case > that there is no publicly > visible enhancement issue to link to > > * a rationale for why the enhancement should be backported, > including the benefit and risks involved, what testing has been > done, and what the results were. > > ==== > > Please submit comments on this proposal before 31st August 2016. > > regards, > Sean. > > [1] http://openjdk.java.net/projects/jdk9/ > [2] http://openjdk.java.net/projects/jdk8u/groundrules.html > From sean.coffey at oracle.com Fri Nov 4 09:25:29 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 4 Nov 2016 09:25:29 +0000 Subject: [8u-dev] Request for enhancement backport approval for CR JDK-8157561 : Ship the unlimited policy files in JDK Updates Message-ID: Hi, I'd like approval to implement the following enhancement in jdk8u-dev : https://bugs.openjdk.java.net/browse/JDK-8157561 : Ship the unlimited policy files in JDK Updates This feature will allow end users to control the location of the default JCE policy jurisdiction files. It uses the same new Security Property flag as that introduced into JDK 9 via JDK-8061842. The code differs though in that jar files continue to be used and backwards compatibility is maintained. The feature will greatly simplify how unlimited crypto gets enabled in the JDK. regards, Sean. From Alan.Bateman at oracle.com Fri Nov 4 09:29:11 2016 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 4 Nov 2016 09:29:11 +0000 Subject: [8u communication] New changes for JDK 8 Update enhancement requests In-Reply-To: References: <4efc8b83-56a8-67e9-69d8-b4a1854d16e1@oracle.com> Message-ID: <90c51019-2a89-965a-0fc2-a66a997dfbbb@oracle.com> On 03/11/2016 13:42, Se?n Coffey wrote: > Hearing no objections to this proposal, I'll proceed to make the > suggested edits to the OpenJDK 8 Updates Project page. > > For new enhancement requests in JDK 8 Updates, please use the new > Enhancement request template from now on. Sean - one things with the proposed wording is that it's not clear what "Enhancement" means. Is this strictly the issue type in JIRA? Performance fixes are good examples where they are sometimes bugs, sometimes enhancements. It's clear the process change is to catch feature changes early but not clear whether it's applicable to backport requests where the issue type is a coin toss. -Alan. From sean.coffey at oracle.com Fri Nov 4 09:46:01 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 4 Nov 2016 09:46:01 +0000 Subject: [8u communication] New changes for JDK 8 Update enhancement requests In-Reply-To: <90c51019-2a89-965a-0fc2-a66a997dfbbb@oracle.com> References: <4efc8b83-56a8-67e9-69d8-b4a1854d16e1@oracle.com> <90c51019-2a89-965a-0fc2-a66a997dfbbb@oracle.com> Message-ID: <0525007c-f181-3dc0-4c50-196e4230dbf7@oracle.com> On 04/11/2016 09:29, Alan Bateman wrote: > On 03/11/2016 13:42, Se?n Coffey wrote: > >> Hearing no objections to this proposal, I'll proceed to make the >> suggested edits to the OpenJDK 8 Updates Project page. >> >> For new enhancement requests in JDK 8 Updates, please use the new >> Enhancement request template from now on. > Sean - one things with the proposed wording is that it's not clear > what "Enhancement" means. Is this strictly the issue type in JIRA? > Performance fixes are good examples where they are sometimes bugs, > sometimes enhancements. It's clear the process change is to catch > feature changes early but not clear whether it's applicable to > backport requests where the issue type is a coin toss. Good point Alan. I guess best judgement is required here. A new performance fix should be considered an Enhancement and marked as such in JBS. On the other hand, a performance fix necessary to correct a regression should be marked as a Bug in JBS. We can clarify further if this proves to be an issue for the process. I don't expect many such enhancement requests to be logged. Most fixes coming into JDK 8 Updates now are mainly bug fixes. regards, Sean. > > -Alan. From dmitry.markov at oracle.com Fri Nov 4 10:45:07 2016 From: dmitry.markov at oracle.com (dmitry markov) Date: Fri, 04 Nov 2016 13:45:07 +0300 Subject: [8u-dev] Request for approval 8139189 & 8160623 Message-ID: <581C66B3.6080800@oracle.com> Hello, Can I get an approval to backport the following fixes: 8139189 and 8160623 to 8u-dev, please? Both patches apply cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8139189 (VK_OEM_102 dead key detected as VK_UNDEFINED) Review: http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011292.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/762a3d7c8514 Bug: https://bugs.openjdk.java.net/browse/JDK-8160623 ([PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java) Review: http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011563.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/9f09f716e512 Cumulative jdk8u webrev: http://cr.openjdk.java.net/~dmarkov/8139189_and_8160623/jdk8u/webrev.00/ Thanks, Dmitry From david.buck at oracle.com Fri Nov 4 11:20:04 2016 From: david.buck at oracle.com (david buck) Date: Fri, 4 Nov 2016 20:20:04 +0900 Subject: [8u-dev] Request for approval 8139189 & 8160623 In-Reply-To: <581C66B3.6080800@oracle.com> References: <581C66B3.6080800@oracle.com> Message-ID: approved for push to 8u-dev Cheers, -Buck On 2016/11/04 19:45, dmitry markov wrote: > Hello, > > Can I get an approval to backport the following fixes: 8139189 and > 8160623 to 8u-dev, please? Both patches apply cleanly. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8139189 > (VK_OEM_102 dead key detected as VK_UNDEFINED) > Review: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-May/011292.html > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/762a3d7c8514 > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8160623 > ([PIT] Exception running java/awt/event/KeyEvent/KeyChar/KeyCharTest.java) > Review: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011563.html > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/9f09f716e512 > > Cumulative jdk8u webrev: > http://cr.openjdk.java.net/~dmarkov/8139189_and_8160623/jdk8u/webrev.00/ > > Thanks, > Dmitry From dalibor.topic at oracle.com Fri Nov 4 12:26:17 2016 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 4 Nov 2016 13:26:17 +0100 Subject: [8u-dev] Request for enhancement backport approval for CR JDK-8157561 : Ship the unlimited policy files in JDK Updates In-Reply-To: References: Message-ID: <38ba928a-bf1e-450a-a173-f856b193a73c@oracle.com> Thanks, Sean. This enhancement request is approved. Please proceed with the backport and send a push approval request to this mailing list when the backport ready for review and/or approval. cheers, dalibor topic On 04.11.2016 10:25, Se?n Coffey wrote: > Hi, > > I'd like approval to implement the following enhancement in jdk8u-dev : > > https://bugs.openjdk.java.net/browse/JDK-8157561 : Ship the unlimited > policy files in JDK Updates > > This feature will allow end users to control the location of the default > JCE policy jurisdiction files. It uses the same new Security Property > flag as that introduced into JDK 9 via JDK-8061842. The code differs > though in that jar files continue to be used and backwards compatibility > is maintained. The feature will greatly simplify how unlimited crypto > gets enabled in the JDK. > > regards, > Sean. > -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Fri Nov 4 15:09:15 2016 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 4 Nov 2016 16:09:15 +0100 Subject: CFV: New jdk8u Committer: Christoph Langer In-Reply-To: References: Message-ID: <49eb2587-7cda-cedc-263a-6ae83a5a5334@oracle.com> Vote: Yes. cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From tiago.daitx at canonical.com Sun Nov 6 18:44:13 2016 From: tiago.daitx at canonical.com (Tiago Daitx) Date: Sun, 6 Nov 2016 16:44:13 -0200 Subject: Missing shebang on sample script Message-ID: The file openjdk/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh is missing a shebang. This happens on both OpenJDK 7 and 8. --- openjdk7/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh.orig +++ openjdk7/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh @@ -1,3 +1,4 @@ +#!/bin/sh # # Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved. # --- openjdk8/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh.orig +++ openjdk8/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh @@ -1,3 +1,4 @@ +#!/bin/sh # # Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. # Note: I'm a participant, not a contributor. Regards, -- Tiago St?rmer Daitx Software Engineer tiago.daitx at canonical.com PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE From tiago.daitx at canonical.com Sun Nov 6 20:27:33 2016 From: tiago.daitx at canonical.com (Tiago Daitx) Date: Sun, 6 Nov 2016 18:27:33 -0200 Subject: RFR(8u): JDK-8136570: Avoid setting environment variables related to /usr/dt Message-ID: Hi, Please review the backported changes for JDK-8136570 to 8u in the inline patch bellow. JDK-8136570 : Stop changing user environment variables related to /usr/dt JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/acf424f856ce JDK 9 Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-September/035271.html Original patch applies cleanly with a small offset on hunk #2, thus I modified it to match 8u line numbers. Note: I'm a Participant, not a Contributor but I assume the backport is trival enough to not require a signed OCA. Patch bellow: # HG changeset patch # User martin # Date 1442425751 25200 # Node ID acf424f856ce5abf98ee59b9d28249eeba840428 # Parent bb6e5a409fefefce5b748ceacfa581698c710567 8136570: Stop changing user environment variables related to /usr/dt 4953367: MAWT: Java should be more careful manipulating NLSPATH, XFILESEARCHPATH env variables Summary: Stop changing user environment variables: NLSPATH XFILESEARCHPATH Reviewed-by: prr diff -r bb6e5a409fef -r acf424f856ce src/solaris/native/java/lang/java_props_md.c --- a/src/solaris/native/java/lang/java_props_md.c Thu Sep 17 17:33:00 2015 +0200 +++ b/src/solaris/native/java/lang/java_props_md.c Wed Sep 16 10:49:11 2015 -0700 @@ -91,46 +91,6 @@ return 0; } -/* This function sets an environment variable using envstring. - * The format of envstring is "name=value". - * If the name has already existed, it will append value to the name. - */ -static void -setPathEnvironment(char *envstring) -{ - char name[20], *value, *current; - - value = strchr(envstring, '='); /* locate name and value separator */ - - if (! value) - return; /* not a valid environment setting */ - - /* copy first part as environment name */ - strncpy(name, envstring, value - envstring); - name[value-envstring] = '\0'; - - value++; /* set value point to value of the envstring */ - - current = getenv(name); - if (current) { - if (! strstr(current, value)) { - /* value is not found in current environment, append it */ - char *temp = malloc(strlen(envstring) + strlen(current) + 2); - strcpy(temp, name); - strcat(temp, "="); - strcat(temp, current); - strcat(temp, ":"); - strcat(temp, value); - putenv(temp); - } - /* else the value has already been set, do nothing */ - } - else { - /* environment variable is not found */ - putenv(envstring); - } -} - #ifndef P_tmpdir #define P_tmpdir "/var/tmp" #endif @@ -612,16 +572,6 @@ sprops.path_separator = ":"; sprops.line_separator = "\n"; -#if !defined(_ALLBSD_SOURCE) - /* Append CDE message and resource search path to NLSPATH and - * XFILESEARCHPATH, in order to pick localized message for - * FileSelectionDialog window (Bug 4173641). - */ - setPathEnvironment("NLSPATH=/usr/dt/lib/nls/msg/%L/%N.cat"); - setPathEnvironment("XFILESEARCHPATH=/usr/dt/app-defaults/%L/Dt"); -#endif - - #ifdef MACOSX setProxyProperties(&sprops); #endif Regards, -- Tiago St?rmer Daitx Software Engineer tiago.daitx at canonical.com PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE From martinrb at google.com Mon Nov 7 00:46:42 2016 From: martinrb at google.com (Martin Buchholz) Date: Sun, 6 Nov 2016 16:46:42 -0800 Subject: RFR(8u): JDK-8136570: Avoid setting environment variables related to /usr/dt In-Reply-To: References: Message-ID: I support this backport. It fixes a crash! On Sun, Nov 6, 2016 at 12:27 PM, Tiago Daitx wrote: > Hi, > > Please review the backported changes for JDK-8136570 to 8u in the > inline patch bellow. > > JDK-8136570 : Stop > changing user environment variables related to /usr/dt > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/acf424f856ce > JDK 9 Review Thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015- > September/035271.html > > Original patch applies cleanly with a small offset on hunk #2, thus I > modified it to match 8u line numbers. > > Note: I'm a Participant, not a Contributor but I assume the backport > is trival enough to not require a signed OCA. > > > Patch bellow: > > # HG changeset patch > # User martin > # Date 1442425751 25200 > # Node ID acf424f856ce5abf98ee59b9d28249eeba840428 > # Parent bb6e5a409fefefce5b748ceacfa581698c710567 > 8136570: Stop changing user environment variables related to /usr/dt > 4953367: MAWT: Java should be more careful manipulating NLSPATH, > XFILESEARCHPATH env variables > Summary: Stop changing user environment variables: NLSPATH XFILESEARCHPATH > Reviewed-by: prr > > diff -r bb6e5a409fef -r acf424f856ce > src/solaris/native/java/lang/java_props_md.c > --- a/src/solaris/native/java/lang/java_props_md.c Thu Sep 17 17:33:00 > 2015 +0200 > +++ b/src/solaris/native/java/lang/java_props_md.c Wed Sep 16 10:49:11 > 2015 -0700 > @@ -91,46 +91,6 @@ > return 0; > } > > -/* This function sets an environment variable using envstring. > - * The format of envstring is "name=value". > - * If the name has already existed, it will append value to the name. > - */ > -static void > -setPathEnvironment(char *envstring) > -{ > - char name[20], *value, *current; > - > - value = strchr(envstring, '='); /* locate name and value separator */ > - > - if (! value) > - return; /* not a valid environment setting */ > - > - /* copy first part as environment name */ > - strncpy(name, envstring, value - envstring); > - name[value-envstring] = '\0'; > - > - value++; /* set value point to value of the envstring */ > - > - current = getenv(name); > - if (current) { > - if (! strstr(current, value)) { > - /* value is not found in current environment, append it */ > - char *temp = malloc(strlen(envstring) + strlen(current) + 2); > - strcpy(temp, name); > - strcat(temp, "="); > - strcat(temp, current); > - strcat(temp, ":"); > - strcat(temp, value); > - putenv(temp); > - } > - /* else the value has already been set, do nothing */ > - } > - else { > - /* environment variable is not found */ > - putenv(envstring); > - } > -} > - > #ifndef P_tmpdir > #define P_tmpdir "/var/tmp" > #endif > @@ -612,16 +572,6 @@ > sprops.path_separator = ":"; > sprops.line_separator = "\n"; > > -#if !defined(_ALLBSD_SOURCE) > - /* Append CDE message and resource search path to NLSPATH and > - * XFILESEARCHPATH, in order to pick localized message for > - * FileSelectionDialog window (Bug 4173641). > - */ > - setPathEnvironment("NLSPATH=/usr/dt/lib/nls/msg/%L/%N.cat"); > - setPathEnvironment("XFILESEARCHPATH=/usr/dt/app-defaults/%L/Dt"); > -#endif > - > - > #ifdef MACOSX > setProxyProperties(&sprops); > #endif > > > > Regards, > > -- > Tiago St?rmer Daitx > Software Engineer > tiago.daitx at canonical.com > > PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) > Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE > From rob.mckenna at oracle.com Tue Nov 8 19:22:10 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 8 Nov 2016 19:22:10 +0000 Subject: RFR(8u): JDK-8136570: Avoid setting environment variables related to /usr/dt In-Reply-To: References: Message-ID: <20161108192210.GD4445@vimes> Meant to respond to this and your other mail earlier. I'll file a backport and take care of it. Thanks! -Rob On 06/11/16 04:46, Martin Buchholz wrote: > I support this backport. It fixes a crash! > > On Sun, Nov 6, 2016 at 12:27 PM, Tiago Daitx > wrote: > > > Hi, > > > > Please review the backported changes for JDK-8136570 to 8u in the > > inline patch bellow. > > > > JDK-8136570 : Stop > > changing user environment variables related to /usr/dt > > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/acf424f856ce > > JDK 9 Review Thread: > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015- > > September/035271.html > > > > Original patch applies cleanly with a small offset on hunk #2, thus I > > modified it to match 8u line numbers. > > > > Note: I'm a Participant, not a Contributor but I assume the backport > > is trival enough to not require a signed OCA. > > > > > > Patch bellow: > > > > # HG changeset patch > > # User martin > > # Date 1442425751 25200 > > # Node ID acf424f856ce5abf98ee59b9d28249eeba840428 > > # Parent bb6e5a409fefefce5b748ceacfa581698c710567 > > 8136570: Stop changing user environment variables related to /usr/dt > > 4953367: MAWT: Java should be more careful manipulating NLSPATH, > > XFILESEARCHPATH env variables > > Summary: Stop changing user environment variables: NLSPATH XFILESEARCHPATH > > Reviewed-by: prr > > > > diff -r bb6e5a409fef -r acf424f856ce > > src/solaris/native/java/lang/java_props_md.c > > --- a/src/solaris/native/java/lang/java_props_md.c Thu Sep 17 17:33:00 > > 2015 +0200 > > +++ b/src/solaris/native/java/lang/java_props_md.c Wed Sep 16 10:49:11 > > 2015 -0700 > > @@ -91,46 +91,6 @@ > > return 0; > > } > > > > -/* This function sets an environment variable using envstring. > > - * The format of envstring is "name=value". > > - * If the name has already existed, it will append value to the name. > > - */ > > -static void > > -setPathEnvironment(char *envstring) > > -{ > > - char name[20], *value, *current; > > - > > - value = strchr(envstring, '='); /* locate name and value separator */ > > - > > - if (! value) > > - return; /* not a valid environment setting */ > > - > > - /* copy first part as environment name */ > > - strncpy(name, envstring, value - envstring); > > - name[value-envstring] = '\0'; > > - > > - value++; /* set value point to value of the envstring */ > > - > > - current = getenv(name); > > - if (current) { > > - if (! strstr(current, value)) { > > - /* value is not found in current environment, append it */ > > - char *temp = malloc(strlen(envstring) + strlen(current) + 2); > > - strcpy(temp, name); > > - strcat(temp, "="); > > - strcat(temp, current); > > - strcat(temp, ":"); > > - strcat(temp, value); > > - putenv(temp); > > - } > > - /* else the value has already been set, do nothing */ > > - } > > - else { > > - /* environment variable is not found */ > > - putenv(envstring); > > - } > > -} > > - > > #ifndef P_tmpdir > > #define P_tmpdir "/var/tmp" > > #endif > > @@ -612,16 +572,6 @@ > > sprops.path_separator = ":"; > > sprops.line_separator = "\n"; > > > > -#if !defined(_ALLBSD_SOURCE) > > - /* Append CDE message and resource search path to NLSPATH and > > - * XFILESEARCHPATH, in order to pick localized message for > > - * FileSelectionDialog window (Bug 4173641). > > - */ > > - setPathEnvironment("NLSPATH=/usr/dt/lib/nls/msg/%L/%N.cat"); > > - setPathEnvironment("XFILESEARCHPATH=/usr/dt/app-defaults/%L/Dt"); > > -#endif > > - > > - > > #ifdef MACOSX > > setProxyProperties(&sprops); > > #endif > > > > > > > > Regards, > > > > -- > > Tiago St?rmer Daitx > > Software Engineer > > tiago.daitx at canonical.com > > > > PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) > > Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE > > From rob.mckenna at oracle.com Tue Nov 8 19:28:22 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 8 Nov 2016 19:28:22 +0000 Subject: Missing shebang on sample script In-Reply-To: References: Message-ID: <20161108192822.GE4445@vimes> Thanks Tiago, I've filed https://bugs.openjdk.java.net/browse/JDK-8169424. -Rob On 06/11/16 04:44, Tiago Daitx wrote: > The file openjdk/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh > is missing a shebang. > > This happens on both OpenJDK 7 and 8. > > --- openjdk7/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh.orig > +++ openjdk7/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh > @@ -1,3 +1,4 @@ > +#!/bin/sh > # > # Copyright (c) 2006, Oracle and/or its affiliates. All rights reserved. > # > > --- openjdk8/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh.orig > +++ openjdk8/jdk/src/share/sample/scripting/scriptpad/src/scripts/memory.sh > @@ -1,3 +1,4 @@ > +#!/bin/sh > # > # Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved. > # > > > Note: I'm a participant, not a contributor. > > Regards, > > -- > Tiago St?rmer Daitx > Software Engineer > tiago.daitx at canonical.com > > PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) > Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE From mikhail.cherkasov at oracle.com Wed Nov 9 07:34:12 2016 From: mikhail.cherkasov at oracle.com (Mikhail Cherkasov) Date: Wed, 9 Nov 2016 10:34:12 +0300 Subject: [8u] Request for approval to backport of 8156723: JVM crash at sun.java2d.windows.GDIBlitLoops.nativeBlit Message-ID: <3f23553f-0c26-5f26-e858-f844f7d51667@oracle.com> Hi, Could you please approve the following fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8156723 Review: http://mail.openjdk.java.net/pipermail/2d-dev/2016-November/007881.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12948b3a7663 Thanks, Mikhail. From david.buck at oracle.com Wed Nov 9 07:45:02 2016 From: david.buck at oracle.com (david buck) Date: Wed, 9 Nov 2016 16:45:02 +0900 Subject: [8u] Request for approval to backport of 8156723: JVM crash at sun.java2d.windows.GDIBlitLoops.nativeBlit In-Reply-To: <3f23553f-0c26-5f26-e858-f844f7d51667@oracle.com> References: <3f23553f-0c26-5f26-e858-f844f7d51667@oracle.com> Message-ID: <6755776f-6c21-8566-07e8-a1a9c4bd7247@oracle.com> approved for push to 8u-dev Cheers, -Buck On 2016/11/09 16:34, Mikhail Cherkasov wrote: > Hi, > > Could you please approve the following fix: > JBS: https://bugs.openjdk.java.net/browse/JDK-8156723 > Review: > http://mail.openjdk.java.net/pipermail/2d-dev/2016-November/007881.html > JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12948b3a7663 > > Thanks, > Mikhail. From sean.coffey at oracle.com Wed Nov 9 11:29:14 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Nov 2016 11:29:14 +0000 Subject: [8u-dev] Request for approval : 8169229: RSAClientKeyExchange debug info is incorrect Message-ID: <5823088A.4070403@oracle.com> Looking to backport this fix to jdk8u-dev : https://bugs.openjdk.java.net/browse/JDK-8169229 jdk 9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4407b0525631 Fix applies cleanly post modular path shuffling. -- Regards, Sean. From sean.coffey at oracle.com Wed Nov 9 11:31:37 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Nov 2016 11:31:37 +0000 Subject: [8u-dev] Request for approval : 8169229: RSAClientKeyExchange debug info is incorrect In-Reply-To: <5823088A.4070403@oracle.com> References: <5823088A.4070403@oracle.com> Message-ID: <58230919.9000501@oracle.com> JDK 9 review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015121.html Regards, Sean. On 09/11/16 11:29, Se?n Coffey wrote: > Looking to backport this fix to jdk8u-dev : > > https://bugs.openjdk.java.net/browse/JDK-8169229 > jdk 9 changeset : > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4407b0525631 > > Fix applies cleanly post modular path shuffling. > From david.buck at oracle.com Wed Nov 9 11:32:42 2016 From: david.buck at oracle.com (david buck) Date: Wed, 9 Nov 2016 20:32:42 +0900 Subject: [8u-dev] Request for approval : 8169229: RSAClientKeyExchange debug info is incorrect In-Reply-To: <58230919.9000501@oracle.com> References: <5823088A.4070403@oracle.com> <58230919.9000501@oracle.com> Message-ID: <04893583-cf2a-c183-b5c1-8dc56c070d9e@oracle.com> approved for push to 8u-dev Cheers, -Buck On 2016/11/09 20:31, Se?n Coffey wrote: > JDK 9 review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015121.html > > > Regards, > Sean. > > On 09/11/16 11:29, Se?n Coffey wrote: >> Looking to backport this fix to jdk8u-dev : >> >> https://bugs.openjdk.java.net/browse/JDK-8169229 >> jdk 9 changeset : >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4407b0525631 >> >> Fix applies cleanly post modular path shuffling. >> > From dmitry.markov at oracle.com Wed Nov 9 13:10:57 2016 From: dmitry.markov at oracle.com (dmitry markov) Date: Wed, 09 Nov 2016 16:10:57 +0300 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used Message-ID: <58232061.5040409@oracle.com> Hello, Can I get an approval to port the fix for 8169355 to jdk8u-dev, please? The jdk9 patch applies cleanly. JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 Thanks, Dmitry From sean.coffey at oracle.com Wed Nov 9 14:25:13 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Nov 2016 14:25:13 +0000 Subject: [jdk8u-dev] Request for approval : 8166432:Bad 8u112 merge of sun/security/tools/jarsigner/warnings/Test.java Message-ID: <582331C9.7090301@oracle.com> I'd like to push this test correction to jdk8u-dev review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015124.html -- Regards, Sean. From david.buck at oracle.com Wed Nov 9 14:37:30 2016 From: david.buck at oracle.com (david buck) Date: Wed, 9 Nov 2016 23:37:30 +0900 Subject: [jdk8u-dev] Request for approval : 8166432:Bad 8u112 merge of sun/security/tools/jarsigner/warnings/Test.java In-Reply-To: <582331C9.7090301@oracle.com> References: <582331C9.7090301@oracle.com> Message-ID: <844c8125-de9a-cbc2-3a47-f707322df5a9@oracle.com> approved for push to 8u-dev Cheers, -Buck On 2016/11/09 23:25, Se?n Coffey wrote: > I'd like to push this test correction to jdk8u-dev > > review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015124.html > > From david.buck at oracle.com Wed Nov 9 14:42:27 2016 From: david.buck at oracle.com (david buck) Date: Wed, 9 Nov 2016 23:42:27 +0900 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <58232061.5040409@oracle.com> References: <58232061.5040409@oracle.com> Message-ID: <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> approved for push to 8-dev Cheers, -Buck On 2016/11/09 22:10, dmitry markov wrote: > Hello, > > Can I get an approval to port the fix for 8169355 to jdk8u-dev, please? > The jdk9 patch applies cleanly. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 > Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ > Review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 > > Thanks, > Dmitry From philip.race at oracle.com Wed Nov 9 16:06:49 2016 From: philip.race at oracle.com (Philip Race) Date: Wed, 09 Nov 2016 08:06:49 -0800 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> References: <58232061.5040409@oracle.com> <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> Message-ID: <58234999.8080100@oracle.com> Hmm. First, it was pushed to JDK 9 with only one reviewer (contrary to client group rules, without getting an exception). Second, it was pushed just hours ago. No bake time. It hasn't even been PIT tested. In fact it hasn't even been through a nightly build yet. I think this should *NOT* yet be approved for backport. -phil. On 11/9/16, 6:42 AM, david buck wrote: > approved for push to 8-dev > > Cheers, > -Buck > > On 2016/11/09 22:10, dmitry markov wrote: >> Hello, >> >> Can I get an approval to port the fix for 8169355 to jdk8u-dev, please? >> The jdk9 patch applies cleanly. >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 >> Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html >> jdk9 changeset: >> http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 >> >> Thanks, >> Dmitry From sean.coffey at oracle.com Wed Nov 9 16:52:20 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Nov 2016 16:52:20 +0000 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <58234999.8080100@oracle.com> References: <58232061.5040409@oracle.com> <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> <58234999.8080100@oracle.com> Message-ID: <58235444.4070205@oracle.com> Phil, Thanks for raising your concern on this issue. If you feel that this fix could be problematic, then yes - we should allow more bake time in JDK 9 first. Dmitry - please work with Phil to establish a suitable timeline around when to push this fix into jdk8u-dev forest. Regards, Sean. On 09/11/16 16:06, Philip Race wrote: > Hmm. > First, it was pushed to JDK 9 with only one reviewer (contrary to > client group rules, without getting an exception). > Second, it was pushed just hours ago. No bake time. It hasn't even > been PIT tested. > In fact it hasn't even been through a nightly build yet. > I think this should *NOT* yet be approved for backport. > > -phil. > > On 11/9/16, 6:42 AM, david buck wrote: >> approved for push to 8-dev >> >> Cheers, >> -Buck >> >> On 2016/11/09 22:10, dmitry markov wrote: >>> Hello, >>> >>> Can I get an approval to port the fix for 8169355 to jdk8u-dev, please? >>> The jdk9 patch applies cleanly. >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 >>> Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ >>> Review thread: >>> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html >>> >>> jdk9 changeset: >>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 >>> >>> Thanks, >>> Dmitry From sean.coffey at oracle.com Wed Nov 9 17:05:20 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 9 Nov 2016 17:05:20 +0000 Subject: [jdk8u-dev] Request for approval : 8157561 : Ship the unlimited policy files in JDK Updates Message-ID: <58235750.9000008@oracle.com> Looking for approval to push this enhancement to jdk8u-dev. The enhancement request was already approved [1]. JBS Record : https://bugs.openjdk.java.net/browse/JDK-8168913 Review thread : http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015096.html [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-November/006096.html -- Regards, Sean. From philip.race at oracle.com Wed Nov 9 17:06:43 2016 From: philip.race at oracle.com (Philip Race) Date: Wed, 09 Nov 2016 09:06:43 -0800 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <58235444.4070205@oracle.com> References: <58232061.5040409@oracle.com> <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> <58234999.8080100@oracle.com> <58235444.4070205@oracle.com> Message-ID: <582357A3.1070608@oracle.com> I'd like to see it at least get past our next JDK9 PIT cycle since it seems only a limited amount of testing was done. -phil. On 11/9/16, 8:52 AM, Se?n Coffey wrote: > Phil, > > Thanks for raising your concern on this issue. If you feel that this > fix could be problematic, then yes - we should allow more bake time in > JDK 9 first. > > Dmitry - please work with Phil to establish a suitable timeline around > when to push this fix into jdk8u-dev forest. > > Regards, > Sean. > > On 09/11/16 16:06, Philip Race wrote: >> Hmm. >> First, it was pushed to JDK 9 with only one reviewer (contrary to >> client group rules, without getting an exception). >> Second, it was pushed just hours ago. No bake time. It hasn't even >> been PIT tested. >> In fact it hasn't even been through a nightly build yet. >> I think this should *NOT* yet be approved for backport. >> >> -phil. >> >> On 11/9/16, 6:42 AM, david buck wrote: >>> approved for push to 8-dev >>> >>> Cheers, >>> -Buck >>> >>> On 2016/11/09 22:10, dmitry markov wrote: >>>> Hello, >>>> >>>> Can I get an approval to port the fix for 8169355 to jdk8u-dev, >>>> please? >>>> The jdk9 patch applies cleanly. >>>> >>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 >>>> Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ >>>> Review thread: >>>> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html >>>> >>>> jdk9 changeset: >>>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 >>>> >>>> Thanks, >>>> Dmitry > From rob.mckenna at oracle.com Wed Nov 9 18:25:07 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 9 Nov 2016 18:25:07 +0000 Subject: [jdk8u-dev] Request for approval : 8157561 : Ship the unlimited policy files in JDK Updates In-Reply-To: <58235750.9000008@oracle.com> References: <58235750.9000008@oracle.com> Message-ID: <20161109182507.GB2915@vimes> Approved -Rob On 09/11/16 05:05, Se?n Coffey wrote: > Looking for approval to push this enhancement to jdk8u-dev. > > The enhancement request was already approved [1]. > > JBS Record : https://bugs.openjdk.java.net/browse/JDK-8168913 > Review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2016-November/015096.html > > [1] > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-November/006096.html > > -- > Regards, > Sean. > From dmitry.markov at oracle.com Thu Nov 10 11:47:15 2016 From: dmitry.markov at oracle.com (dmitry markov) Date: Thu, 10 Nov 2016 14:47:15 +0300 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <582357A3.1070608@oracle.com> References: <58232061.5040409@oracle.com> <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> <58234999.8080100@oracle.com> <58235444.4070205@oracle.com> <582357A3.1070608@oracle.com> Message-ID: <58245E43.9090605@oracle.com> Hello Phil, If JDK9 PIT cycle does not indicate any problems related to the fix, then it may be backported to jdk8u-dev. Is my understanding correct? Thanks, Dmitry On 09/11/2016 20:06, Philip Race wrote: > I'd like to see it at least get past our next JDK9 PIT cycle since it > seems only a limited amount of testing was done. > > -phil. > > On 11/9/16, 8:52 AM, Se?n Coffey wrote: >> Phil, >> >> Thanks for raising your concern on this issue. If you feel that this >> fix could be problematic, then yes - we should allow more bake time >> in JDK 9 first. >> >> Dmitry - please work with Phil to establish a suitable timeline >> around when to push this fix into jdk8u-dev forest. >> >> Regards, >> Sean. >> >> On 09/11/16 16:06, Philip Race wrote: >>> Hmm. >>> First, it was pushed to JDK 9 with only one reviewer (contrary to >>> client group rules, without getting an exception). >>> Second, it was pushed just hours ago. No bake time. It hasn't even >>> been PIT tested. >>> In fact it hasn't even been through a nightly build yet. >>> I think this should *NOT* yet be approved for backport. >>> >>> -phil. >>> >>> On 11/9/16, 6:42 AM, david buck wrote: >>>> approved for push to 8-dev >>>> >>>> Cheers, >>>> -Buck >>>> >>>> On 2016/11/09 22:10, dmitry markov wrote: >>>>> Hello, >>>>> >>>>> Can I get an approval to port the fix for 8169355 to jdk8u-dev, >>>>> please? >>>>> The jdk9 patch applies cleanly. >>>>> >>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 >>>>> Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ >>>>> Review thread: >>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html >>>>> >>>>> jdk9 changeset: >>>>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 >>>>> >>>>> Thanks, >>>>> Dmitry >> From Sergey.Bylokhov at oracle.com Thu Nov 10 16:56:36 2016 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 10 Nov 2016 19:56:36 +0300 Subject: [8u-dev] Request for approval: 8165717 [macosx] Various memory leaks in jdk9 Message-ID: <98968032-1a28-4d79-8596-6244c0fca827@oracle.com> Hello, These is a direct back port from jdk 9 to jdk 8u-dev. 8165717: [macosx] Various memory leaks in jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-8165717 Webrev can be found at: http://cr.openjdk.java.net/~serb/8165717/webrev.00/ jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/374509e16f8a Review: http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/011923.html Reviewers: Anton Tarasov, Semyon Sadetsky -- Best regards, Sergey. From philip.race at oracle.com Thu Nov 10 17:59:30 2016 From: philip.race at oracle.com (Phil Race) Date: Thu, 10 Nov 2016 09:59:30 -0800 Subject: [8u-dev] Request for approval 8169355: Diacritics input works incorrectly on Windows if Spanish (Latin American) keyboard layout is used In-Reply-To: <58245E43.9090605@oracle.com> References: <58232061.5040409@oracle.com> <9f37fab7-149c-700a-1aa1-3e16a81c39c2@oracle.com> <58234999.8080100@oracle.com> <58235444.4070205@oracle.com> <582357A3.1070608@oracle.com> <58245E43.9090605@oracle.com> Message-ID: That would give me at least a reasonable measure of confidence. There isn't any actual hurry here anyway. There's more than a couple of months before RDP for the current PSU cycle. -phil. On 11/10/2016 03:47 AM, dmitry markov wrote: > Hello Phil, > > If JDK9 PIT cycle does not indicate any problems related to the fix, > then it may be backported to jdk8u-dev. Is my understanding correct? > > Thanks, > Dmitry > On 09/11/2016 20:06, Philip Race wrote: >> I'd like to see it at least get past our next JDK9 PIT cycle since it >> seems only a limited amount of testing was done. >> >> -phil. >> >> On 11/9/16, 8:52 AM, Se?n Coffey wrote: >>> Phil, >>> >>> Thanks for raising your concern on this issue. If you feel that this >>> fix could be problematic, then yes - we should allow more bake time >>> in JDK 9 first. >>> >>> Dmitry - please work with Phil to establish a suitable timeline >>> around when to push this fix into jdk8u-dev forest. >>> >>> Regards, >>> Sean. >>> >>> On 09/11/16 16:06, Philip Race wrote: >>>> Hmm. >>>> First, it was pushed to JDK 9 with only one reviewer (contrary to >>>> client group rules, without getting an exception). >>>> Second, it was pushed just hours ago. No bake time. It hasn't even >>>> been PIT tested. >>>> In fact it hasn't even been through a nightly build yet. >>>> I think this should *NOT* yet be approved for backport. >>>> >>>> -phil. >>>> >>>> On 11/9/16, 6:42 AM, david buck wrote: >>>>> approved for push to 8-dev >>>>> >>>>> Cheers, >>>>> -Buck >>>>> >>>>> On 2016/11/09 22:10, dmitry markov wrote: >>>>>> Hello, >>>>>> >>>>>> Can I get an approval to port the fix for 8169355 to jdk8u-dev, >>>>>> please? >>>>>> The jdk9 patch applies cleanly. >>>>>> >>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8169355 >>>>>> Webrev: http://cr.openjdk.java.net/~dmarkov/8169355/jdk8u/webrev.00/ >>>>>> Review thread: >>>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012289.html >>>>>> >>>>>> jdk9 changeset: >>>>>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/12a5c5f2a7c7 >>>>>> >>>>>> Thanks, >>>>>> Dmitry >>> > From rob.mckenna at oracle.com Thu Nov 10 18:12:50 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 10 Nov 2016 18:12:50 +0000 Subject: [8u-dev] Request for approval: 8165717 [macosx] Various memory leaks in jdk9 In-Reply-To: <98968032-1a28-4d79-8596-6244c0fca827@oracle.com> References: <98968032-1a28-4d79-8596-6244c0fca827@oracle.com> Message-ID: <20161110181250.GB2428@vimes> Approved -Rob On 10/11/16 07:56, Sergey Bylokhov wrote: > Hello, > These is a direct back port from jdk 9 to jdk 8u-dev. > > 8165717: [macosx] Various memory leaks in jdk9 > Bug: https://bugs.openjdk.java.net/browse/JDK-8165717 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8165717/webrev.00/ > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/374509e16f8a > Review: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-September/011923.html > Reviewers: Anton Tarasov, Semyon Sadetsky > > -- > Best regards, Sergey. From goetz.lindenmaier at sap.com Fri Nov 11 10:19:06 2016 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 11 Nov 2016 10:19:06 +0000 Subject: New jdk8u Committer: Christoph Langer In-Reply-To: References: Message-ID: <7d20d5a3d1ec4529be8384a2688e40fb@derote13de14.global.corp.sap> Vote: yes > -----Original Message----- > From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf > Of Volker Simonis > Sent: Freitag, 28. Oktober 2016 10:37 > To: jdk8u-dev at openjdk.java.net > Subject: CFV: New jdk8u Committer: Christoph Langer > > I hereby nominate Christoph Langer to jdk8u Committer. > > Christoph is a long-term member of the SAP JVM support team at SAP. > He is a jdk9 committer with a broad knowledge of the entire JDK as can > be seen from his record of twenty changes which he has contributed to > the class library [1], jaxp [2] as well as to the hotspot repository > [3]. > > Recently he has contributed 12 non-trivial changes to jdk8u (see below > for details): > > JDK > === > 8134505: Cleanup of "TimeZone_md.c" > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/e647bfb114da > > 8163181: Further improvements for Unix NetworkInterface native > implementation > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/8bc3c39ab16a > > > 8162598: XSLTC transformer swallows empty namespace declaration which > is needed to undeclare default namespace > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/ffa5c441e033 > > 8165320: Small flaw when integrating 8160174 to JDK8 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/f4bb6973e2ce > > > 8160174: java.net.NetworkInterface - fixes and improvements for > network interface listing > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3dc438e0c8e1 > > 8156521: Minor fixes and cleanups in NetworkInterface.c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/c5c0728e113d > > > 8153781: Issue in XMLScanner: > EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping > large > DOCTYPE section with CRLF at wrong place > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/39f7a1ab2b08 > > 8139436: sun.security.mscapi.KeyStore might load incomplete data > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/44a6aa58f7b2 > > JAXP > ==== > 8153781: Issue in XMLScanner: > EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping > large > DOCTYPE section with CRLF at wrong place > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/b2b2a7b4a160 > > 8162598: XSLTC transformer swallows empty namespace declaration which > is needed to undeclare default namespace > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/cbb8efe13927 > > HOTSPOT > ======= > 8140244: Port fix of JDK-8075773 to AIX and possibly MacOSX > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/2d23269a45a0 > > 8130910: hsperfdata file is created in wrong directory and not cleaned > up if /tmp/hsperfdata_ has wrong permissions > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/9f8038f83a6e > > Votes are due by 20:00 CET, November 11th, 2016. > > Only current jdk8u Committers [4] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [5]. > > Thanks, > Volker > > [1] > http://hg.openjdk.java.net/jdk9/dev/jdk/log?rev=%28author%28%22clange > r%22%29+or+desc%28%22Contributed- > by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 > [2] > http://hg.openjdk.java.net/jdk9/dev/jaxp/log?rev=%28author%28%22clang > er%22%29+or+desc%28%22Contributed- > by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 > [3] > http://hg.openjdk.java.net/jdk9/dev/hotspot/log?rev=%28author%28%22cl > anger%22%29+or+desc%28%22Contributed- > by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 > [4] http://openjdk.java.net/census#jdk8u > [5] http://openjdk.java.net/projects/#committer-vote From szegedia at gmail.com Fri Nov 11 15:08:18 2016 From: szegedia at gmail.com (Attila Szegedi) Date: Fri, 11 Nov 2016 16:08:18 +0100 Subject: [8u-dev] Request for Approval: 8168373: don't emit conversions for symbols outside their lexical scope Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8168373 jdk9 webrev: http://cr.openjdk.java.net/~attila/8168373/webrev.jdk9 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-November/006611.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Fri Nov 11 18:22:15 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 11 Nov 2016 18:22:15 +0000 Subject: [8u-dev] Request for Approval: 8168373: don't emit conversions for symbols outside their lexical scope In-Reply-To: References: Message-ID: <20161111182215.GC2411@vimes> Approved -Rob On 11/11/16 04:08, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8168373 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8168373/webrev.jdk9 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-November/006611.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From ramanand.patil at oracle.com Mon Nov 14 09:04:47 2016 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Mon, 14 Nov 2016 01:04:47 -0800 (PST) Subject: [8u-dev] Request for Approval: Backport of 8169191: (tz) Support tzdata2016i Message-ID: <257ce802-70af-4b8e-87a3-b93a009851d4@default> Hi, Please approve the backport of 8169191 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f7091c1dd33 JDK9 review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-November/002174.html Jdk8u review was done separately JDK8u Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-November/002179.html Regards, Ramanand. From david.buck at oracle.com Mon Nov 14 09:58:50 2016 From: david.buck at oracle.com (david buck) Date: Mon, 14 Nov 2016 18:58:50 +0900 Subject: [8u-dev] Request for Approval: Backport of 8169191: (tz) Support tzdata2016i In-Reply-To: <257ce802-70af-4b8e-87a3-b93a009851d4@default> References: <257ce802-70af-4b8e-87a3-b93a009851d4@default> Message-ID: <8d8134d1-9431-523f-9fe4-e922a14c17c6@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2016/11/14 18:04, Ramanand Patil wrote: > Hi, > Please approve the backport of 8169191 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8169191 > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7f7091c1dd33 > JDK9 review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-November/002174.html > > Jdk8u review was done separately > > JDK8u Review Thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2016-November/002179.html > > > Regards, > Ramanand. > From serguei.spitsyn at oracle.com Tue Nov 15 07:51:51 2016 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 14 Nov 2016 23:51:51 -0800 Subject: [8u-dev] Request for approval for CR JDK-8160024: jdb returns invalid argument count if first parameter to Arrays.asList is null Message-ID: <6c85dd49-ca50-0b3c-62d5-3654b8538288@oracle.com> Please, approve a JDK 8 backport of: https://bugs.openjdk.java.net/browse/JDK-8160024 The changeset from JDK 9 applies cleanly: http://hg.openjdk.java.net/jdk9/hs/jdk/rev/5a3a34170501 JDK 9 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-November/020659.html Thanks, Serguei From rob.mckenna at oracle.com Tue Nov 15 14:54:13 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 15 Nov 2016 14:54:13 +0000 Subject: [8u-dev] Request for approval for CR JDK-8160024: jdb returns invalid argument count if first parameter to Arrays.asList is null In-Reply-To: <6c85dd49-ca50-0b3c-62d5-3654b8538288@oracle.com> References: <6c85dd49-ca50-0b3c-62d5-3654b8538288@oracle.com> Message-ID: <20161115145413.GA2032@vimes> Approved -Rob On 14/11/16 11:51, serguei.spitsyn at oracle.com wrote: > Please, approve a JDK 8 backport of: > https://bugs.openjdk.java.net/browse/JDK-8160024 > > > The changeset from JDK 9 applies cleanly: > http://hg.openjdk.java.net/jdk9/hs/jdk/rev/5a3a34170501 > > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-November/020659.html > > > Thanks, > Serguei From serguei.spitsyn at oracle.com Tue Nov 15 15:45:34 2016 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 15 Nov 2016 07:45:34 -0800 Subject: [8u-dev] Request for approval for CR JDK-8160024: jdb returns invalid argument count if first parameter to Arrays.asList is null In-Reply-To: <20161115145413.GA2032@vimes> References: <6c85dd49-ca50-0b3c-62d5-3654b8538288@oracle.com> <20161115145413.GA2032@vimes> Message-ID: <03834670-2bb0-8963-d402-64b3eca5d7c5@oracle.com> Thanks, Rob! Serguei On 11/15/16 06:54, Rob McKenna wrote: > Approved > > -Rob > > On 14/11/16 11:51, serguei.spitsyn at oracle.com wrote: >> Please, approve a JDK 8 backport of: >> https://bugs.openjdk.java.net/browse/JDK-8160024 >> >> >> The changeset from JDK 9 applies cleanly: >> http://hg.openjdk.java.net/jdk9/hs/jdk/rev/5a3a34170501 >> >> JDK 9 review thread: >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-November/020659.html >> >> >> Thanks, >> Serguei From volker.simonis at gmail.com Wed Nov 16 11:33:38 2016 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 16 Nov 2016 12:33:38 +0100 Subject: Result: New jdk8u Committer: Christoph Langer Message-ID: Voting for Christoph Langer [1] is now closed. Yes: 12 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Regards, Volker Simonis [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-October/006074.html ---------- Forwarded message ---------- From: Volker Simonis Date: Fri, Oct 28, 2016 at 10:37 AM Subject: CFV: New jdk8u Committer: Christoph Langer To: "jdk8u-dev at openjdk.java.net" I hereby nominate Christoph Langer to jdk8u Committer. Christoph is a long-term member of the SAP JVM support team at SAP. He is a jdk9 committer with a broad knowledge of the entire JDK as can be seen from his record of twenty changes which he has contributed to the class library [1], jaxp [2] as well as to the hotspot repository [3]. Recently he has contributed 12 non-trivial changes to jdk8u (see below for details): JDK === 8134505: Cleanup of "TimeZone_md.c" http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/e647bfb114da 8163181: Further improvements for Unix NetworkInterface native implementation http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/8bc3c39ab16a 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/ffa5c441e033 8165320: Small flaw when integrating 8160174 to JDK8 http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/f4bb6973e2ce 8160174: java.net.NetworkInterface - fixes and improvements for network interface listing http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3dc438e0c8e1 8156521: Minor fixes and cleanups in NetworkInterface.c http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/c5c0728e113d 8153781: Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/39f7a1ab2b08 8139436: sun.security.mscapi.KeyStore might load incomplete data http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/44a6aa58f7b2 JAXP ==== 8153781: Issue in XMLScanner: EXPECTED_SQUARE_BRACKET_TO_CLOSE_INTERNAL_SUBSET when skipping large DOCTYPE section with CRLF at wrong place http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/b2b2a7b4a160 8162598: XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/cbb8efe13927 HOTSPOT ======= 8140244: Port fix of JDK-8075773 to AIX and possibly MacOSX http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/2d23269a45a0 8130910: hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/9f8038f83a6e Votes are due by 20:00 CET, November 11th, 2016. Only current jdk8u Committers [4] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [5]. Thanks, Volker [1] http://hg.openjdk.java.net/jdk9/dev/jdk/log?rev=%28author%28%22clanger%22%29+or+desc%28%22Contributed-by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 [2] http://hg.openjdk.java.net/jdk9/dev/jaxp/log?rev=%28author%28%22clanger%22%29+or+desc%28%22Contributed-by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 [3] http://hg.openjdk.java.net/jdk9/dev/hotspot/log?rev=%28author%28%22clanger%22%29+or+desc%28%22Contributed-by%3A+christoph.langer at sap.com%22%29%29+and+not+merge%28%29 [4] http://openjdk.java.net/census#jdk8u [5] http://openjdk.java.net/projects/#committer-vote From christoph.langer at sap.com Thu Nov 17 12:12:03 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Nov 2016 12:12:03 +0000 Subject: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 Message-ID: <8e5fc1819a5147e2a8d09c07b32b0682@DEWDFE13DE03.global.corp.sap> Hi, please review a downport of a few small fixes to JDK 8 which were done through bugs 8034174, 8034182 and 8048518 to JDK 9 already. Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8udev/ The change in Inet6AddressImpl.c is required because AIX would currently use the Solaris coding which is not desired. The changes in net_util_md.c fix a potential resource leak and some other code spot was changed where our code base currently has an unnecessary diff. Thanks for reviewing. Best regards Christoph From david.buck at oracle.com Thu Nov 17 15:56:49 2016 From: david.buck at oracle.com (David Buck) Date: Fri, 18 Nov 2016 00:56:49 +0900 Subject: [8u] RFA: 8158639: C2 compilation fails with SIGSEGV Message-ID: <582DD341.1020308@oracle.com> Hi! Please approve this simple backport from 9 to 8u-dev. bug report: [ 8158639: C2 compilation fails with SIGSEGV ] https://bugs.openjdk.java.net/browse/JDK-8158639 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/119a2a3cc29b 8u-dev Webrev: http://cr.openjdk.java.net/~dbuck/jdk8158639_8u_01/ backport code review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025225.html Testing: Manual verification and JPRT (default and hotspot testsets) Cheers, -Buck From sean.coffey at oracle.com Thu Nov 17 16:01:44 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 17 Nov 2016 16:01:44 +0000 Subject: [8u] RFA: 8158639: C2 compilation fails with SIGSEGV In-Reply-To: <582DD341.1020308@oracle.com> References: <582DD341.1020308@oracle.com> Message-ID: Approved. regards, Sean. On 17/11/2016 15:56, David Buck wrote: > Hi! > > Please approve this simple backport from 9 to 8u-dev. > > bug report: > [ 8158639: C2 compilation fails with SIGSEGV ] > https://bugs.openjdk.java.net/browse/JDK-8158639 > > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/119a2a3cc29b > > 8u-dev Webrev: > http://cr.openjdk.java.net/~dbuck/jdk8158639_8u_01/ > > backport code review: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025225.html > > > Testing: > Manual verification and JPRT (default and hotspot testsets) > > Cheers, > -Buck From sean.coffey at oracle.com Thu Nov 17 17:03:40 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 17 Nov 2016 17:03:40 +0000 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov Message-ID: I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. Vladimir Ivanov is an engineer in the hotspot development team and is already a Reviewer in the JDK 9 Project. He has contributed several changes to the JDK 8u Project [3]. Votes are due by 18:00 GMT, 1st December 2016. Only current JDK 8 Updates Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. regards, Sean. [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#reviewer-vote [3] http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 From Sergey.Bylokhov at oracle.com Thu Nov 17 17:14:04 2016 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 17 Nov 2016 20:14:04 +0300 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <49c94d9e-f6d7-1b2c-27e8-bd1c5057f040@oracle.com> Vote: yes On 17.11.16 20:03, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > -- Best regards, Sergey. From harold.seigel at oracle.com Thu Nov 17 18:08:20 2016 From: harold.seigel at oracle.com (harold seigel) Date: Thu, 17 Nov 2016 13:08:20 -0500 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: Vote: yes Harold On 11/17/2016 12:03 PM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > From vladimir.kozlov at oracle.com Thu Nov 17 18:14:41 2016 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 17 Nov 2016 10:14:41 -0800 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <5d20706e-0474-3ab8-3d10-e23167837e97@oracle.com> Vote: yes On 11/17/16 9:03 AM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is already a Reviewer in the JDK 9 Project. He has > contributed several changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by > replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > From sean.coffey at oracle.com Thu Nov 17 18:16:26 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 17 Nov 2016 18:16:26 +0000 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <7d3a4482-566d-f8c7-c04a-f5e66b6b62fd@oracle.com> Vote: yes regards, Sean. On 17/11/2016 17:03, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > From paul.sandoz at oracle.com Thu Nov 17 18:31:05 2016 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Thu, 17 Nov 2016 10:31:05 -0800 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <840DC685-0537-4C19-AD2E-F81022087B52@oracle.com> Vote: yes Paul. From karen.kinnear at oracle.com Thu Nov 17 19:18:20 2016 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 17 Nov 2016 14:18:20 -0500 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: Vote: yes Karen > On Nov 17, 2016, at 12:03 PM, Se?n Coffey wrote: > > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is already a Reviewer in the JDK 9 Project. He has contributed several changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > From david.holmes at oracle.com Thu Nov 17 20:04:34 2016 From: david.holmes at oracle.com (David Holmes) Date: Fri, 18 Nov 2016 06:04:34 +1000 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <4a25b1d9-f443-8484-4de0-e7b88ca191d7@oracle.com> Vote: yes David On 18/11/2016 3:03 AM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > From artem.ananiev at oracle.com Thu Nov 17 20:09:04 2016 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 17 Nov 2016 12:09:04 -0800 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <582E0E60.8070302@oracle.com> Vote: yes Artem On 11/17/16, 9:03 AM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > From dalibor.topic at oracle.com Fri Nov 18 10:24:32 2016 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 18 Nov 2016 11:24:32 +0100 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: <8647eb22-1cf8-7ab7-7c47-626fd05ed8a4@oracle.com> Vote: Yes. -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From mike at r3cev.com Fri Nov 18 17:44:41 2016 From: mike at r3cev.com (Mike Hearn) Date: Fri, 18 Nov 2016 17:44:41 +0000 Subject: Requesting backport of JDK-8022291 to 8u Message-ID: <95DF9AB2-1F79-47ED-8586-3F90F394823C@r3cev.com> Hiya, Fix here: http://hg.openjdk.java.net/jdk9/client/jdk/rev/423a8d66fe60 The cited bug results in an ugly error message being printed to the console when Mac OS X java 8 is used in conjunction with some kinds of agent. It isn't serious but does make Java and our software look less professional. A backport to JDK8 would be much appreciated. thanks, -mike From david.buck at oracle.com Sat Nov 19 05:21:41 2016 From: david.buck at oracle.com (David Buck) Date: Sat, 19 Nov 2016 14:21:41 +0900 Subject: [8u] RFA 8022291: Mac OS: Unexpected JavaLaunchHelper message displaying Message-ID: <582FE165.10605@oracle.com> Hi! Please approve this trivial backport from 9 to 8u. The changeset applies cleanly after unshuffling. All tests pass on default JPRT run and I have manually confirmed that issue no longer reproduces with this change. bug report: https://bugs.openjdk.java.net/browse/JDK-8022291 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/423a8d66fe60 jdk9 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011527.html Cheers, -Buck From rob.mckenna at oracle.com Sat Nov 19 17:51:24 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sat, 19 Nov 2016 17:51:24 +0000 Subject: [8u] RFA 8022291: Mac OS: Unexpected JavaLaunchHelper message displaying In-Reply-To: <582FE165.10605@oracle.com> References: <582FE165.10605@oracle.com> Message-ID: <20161119175124.GD2303@vimes> Approved -Rob On 19/11/16 02:21, David Buck wrote: > Hi! > > Please approve this trivial backport from 9 to 8u. The changeset applies > cleanly after unshuffling. All tests pass on default JPRT run and I have > manually confirmed that issue no longer reproduces with this change. > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8022291 > > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/423a8d66fe60 > > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-June/011527.html > > Cheers, > -Buck From shafi.s.ahmad at oracle.com Mon Nov 21 03:53:28 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Sun, 20 Nov 2016 19:53:28 -0800 (PST) Subject: [8u] RFA for JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata Message-ID: <14ff63f6-0c27-42e9-a500-2ab073d469a3@default> Hi, Please approve this backport of ' JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata' to 8u-dev. Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8134389 Webrev: http://cr.openjdk.java.net/~shshahma/8134389/webrev.01/ Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025212.html Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-September/024372.html Regards, Shafi From david.buck at oracle.com Mon Nov 21 04:16:16 2016 From: david.buck at oracle.com (David Buck) Date: Mon, 21 Nov 2016 13:16:16 +0900 Subject: [8u] RFA for JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata In-Reply-To: <14ff63f6-0c27-42e9-a500-2ab073d469a3@default> References: <14ff63f6-0c27-42e9-a500-2ab073d469a3@default> Message-ID: <58327510.9030903@oracle.com> approved for push to 8u-dev Cheers, -Buck On 2016/11/21 12:53, Shafi Ahmad wrote: > Hi, > > Please approve this backport of ' JDK-8134389: Crash in HotSpot with jvm.dll+0x42b48 ciObjectFactory::create_new_metadata' to 8u-dev. > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8134389 > Webrev: http://cr.openjdk.java.net/~shshahma/8134389/webrev.01/ > Jdk8 review link: http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025212.html > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-September/024372.html > > Regards, > Shafi From mike at r3cev.com Mon Nov 21 10:30:33 2016 From: mike at r3cev.com (Mike Hearn) Date: Mon, 21 Nov 2016 10:30:33 +0000 Subject: [8u] RFA 8022291: Mac OS: Unexpected JavaLaunchHelper message displaying In-Reply-To: <20161119175124.GD2303@vimes> References: <582FE165.10605@oracle.com> <20161119175124.GD2303@vimes> Message-ID: Thanks guys, it's much appreciated. From chris.hegarty at oracle.com Mon Nov 21 10:53:59 2016 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 21 Nov 2016 10:53:59 +0000 Subject: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 In-Reply-To: <8e5fc1819a5147e2a8d09c07b32b0682@DEWDFE13DE03.global.corp.sap> References: <8e5fc1819a5147e2a8d09c07b32b0682@DEWDFE13DE03.global.corp.sap> Message-ID: <1936c7d7-6aae-c074-bde0-65009b10cb62@oracle.com> On 17/11/16 12:12, Langer, Christoph wrote: > Hi, > > please review a downport of a few small fixes to JDK 8 which were done > through bugs 8034174, 8034182 and 8048518 to JDK 9 already. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8udev/ The changes look fine. -Chris > > The change in Inet6AddressImpl.c is required because AIX would currently > use the Solaris coding which is not desired. The changes in > net_util_md.c fix a potential resource leak and some other code spot was > changed where our code base currently has an unnecessary diff. > > Thanks for reviewing. > > Best regards > Christoph From christoph.langer at sap.com Mon Nov 21 13:23:47 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 21 Nov 2016 13:23:47 +0000 Subject: RFA: 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 Message-ID: Hi, please approve this backport - bug id and webrev see below. The change is reviewed. Thanks Christoph -----Original Message----- From: Chris Hegarty [mailto:chris.hegarty at oracle.com] Sent: Montag, 21. November 2016 11:54 To: Langer, Christoph Cc: net-dev at openjdk.java.net; jdk8u-dev at openjdk.java.net Subject: Re: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 On 17/11/16 12:12, Langer, Christoph wrote: > Hi, > > please review a downport of a few small fixes to JDK 8 which were done > through bugs 8034174, 8034182 and 8048518 to JDK 9 already. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8udev/ The changes look fine. -Chris > > The change in Inet6AddressImpl.c is required because AIX would currently > use the Solaris coding which is not desired. The changes in > net_util_md.c fix a potential resource leak and some other code spot was > changed where our code base currently has an unnecessary diff. > > Thanks for reviewing. > > Best regards > Christoph From volker.simonis at gmail.com Mon Nov 21 14:02:35 2016 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 21 Nov 2016 15:02:35 +0100 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: Vote: yes On Thu, Nov 17, 2016 at 6:03 PM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several changes > to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > From rob.mckenna at oracle.com Mon Nov 21 21:43:45 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 21 Nov 2016 21:43:45 +0000 Subject: RFA: 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 In-Reply-To: References: Message-ID: <20161121214345.GD4643@tecra> Approved -Rob On 21/11/16 01:23, Langer, Christoph wrote: > Hi, > > please approve this backport - bug id and webrev see below. The change is reviewed. > > Thanks > Christoph > > -----Original Message----- > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > Sent: Montag, 21. November 2016 11:54 > To: Langer, Christoph > Cc: net-dev at openjdk.java.net; jdk8u-dev at openjdk.java.net > Subject: Re: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 > > On 17/11/16 12:12, Langer, Christoph wrote: > > Hi, > > > > please review a downport of a few small fixes to JDK 8 which were done > > through bugs 8034174, 8034182 and 8048518 to JDK 9 already. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8udev/ > > The changes look fine. > > -Chris > > > > > The change in Inet6AddressImpl.c is required because AIX would currently > > use the Solaris coding which is not desired. The changes in > > net_util_md.c fix a potential resource leak and some other code spot was > > changed where our code base currently has an unnecessary diff. > > > > Thanks for reviewing. > > > > Best regards > > Christoph From daniel.daugherty at oracle.com Tue Nov 22 01:49:05 2016 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 21 Nov 2016 18:49:05 -0700 Subject: CFV: New JDK 8 Updates Reviewer: Vladimir Ivanov In-Reply-To: References: Message-ID: Vote: yes Dan On 11/17/16 10:03 AM, Se?n Coffey wrote: > I hereby nominate Vladimir Ivanov (vlivanov) to JDK 8 Updates Reviewer. > > Vladimir Ivanov is an engineer in the hotspot development team and is > already a Reviewer in the JDK 9 Project. He has contributed several > changes to the JDK 8u Project [3]. > > Votes are due by 18:00 GMT, 1st December 2016. > > Only current JDK 8 Updates Reviewers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this > mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > regards, > Sean. > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=1000&rev=%28keyword%28%22vladimir.x.ivanov%40oracle.com%22%29+or+author%28vlivanov%29%29+and+not+desc%28%22Merge%22%29 > > > From christoph.langer at sap.com Tue Nov 22 07:39:33 2016 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 22 Nov 2016 07:39:33 +0000 Subject: RFR (XS): 8169865: Downport minor fixes in java.net native code from JDK 9 to JDK 8 In-Reply-To: <1936c7d7-6aae-c074-bde0-65009b10cb62@oracle.com> References: <8e5fc1819a5147e2a8d09c07b32b0682@DEWDFE13DE03.global.corp.sap> <1936c7d7-6aae-c074-bde0-65009b10cb62@oracle.com> Message-ID: <93c218739fe94ba58082791648d48d92@DEWDFE13DE03.global.corp.sap> Thanks, Chris. It's pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/90d2c6ddcedd > -----Original Message----- > From: Chris Hegarty [mailto:chris.hegarty at oracle.com] > Sent: Montag, 21. November 2016 11:54 > To: Langer, Christoph > Cc: net-dev at openjdk.java.net; jdk8u-dev at openjdk.java.net > Subject: Re: RFR (XS): 8169865: Downport minor fixes in java.net native code > from JDK 9 to JDK 8 > > On 17/11/16 12:12, Langer, Christoph wrote: > > Hi, > > > > please review a downport of a few small fixes to JDK 8 which were done > > through bugs 8034174, 8034182 and 8048518 to JDK 9 already. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169865 > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8169865.8udev/ > > The changes look fine. > > -Chris > > > > > The change in Inet6AddressImpl.c is required because AIX would currently > > use the Solaris coding which is not desired. The changes in > > net_util_md.c fix a potential resource leak and some other code spot was > > changed where our code base currently has an unnecessary diff. > > > > Thanks for reviewing. > > > > Best regards > > Christoph From shafi.s.ahmad at oracle.com Wed Nov 23 12:15:06 2016 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Wed, 23 Nov 2016 04:15:06 -0800 (PST) Subject: [8u] RFA for JDK-8134918 - C2: Type speculation produces mismatched unsafe accesses Message-ID: <86c2764a-1d1b-482a-8b0e-eacec21ec1ce@default> Hi, Please approve backport of following dependent bugs to 8u-dev. 1. JDK-8134918 C2: Type speculation produces mismatched unsafe accesses 2. JDK-8140309 [REDO] failed: no mismatched stores, except on raw memory: StoreB StoreI 3. JDK-8162101 C2: Handle "wide" aliases for unsafe accesses 4. JDK-8155781 C2: opaque unsafe access triggers an assert Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8134918 Webrev: http://cr.openjdk.java.net/~shshahma/8134918/webrev.02/ Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-April/022433.html Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8140309 Webrev: http://cr.openjdk.java.net/~shshahma/8140309/webrev.01/ Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-November/019696.html Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8162101 Webrev: http://cr.openjdk.java.net/~shshahma/8162101/webrev.02/ Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-August/024248.html Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8155781 Webrev: http://cr.openjdk.java.net/~shshahma/8155781/webrev.00/ Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023859.html Jdk8 review links: 1. http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025182.html 2. http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-October/024913.html Regards, Shafi From rob.mckenna at oracle.com Wed Nov 23 13:49:33 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 23 Nov 2016 13:49:33 +0000 Subject: [8u] RFA for JDK-8134918 - C2: Type speculation produces mismatched unsafe accesses In-Reply-To: <86c2764a-1d1b-482a-8b0e-eacec21ec1ce@default> References: <86c2764a-1d1b-482a-8b0e-eacec21ec1ce@default> Message-ID: <20161123134933.GA2294@vimes> Approved -Rob On 23/11/16 04:15, Shafi Ahmad wrote: > Hi, > > Please approve backport of following dependent bugs to 8u-dev. > 1. JDK-8134918 C2: Type speculation produces mismatched unsafe accesses > 2. JDK-8140309 [REDO] failed: no mismatched stores, except on raw memory: StoreB StoreI > 3. JDK-8162101 C2: Handle "wide" aliases for unsafe accesses > 4. JDK-8155781 C2: opaque unsafe access triggers an assert > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8134918 > Webrev: http://cr.openjdk.java.net/~shshahma/8134918/webrev.02/ > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-April/022433.html > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8140309 > Webrev: http://cr.openjdk.java.net/~shshahma/8140309/webrev.01/ > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-November/019696.html > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8162101 > Webrev: http://cr.openjdk.java.net/~shshahma/8162101/webrev.02/ > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-August/024248.html > > Jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8155781 > Webrev: http://cr.openjdk.java.net/~shshahma/8155781/webrev.00/ > Jdk9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-July/023859.html > > Jdk8 review links: > 1. http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-November/025182.html > 2. http://mail.openjdk.java.net/pipermail/hotspot-dev/2016-October/024913.html > > Regards, > Shafi From rob.mckenna at oracle.com Wed Nov 23 14:04:03 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 23 Nov 2016 14:04:03 +0000 Subject: Request for approval & review: 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304 Message-ID: <20161123140403.GB2294@vimes> Hi folks, Looking for approval for this backport from 9. The change adds some extra cases to our jarsigner timestamp checks. Bug: https://bugs.openjdk.java.net/browse/JDK-8169911 Webrev: http://cr.openjdk.java.net/~robm/8169911/ 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d09aebe3b50d The only difference between 8 & 9 compensates for the use of List.of in 9. -Rob From sean.coffey at oracle.com Wed Nov 23 14:28:01 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 23 Nov 2016 14:28:01 +0000 Subject: Request for approval & review: 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304 In-Reply-To: <20161123140403.GB2294@vimes> References: <20161123140403.GB2294@vimes> Message-ID: <5835A771.9010303@oracle.com> Looks fine. Approved. Regards, Sean. On 23/11/16 14:04, Rob McKenna wrote: > Hi folks, > > Looking for approval for this backport from 9. The change adds some > extra cases to our jarsigner timestamp checks. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169911 > Webrev: http://cr.openjdk.java.net/~robm/8169911/ > 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d09aebe3b50d > > The only difference between 8 & 9 compensates for the use of List.of in > 9. > > -Rob > From anton.tarasov at jetbrains.com Wed Nov 23 16:03:32 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Wed, 23 Nov 2016 19:03:32 +0300 Subject: [8u-dev] Request for approval: JDK-8140525 AwtFrame::WmShowWindow() may steal focus Message-ID: <3bc8b9f1-aae7-159a-1a64-8b0284f3416a@jetbrains.com> Hello, Could you please approve a direct back-port to 8u-dev? bug: https://bugs.openjdk.java.net/browse/JDK-8140525 webrev: http://cr.openjdk.java.net/~ant/JDK-8140525/8u/webrev.0 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012339.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/b64f4ea8dc42 Thanks, Anton. From anton.tarasov at jetbrains.com Thu Nov 24 07:20:23 2016 From: anton.tarasov at jetbrains.com (Anton Tarasov) Date: Thu, 24 Nov 2016 10:20:23 +0300 Subject: [8u-dev] Request for approval: JDK-8140525 AwtFrame::WmShowWindow() may steal focus In-Reply-To: <3bc8b9f1-aae7-159a-1a64-8b0284f3416a@jetbrains.com> References: <3bc8b9f1-aae7-159a-1a64-8b0284f3416a@jetbrains.com> Message-ID: <982e0269-6ed7-d248-e0af-7367ceb68ee7@jetbrains.com> On 11/23/2016 7:03 PM, Anton Tarasov wrote: > Hello, > > Could you please approve a direct back-port to 8u-dev? > > bug: https://bugs.openjdk.java.net/browse/JDK-8140525 > > webrev: http://cr.openjdk.java.net/~ant/JDK-8140525/8u/webrev.0 > > Sorry, the wrapped link above is wrong. Corrected: http://cr.openjdk.java.net/~ant/JDK-8140525/8u/webrev.0 Anton. > > review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012339.html > > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/b64f4ea8dc42 > > Thanks, > Anton. > From sean.coffey at oracle.com Thu Nov 24 09:33:12 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 24 Nov 2016 09:33:12 +0000 Subject: [8u-dev] Request for approval: JDK-8140525 AwtFrame::WmShowWindow() may steal focus In-Reply-To: <982e0269-6ed7-d248-e0af-7367ceb68ee7@jetbrains.com> References: <3bc8b9f1-aae7-159a-1a64-8b0284f3416a@jetbrains.com> <982e0269-6ed7-d248-e0af-7367ceb68ee7@jetbrains.com> Message-ID: <17ba0307-e20f-9917-94b3-72517918cdaf@oracle.com> Approved. regards, Sean. On 24/11/2016 07:20, Anton Tarasov wrote: > On 11/23/2016 7:03 PM, Anton Tarasov wrote: > >> Hello, >> >> Could you please approve a direct back-port to 8u-dev? >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8140525 >> >> webrev: http://cr.openjdk.java.net/~ant/JDK-8140525/8u/webrev.0 >> >> > Sorry, the wrapped link above is wrong. Corrected: > > http://cr.openjdk.java.net/~ant/JDK-8140525/8u/webrev.0 > > > Anton. > >> >> review thread: >> http://mail.openjdk.java.net/pipermail/awt-dev/2016-November/012339.html >> >> jdk9 changeset: >> http://hg.openjdk.java.net/jdk9/client/jdk/rev/b64f4ea8dc42 >> >> Thanks, >> Anton. >> > From Roger.Riggs at Oracle.com Mon Nov 28 16:44:21 2016 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Mon, 28 Nov 2016 11:44:21 -0500 Subject: [8u$N] Request for enhancement backport approval for CR 8164908 ReflectionFactory support for IIOP and custom serialization Message-ID: <72619c23-919e-fc8d-39c5-edee1ef955c6@Oracle.com> Please approve the backport of enhancements to sun.reflect.ReflectionFactory[1] to facilitate the transition of custom serialization libraries to the strong encapsulation in JDK 9. The methods added to ReflectionFactory are used as replacements for the use of setAccessible to access private methods specific to serialization. The risk is minimal for JDK 8. The new methods have been implemented in JDK 9 and are used by the JDK 9 IIOP implementation. Tests for the new APIs are included in JDK 9 and are included in the backport. To minimize risk to JDK 8, the IIOP implementation is not modified. Thanks, Roger [1] 8164908 ReflectionFactory support for IIOP and custom serialization From Roger.Riggs at Oracle.com Mon Nov 28 20:32:18 2016 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Mon, 28 Nov 2016 15:32:18 -0500 Subject: [8u] 8164908 : ReflectionFactory support for IIOP and custom serialization Message-ID: <8a39bdb2-9186-706b-2d21-741bf9e2e3a1@Oracle.com> Please review this enhancement to the ReflectionFactory to support custom serialization libraries. The enhancement [2] was originally reviewed for JDK 9 [1]; though the webrev is no long available. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-reflect-factory-8164908/ Issue: https://bugs.openjdk.java.net/browse/JDK-8164908 Thanks, Roger [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-October/044242.html [2] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5c851d70cb76 Only the changes to ReflectionFactory are salient due to the differences in the supporting classes From ivan.gerasimov at oracle.com Tue Nov 29 09:08:08 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Tue, 29 Nov 2016 12:08:08 +0300 Subject: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on Message-ID: <9cc990e9-d4a0-7ade-8f5b-215ad92f95cf@oracle.com> Hello! It was reported that there's broken behavior exposed when the debug mode is turned on, which is due to KerberosTicket.toString() throwing an exception, if the ticket was already destroyed. The proposed fix is in fact the backport of a tiny portion of JDK-8043071. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278 WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/ Would you please help review? With kind regards, Ivan From sean.coffey at oracle.com Tue Nov 29 09:16:35 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 29 Nov 2016 09:16:35 +0000 Subject: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on In-Reply-To: <9cc990e9-d4a0-7ade-8f5b-215ad92f95cf@oracle.com> References: <9cc990e9-d4a0-7ade-8f5b-215ad92f95cf@oracle.com> Message-ID: <9abcd965-f01a-5074-62f3-cc4878ba4537@oracle.com> Looks good. regards, Sean. On 29/11/2016 09:08, Ivan Gerasimov wrote: > Hello! > > It was reported that there's broken behavior exposed when the debug > mode is turned on, which is due to KerberosTicket.toString() throwing > an exception, if the ticket was already destroyed. > > The proposed fix is in fact the backport of a tiny portion of > JDK-8043071. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278 > WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/ > > Would you please help review? > > With kind regards, > Ivan From chris.hegarty at oracle.com Tue Nov 29 09:36:27 2016 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 29 Nov 2016 09:36:27 +0000 Subject: [8u] 8164908 : ReflectionFactory support for IIOP and custom serialization In-Reply-To: <8a39bdb2-9186-706b-2d21-741bf9e2e3a1@Oracle.com> References: <8a39bdb2-9186-706b-2d21-741bf9e2e3a1@Oracle.com> Message-ID: <01881AE8-9BEA-4364-A241-8D396D89C433@oracle.com> > On 28 Nov 2016, at 20:32, Roger Riggs wrote: > > Please review this enhancement to the ReflectionFactory to support custom serialization > libraries. > > The enhancement [2] was originally reviewed for JDK 9 [1]; though the webrev is no long available. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-reflect-factory-8164908/ Thanks for doing this Roger. The changes look good. -Chris. > Issue: > https://bugs.openjdk.java.net/browse/JDK-8164908 > > Thanks, Roger > > [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-October/044242.html > [2] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5c851d70cb76 > Only the changes to ReflectionFactory are salient due to the differences in the supporting classes From sean.coffey at oracle.com Tue Nov 29 09:43:22 2016 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 29 Nov 2016 09:43:22 +0000 Subject: [8u$N] Request for enhancement backport approval for CR 8164908 ReflectionFactory support for IIOP and custom serialization In-Reply-To: <72619c23-919e-fc8d-39c5-edee1ef955c6@Oracle.com> References: <72619c23-919e-fc8d-39c5-edee1ef955c6@Oracle.com> Message-ID: <12289aa7-48fe-ec46-1632-2152a9d66fef@oracle.com> Thanks for the request Roger. This one is currently under review. regards, Sean. On 28/11/2016 16:44, Roger Riggs wrote: > Please approve the backport of enhancements to > sun.reflect.ReflectionFactory[1] to facilitate > the transition of custom serialization libraries to the strong > encapsulation in JDK 9. > > The methods added to ReflectionFactory are used as replacements for the > use of setAccessible to access private methods specific to serialization. > > The risk is minimal for JDK 8. > The new methods have been implemented in JDK 9 and are used by the > JDK 9 IIOP implementation. > Tests for the new APIs are included in JDK 9 and are included in the > backport. > To minimize risk to JDK 8, the IIOP implementation is not modified. > > Thanks, Roger > > [1] 8164908 ReflectionFactory support for IIOP and custom serialization > From weijun.wang at oracle.com Tue Nov 29 10:59:01 2016 From: weijun.wang at oracle.com (Wang Weijun) Date: Tue, 29 Nov 2016 18:59:01 +0800 Subject: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on In-Reply-To: <9abcd965-f01a-5074-62f3-cc4878ba4537@oracle.com> References: <9cc990e9-d4a0-7ade-8f5b-215ad92f95cf@oracle.com> <9abcd965-f01a-5074-62f3-cc4878ba4537@oracle.com> Message-ID: <713B2D5A-C9C4-4FBC-A990-5F59CD1266A1@oracle.com> +1 --Max > On Nov 29, 2016, at 5:16 PM, Se?n Coffey wrote: > > Looks good. > > regards, > Sean. > > > On 29/11/2016 09:08, Ivan Gerasimov wrote: >> Hello! >> >> It was reported that there's broken behavior exposed when the debug mode is turned on, which is due to KerberosTicket.toString() throwing an exception, if the ticket was already destroyed. >> >> The proposed fix is in fact the backport of a tiny portion of JDK-8043071. >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278 >> WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/ >> >> Would you please help review? >> >> With kind regards, >> Ivan > From ivan.gerasimov at oracle.com Wed Nov 30 10:24:54 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 30 Nov 2016 13:24:54 +0300 Subject: [8u-dev] Request for approval to backport: 8059212: Modify sun/security/smartcardio manual regression tests so that they do not just fail if no cardreader found Message-ID: <02727f73-42ea-f8e7-d82b-feb1d4945e95@oracle.com> Hello! I'd like to backport this fix, which makes it more convenient to execute this group of manual tests. The jdk9 patch applies cleanly. Would you please approve the backport? BUG: https://bugs.openjdk.java.net/browse/JDK-8059212 Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f106f8f0a7b0 Jdk9 review: http://mail.openjdk.java.net/pipermail/security-dev/2016-February/013397.html With kind regards, Ivan From ivan.gerasimov at oracle.com Wed Nov 30 10:44:37 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 30 Nov 2016 13:44:37 +0300 Subject: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on In-Reply-To: <713B2D5A-C9C4-4FBC-A990-5F59CD1266A1@oracle.com> References: <9cc990e9-d4a0-7ade-8f5b-215ad92f95cf@oracle.com> <9abcd965-f01a-5074-62f3-cc4878ba4537@oracle.com> <713B2D5A-C9C4-4FBC-A990-5F59CD1266A1@oracle.com> Message-ID: Thanks Sean and Max! On 29.11.2016 13:59, Wang Weijun wrote: > +1 > > --Max > >> On Nov 29, 2016, at 5:16 PM, Se?n Coffey wrote: >> >> Looks good. >> >> regards, >> Sean. >> >> >> On 29/11/2016 09:08, Ivan Gerasimov wrote: >>> Hello! >>> >>> It was reported that there's broken behavior exposed when the debug mode is turned on, which is due to KerberosTicket.toString() throwing an exception, if the ticket was already destroyed. >>> >>> The proposed fix is in fact the backport of a tiny portion of JDK-8043071. >>> >>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278 >>> WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/ >>> >>> Would you please help review? >>> >>> With kind regards, >>> Ivan > From david.buck at oracle.com Wed Nov 30 10:44:47 2016 From: david.buck at oracle.com (David Buck) Date: Wed, 30 Nov 2016 19:44:47 +0900 Subject: [8u-dev] Request for approval to backport: 8059212: Modify sun/security/smartcardio manual regression tests so that they do not just fail if no cardreader found In-Reply-To: <02727f73-42ea-f8e7-d82b-feb1d4945e95@oracle.com> References: <02727f73-42ea-f8e7-d82b-feb1d4945e95@oracle.com> Message-ID: <583EAD9F.3070406@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2016/11/30 19:24, Ivan Gerasimov wrote: > Hello! > > I'd like to backport this fix, which makes it more convenient to > execute this group of manual tests. > The jdk9 patch applies cleanly. > > Would you please approve the backport? > > BUG: https://bugs.openjdk.java.net/browse/JDK-8059212 > Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f106f8f0a7b0 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/security-dev/2016-February/013397.html > > With kind regards, > Ivan From ivan.gerasimov at oracle.com Wed Nov 30 10:47:26 2016 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 30 Nov 2016 13:47:26 +0300 Subject: [8u-dev] Request for approval to backport: 8059212: Modify sun/security/smartcardio manual regression tests so that they do not just fail if no cardreader found In-Reply-To: <583EAD9F.3070406@oracle.com> References: <02727f73-42ea-f8e7-d82b-feb1d4945e95@oracle.com> <583EAD9F.3070406@oracle.com> Message-ID: <9ce7b44c-f87f-faee-cc0a-828b984a5148@oracle.com> Thanks! On 30.11.2016 13:44, David Buck wrote: > approved for backport to 8u-dev > > Cheers, > -Buck > > On 2016/11/30 19:24, Ivan Gerasimov wrote: >> Hello! >> >> I'd like to backport this fix, which makes it more convenient to >> execute this group of manual tests. >> The jdk9 patch applies cleanly. >> >> Would you please approve the backport? >> >> BUG: https://bugs.openjdk.java.net/browse/JDK-8059212 >> Jdk9 change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f106f8f0a7b0 >> Jdk9 review: >> http://mail.openjdk.java.net/pipermail/security-dev/2016-February/013397.html >> >> With kind regards, >> Ivan > > From igor.nunes at eldorado.org.br Wed Nov 30 16:51:59 2016 From: igor.nunes at eldorado.org.br (Igor Henrique Soares Nunes) Date: Wed, 30 Nov 2016 16:51:59 +0000 Subject: [8u] request for approval: "8168318 : PPC64: Use cmpldi instead of li/cmpld" Message-ID: Hi all, Could you please approve the backport of the following ppc64-only improvement to jdk8u-dev: 8168318: PPC64: Use cmpldi instead of li/cmpld Bug: https://bugs.openjdk.java.net/browse/JDK-8168318 Webrev: https://igorsnunes.github.io/openjdk/webrev/8168318/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-October/024809.html URL: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/622d3fe587f2 Thank you and best regards, Igor Nunes From rob.mckenna at oracle.com Wed Nov 30 17:40:23 2016 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 30 Nov 2016 17:40:23 +0000 Subject: [8u] request for approval: "8168318 : PPC64: Use cmpldi instead of li/cmpld" In-Reply-To: References: Message-ID: <20161130174023.GA2448@vimes> Hi Igor, As this is an enhancement request, please follow the enhancement approval request process: http://openjdk.java.net/projects/jdk8u/enhancement-template.html http://openjdk.java.net/projects/jdk8u/groundrules.html -Rob On 30/11/16 04:51, Igor Henrique Soares Nunes wrote: > Hi all, > > Could you please approve the backport of the following ppc64-only improvement to jdk8u-dev: > > 8168318: PPC64: Use cmpldi instead of li/cmpld > > Bug: https://bugs.openjdk.java.net/browse/JDK-8168318 > Webrev: https://igorsnunes.github.io/openjdk/webrev/8168318/ > Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-October/024809.html > URL: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/622d3fe587f2 > > Thank you and best regards, > Igor Nunes >