[8u] RFR: 8059038: Create new launcher for SA tools

Severin Gehwolf sgehwolf at redhat.com
Wed Dec 19 16:59:42 UTC 2018


On Wed, 2018-12-19 at 16:56 +0000, Andrew Hughes wrote:
> On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> > 
> > On Wed, 2018-12-19 at 06:46 +0000, Andrew Hughes wrote:
> > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf <sgehwolf at redhat.com>
> > > wrote:
> > > > 
> > > > On Thu, 2018-12-13 at 15:49 +0000, Andrew Hughes wrote:
> > > > > Ok, I presume that's not a change you're also going to make in
> > > > > OpenJDK 12?
> > > > 
> > > > Yes. I don't intend to change this in JDK 12. JDK 8 and JDK 9+ are
> > > > not
> > > > compatible in this regard. That's the case before and after this
> > > > patch.
> > > > 
> > > > > I'm fine with them being linked by the same bug ID, as they
> > > > > resolve the same
> > > > > underlying issue, but this really needs to be clear in the
> > > > > summary
> > > > > text, as, to the
> > > > > uninformed, they look like completely different patches.
> > > > 
> > > > OK will do. Can I consider this reviewed?
> > > > 
> > > > Thanks,
> > > > Severin
> > > > 
> > > 
> > > I'd like to see an updated webrev with a more detailed commit message
> > > first.
> > 
> > Here you go:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/03/
> > 
> > Thanks,
> > Severin
> > 
> 
> I was hoping for a note on why it differs from 9 :-)

Any suggestions? Perhaps this?

"Summary: Create separate launchers for clhsdb and hsdb since JDK 8 uses separate launchers for SA tools"

Thanks,
Severin



More information about the jdk8u-dev mailing list