[8u-dev] Request for Approval for CR 8198794: Hotspot crash on Cassandra 3.11.1 startup with libnuma 2.0.3

[Gustavo Romero]

Hi David!

On 03/23/2018 05:28 AM, David Buck wrote:
> Hi Gustavo!
> 
> I took the liberty of pushing the fix for you.
> 
> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c2ee42fa54cd
> 
> Thank you for fixing this bad regression.

Thanks a lot for pushing it! :-)


Cheers,
Gustavo

> 
> Cheers,
> -Buck
> 
> On 2018/03/21 1:46, Gustavo Romero wrote:
>> Hi,
>>
>>
>> On 03/20/2018 11:29 AM, Rob McKenna wrote:
>>> Approved
>>
>> Thank you.
>>
>>
>> @Volker, do you mind to push that fix to jdk8u-dev for me please?
>>
>>
>> Regards,
>> Gustavo
>>
>>> On 16/03/18 20:15, Gustavo Romero wrote:
>>>> Hi,
>>>>
>>>> I would like to request the approval for pushing the following change
>>>> that applies cleanly to jdk8u-dev except for an offset correction and
>>>> a file path adjust (due to repo consolidation) and fixes a JVM crash
>>>> when -XX:+UseNUMA is used on a system with libnuma 2.0.3 or older:
>>>>
>>>> Bug          : https://bugs.openjdk.java.net/browse/JDK-8198794
>>>> Change       : http://hg.openjdk.java.net/jdk/hs/rev/7fb0ad2d8749
>>>> Review Thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030657.html
>>>>
>>>> This change is in shared code but is of very low risk since it can be
>>>> regarded as addressing a sort of corner case on libnuma API v2
>>>> implementation where numa_nodes_ptr variable is not defined before
>>>> the libnuma 2.0.5 (2010). Thus nothing changes for any system that
>>>> uses a recent libnuma (from Oct 2010 to the present), hence for the
>>>> great majority of Linux distros releases in use today.
>>>>
>>>> Thank you.
>>>>
>>>>
>>>> Best regards,
>>>> Gustavo
>>>>
>>>
>>
>