From sean.coffey at oracle.com Tue May 1 10:16:38 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 1 May 2018 11:16:38 +0100 Subject: [8u-dev] 8193171 : keytool -list displays "JKS" for a PKCS12 keystore In-Reply-To: <6952bad9-e230-8dce-be2d-2bb8f22c0b4c@oracle.com> References: <6952bad9-e230-8dce-be2d-2bb8f22c0b4c@oracle.com> Message-ID: Looks fine to me. regards, Sean. On 30/04/2018 20:16, Ivan Gerasimov wrote: > Hello! > > This is 8u-dev only bug fix. > > It was noticed that the keytool from the latest JDK 8 update release > displays type of PKCS12 keystore as JKS. > > Would you please help review the patch? > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8193171 > WEBREV: http://cr.openjdk.java.net/~igerasim/8193171/00/webrev/ > > Thanks in advance! > From ramanand.patil at oracle.com Wed May 2 08:56:04 2018 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Wed, 2 May 2018 01:56:04 -0700 (PDT) Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: Vote: yes Regards, Ramanand. > -----Original Message----- > From: Se?n Coffey > Sent: Thursday, April 26, 2018 8:21 PM > To: jdk8u-dev at openjdk.java.net > Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam > > I hereby nominate Bhanu Prakash Gopularam (bgopularam)to JDK 8 Updates > Committer. > > Bhanu has been working in the Update Release SQE team for last 3.5 years. > In Jan 2018 he received his Ph.D degree from University of Mysore for > research work on Data Security using Identity and Attribute based > Cryptographic schemes. > > He has contributed a range of fixes to the jdk8u Project [0] > > Votes are due by 18:00 GMT on May 10th 2018 > > Only current JDK 8 Updates Committers [1] are eligible to vote on this > nomination.? Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > regards, > Sean. > > [0] > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/log?revcount=200&rev=(author > (bgopularam)+or+desc(%22bhanu.prakash.gopularam%40oracle.com%22))+ > and+not+merge() > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From sgehwolf at redhat.com Thu May 3 08:16:48 2018 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 03 May 2018 10:16:48 +0200 Subject: [8u] RFA: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390 Message-ID: <1525335408.4079.9.camel@redhat.com> Hi, Please approve this backport of JDK-8201495 which reduces the max heap requirement for the boot JDK of 32bit JVMs. It causes build failures of the Zero variant JVM on s390 (31 bit, takes the 32bit branch). The fix is in JDK 11, has been requested for JDK 10. The JDK 8 fix has been reviewed on build-dev as the JDK 11 fix is slightly different due to the different build systems. Once approved, I'd need an Oracle sponsor to push this for me since it requires re-generation of generated-configure.sh. Bug: https://bugs.openjdk.java.net/browse/JDK-8201495 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/webrev.jdk8/ JDK 8 changeset (without generated-configure.sh): http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/JDK-8201495.jdk8.export.patch JDK 8 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021918.html JDK 11 review thread was: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021754.html Thanks, Severin From aph at redhat.com Thu May 3 17:21:32 2018 From: aph at redhat.com (Andrew Haley) Date: Thu, 3 May 2018 18:21:32 +0100 Subject: [8u] RFR(XS): 8202600: [Zero] Undefined behaviour in src/os_cpu/linux_zero/vm/os_linux_zero.cpp Message-ID: <5815944c-8202-e9ec-695b-f1e9bc8b647e@redhat.com> Hi, Please review this trivial change which fixes a potential crasher bug in JDK 8 Zero. JDK 10+ don't have this problem since they got fixed with JDK-8143245. I figured a smaller fix like this would be more likely to get accepted as a backport. If you'd rather have JDK-8143245 backported to JDK 8, that would be fine with me too. Bug: https://bugs.openjdk.java.net/browse/JDK-8202600 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202600/webrev.jdk8.01/ Testing: We've been using this patch downstream for months now without issues. Thanks, Severin From sgehwolf at redhat.com Thu May 3 17:24:29 2018 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 03 May 2018 19:24:29 +0200 Subject: [8u] RFA: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols Message-ID: <1525368269.4079.36.camel@redhat.com> Hi, Please approve this backport of JDK-8196516 which allows us to build with linker flags like "-Wl,-z,defs" a potential default in future Fedora versions. A fix for this is in JDK 11 and I've not heard of any issues. The JDK 8 change has been reviewed again as the JDK 11 patch didn't apply cleanly (post-path-unshuffeling). Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ RFR for JDK 8: http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021938.html RFR for JDK 11: http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html Thanks, Severin From sean.coffey at oracle.com Thu May 3 17:48:26 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 3 May 2018 18:48:26 +0100 Subject: [8u] RFR(XS): 8202600: [Zero] Undefined behaviour in src/os_cpu/linux_zero/vm/os_linux_zero.cpp In-Reply-To: <5815944c-8202-e9ec-695b-f1e9bc8b647e@redhat.com> References: <5815944c-8202-e9ec-695b-f1e9bc8b647e@redhat.com> Message-ID: Approved. Please add a suitable noreg- label to the bug report http://openjdk.java.net/guide/changePlanning.html regards, Sean. On 03/05/2018 18:21, Andrew Haley wrote: > Hi, > > Please review this trivial change which fixes a potential crasher bug > in JDK 8 Zero. JDK 10+ don't have this problem since they got fixed > with JDK-8143245. I figured a smaller fix like this would be more > likely to get accepted as a backport. If you'd rather have JDK-8143245 > backported to JDK 8, that would be fine with me too. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8202600 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202600/webrev.jdk8.01/ > > Testing: We've been using this patch downstream for months now without > issues. > > Thanks, > Severin From sean.coffey at oracle.com Thu May 3 17:49:46 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 3 May 2018 18:49:46 +0100 Subject: [8u] RFA: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols In-Reply-To: <1525368269.4079.36.camel@redhat.com> References: <1525368269.4079.36.camel@redhat.com> Message-ID: <23c5d1dc-accb-2dc0-17e9-f323b05d8a81@oracle.com> Approved. Please add noreg-build label to bug report. regards, Sean. On 03/05/2018 18:24, Severin Gehwolf wrote: > Hi, > > Please approve this backport of JDK-8196516 which allows us to build > with linker flags like "-Wl,-z,defs" a potential default in future > Fedora versions. A fix for this is in JDK 11 and I've not heard of any > issues. The JDK 8 change has been reviewed again as the JDK 11 patch > didn't apply cleanly (post-path-unshuffeling). > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196516 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8196516/webrev.jdk8/ > > RFR for JDK 8: > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021938.html > > RFR for JDK 11: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021575.html > > Thanks, > Severin From sean.coffey at oracle.com Thu May 3 17:53:21 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 3 May 2018 18:53:21 +0100 Subject: [8u] RFA: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390 In-Reply-To: <1525335408.4079.9.camel@redhat.com> References: <1525335408.4079.9.camel@redhat.com> Message-ID: <53091de5-ca08-82e5-40b6-afb44cef612f@oracle.com> Approved. Please add noreg-build label to this bug also. I can push this patch for you. regards, Sean. On 03/05/2018 09:16, Severin Gehwolf wrote: > Hi, > > Please approve this backport of JDK-8201495 which reduces the max heap > requirement for the boot JDK of 32bit JVMs. It causes build failures of > the Zero variant JVM on s390 (31 bit, takes the 32bit branch). The fix > is in JDK 11, has been requested for JDK 10. The JDK 8 fix has been > reviewed on build-dev as the JDK 11 fix is slightly different due to > the different build systems. > > Once approved, I'd need an Oracle sponsor to push this for me since it > requires re-generation of generated-configure.sh. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8201495 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/webrev.jdk8/ > JDK 8 changeset (without generated-configure.sh): > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/JDK-8201495.jdk8.export.patch > > JDK 8 review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021918.html > > JDK 11 review thread was: > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021754.html > > Thanks, > Severin > > From dipak.kumar at oracle.com Fri May 4 03:34:44 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Thu, 3 May 2018 20:34:44 -0700 (PDT) Subject: [8u] RFA for JDK-8202478 : Backout JDK-8152974 Message-ID: <045fdc8c-c553-4d75-a508-9149fbd511d9@default> Hi, May I get the approval to push a patch for "JDK-8202478 : Backout JDK-8152974" to jdk8u-dev. JBS - https://bugs.openjdk.java.net/browse/JDK-8202478 JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8202478/webrev.00/ JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-May/013914.html Fix for JDK-8152974 (https://bugs.openjdk.java.net/browse/JDK-8152974) has caused a regression. Above patch is for backing out this changeset. I have ensured that there are no failures related to this on JPRT (Stockholm) queues. Thanks, Dipak From sgehwolf at redhat.com Fri May 4 07:35:35 2018 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 04 May 2018 09:35:35 +0200 Subject: [8u] RFA: 8201495: [Zero] Reduce limits of max heap size for boot JDK on s390 In-Reply-To: <53091de5-ca08-82e5-40b6-afb44cef612f@oracle.com> References: <1525335408.4079.9.camel@redhat.com> <53091de5-ca08-82e5-40b6-afb44cef612f@oracle.com> Message-ID: <1525419335.4179.1.camel@redhat.com> Hi Sean, On Thu, 2018-05-03 at 18:53 +0100, Se?n Coffey wrote: > Approved. Please add noreg-build label to this bug also. I've added the noreg-build label. > I can push this patch for you. Thank you, much appreciated! Cheers, Severin > regards, > Sean. > > > On 03/05/2018 09:16, Severin Gehwolf wrote: > > Hi, > > > > Please approve this backport of JDK-8201495 which reduces the max heap > > requirement for the boot JDK of 32bit JVMs. It causes build failures of > > the Zero variant JVM on s390 (31 bit, takes the 32bit branch). The fix > > is in JDK 11, has been requested for JDK 10. The JDK 8 fix has been > > reviewed on build-dev as the JDK 11 fix is slightly different due to > > the different build systems. > > > > Once approved, I'd need an Oracle sponsor to push this for me since it > > requires re-generation of generated-configure.sh. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8201495 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/webrev.jdk8/ > > JDK 8 changeset (without generated-configure.sh): > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8201495/JDK-8201495.jdk8.export.patch > > > > JDK 8 review thread: > > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/021918.html > > > > JDK 11 review thread was: > > http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021754.html > > > > Thanks, > > Severin > > > > > > From sean.coffey at oracle.com Fri May 4 12:12:56 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 4 May 2018 13:12:56 +0100 Subject: [8u] RFA for JDK-8202478 : Backout JDK-8152974 In-Reply-To: <045fdc8c-c553-4d75-a508-9149fbd511d9@default> References: <045fdc8c-c553-4d75-a508-9149fbd511d9@default> Message-ID: Dipak, what are your plans for JDK 11 ? I'm approving this subject to you also having a plan to address it in JDK 11. Please add a suitable noreg label to the the bug report also. Regards, Sean. On 04/05/18 04:34, Dipak Kumar wrote: > Hi, > > May I get the approval to push a patch for "JDK-8202478 : Backout JDK-8152974" to jdk8u-dev. > > JBS - https://bugs.openjdk.java.net/browse/JDK-8202478 > > JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8202478/webrev.00/ > > JDK-8u review thread - http://mail.openjdk.java.net/pipermail/awt-dev/2018-May/013914.html > > Fix for JDK-8152974 (https://bugs.openjdk.java.net/browse/JDK-8152974) has caused a regression. Above patch is for backing out this changeset. > > I have ensured that there are no failures related to this on JPRT (Stockholm) queues. > > Thanks, > Dipak > > From dipak.kumar at oracle.com Fri May 4 12:42:50 2018 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Fri, 4 May 2018 05:42:50 -0700 (PDT) Subject: [8u] RFA for JDK-8202478 : Backout JDK-8152974 In-Reply-To: References: <045fdc8c-c553-4d75-a508-9149fbd511d9@default> Message-ID: Hi Sean, Thanks for the approval. Krishna from development team is already working to correct this and get a fix for JDK-11. I have added a noreg label in the bug report. Thanks, Dipak -----Original Message----- From: Se?n Coffey Sent: 04 May 2018 17:43 To: Dipak Kumar ; jdk8u-dev at openjdk.java.net Subject: Re: [8u] RFA for JDK-8202478 : Backout JDK-8152974 Dipak, what are your plans for JDK 11 ? I'm approving this subject to you also having a plan to address it in JDK 11. Please add a suitable noreg label to the the bug report also. Regards, Sean. On 04/05/18 04:34, Dipak Kumar wrote: > Hi, > > May I get the approval to push a patch for "JDK-8202478 : Backout JDK-8152974" to jdk8u-dev. > > JBS - https://bugs.openjdk.java.net/browse/JDK-8202478 > > JDK-8u webrev - http://cr.openjdk.java.net/~dkumar/8202478/webrev.00/ > > JDK-8u review thread - > http://mail.openjdk.java.net/pipermail/awt-dev/2018-May/013914.html > > Fix for JDK-8152974 (https://bugs.openjdk.java.net/browse/JDK-8152974) has caused a regression. Above patch is for backing out this changeset. > > I have ensured that there are no failures related to this on JPRT (Stockholm) queues. > > Thanks, > Dipak > > From sean.coffey at oracle.com Fri May 4 15:00:56 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 4 May 2018 16:00:56 +0100 Subject: [8u-communication] Updates to JDK 8 Updates Project pages Message-ID: <7f5569ef-c03b-a5df-1734-2e4657914acc@oracle.com> As per previous discussions [1], the OpenJDK 8 Updates Project pages [2] had some stale references to JDK 9 fix requirements. With the new JDK release model, I've made the following edits : Ground Rules : Rule 1: * JDK 9 fix requirement removed : ============================== All changes that are not specific to JDK 8 Update MUST go into the JDK Project first. As a special exception, a change MAY go into JDK 8 Update if it is at the same time also proposed for inclusion into JDK. Approval template : * substituted the JDK 9 change link requirement with one for changeset link to JDK Project. ============================== either a link to the publicly visible webrev or a link to the original changeset in the JDK Project if it's the same patch. requested that a link to review thread of parent bug fix be included where relevant. Phase2 approval template Similar to above - substituted the JDK 9 change link requirement with a requirement for changeset link to JDK Project. ============================== Code review : Substituted JDK 9 with JDK Project references ============================== Q and A document : minor updates : Corrected link to the OpenJDK bylaws document (was referring to draft) Removed references to JDK 9 Project fix requirements for JDK 8u fixes. Substituted with JDK Project. ============================== [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/007276.html [2] http://openjdk.java.net/projects/jdk8u/ -- Regards, Sean. From shade at redhat.com Tue May 8 08:50:46 2018 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 8 May 2018 10:50:46 +0200 Subject: [8u-dev] Request for approval JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: <20180416134127.GA2862@vimes> References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> <20180416134127.GA2862@vimes> Message-ID: Hi Rob, Review had finally happened at hotspot-dev@, see: http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032092.html Thomas ran this through JPRT as well. -Aleksey On 04/16/2018 03:41 PM, Rob McKenna wrote: > This change requires a codereview. As one hasn't been explicitly > requested in the subject line, then HS reviewers may overlook this > email. > > -Rob > > On 13/04/18 18:45, Aleksey Shipilev wrote: >> Hi, >> >> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for >> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, >> because there is also Unsafe_GetObject140 that needs fixing too. >> >> JDK 9 bug: >> https://bugs.openjdk.java.net/browse/JDK-8165489 >> >> JDK 9 fix: >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb >> >> JDK 8u fix: >> http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ >> >> Testing: x86_64 build, Shenandoah tests >> >> Thanks, >> -Aleksey From rob.mckenna at oracle.com Tue May 8 11:34:36 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 8 May 2018 12:34:36 +0100 Subject: [8u-dev] Request for approval JDK-8165489: Missing G1 barrier in Unsafe_GetObjectVolatile In-Reply-To: References: <53443eaa-fbbd-1238-b4c5-6373e43535ca@redhat.com> <20180416134127.GA2862@vimes> Message-ID: <20180508113436.GA3211@vimes> Thanks Aleksey, approved. -Rob On 08/05/18 10:50, Aleksey Shipilev wrote: > Hi Rob, > > Review had finally happened at hotspot-dev@, see: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-May/032092.html > > Thomas ran this through JPRT as well. > > -Aleksey > > On 04/16/2018 03:41 PM, Rob McKenna wrote: > > This change requires a codereview. As one hasn't been explicitly > > requested in the subject line, then HS reviewers may overlook this > > email. > > > > -Rob > > > > On 13/04/18 18:45, Aleksey Shipilev wrote: > >> Hi, > >> > >> Please approve this fix for 8u. This improves G1 stability in 8u, and provides the base for > >> Shenandoah JDK 8 backport that piggybacks on G1 pre-barriers. The fix does not apply cleanly, > >> because there is also Unsafe_GetObject140 that needs fixing too. > >> > >> JDK 9 bug: > >> https://bugs.openjdk.java.net/browse/JDK-8165489 > >> > >> JDK 9 fix: > >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a696583f5ddb > >> > >> JDK 8u fix: > >> http://cr.openjdk.java.net/~shade/8165489-8u/webrev.01/ > >> > >> Testing: x86_64 build, Shenandoah tests > >> > >> Thanks, > >> -Aleksey > > From sean.coffey at oracle.com Tue May 8 15:59:59 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 8 May 2018 16:59:59 +0100 Subject: [8u-communication] Plans for next Oracle OpenJDK 8 Updates based release Message-ID: Oracle doesn't plan to create a separate JDK 8u PSU release with the 8u181 CPU[1] release scheduled for July 2018. Given the small amount of changes that were destined specifically for 8u182 (and not for 8u181 as well), the process to propose critical fixes for inclusion in JDK 8u CPU releases [2] should be used instead, where applicable. If you have questions or concerns, please share them on the jdk8u-dev mailing list. The next Oracle release scheduled from this Project's forest would be 8u192. The provisional timeline is proposed as follows : January 2018 - 8u-dev forest begins collecting 8u192 fixes July 2018 - RampDown 2 October 2018 - GA If I don't hear any objections, I'll post this timeline on the Project page towards the end of this week. [1] https://www.oracle.com/technetwork/topics/security/alerts-086861.html#CriticalPatchUpdates [2] http://openjdk.java.net/projects/jdk8u/criticalcpufixes.html regards, Sean. From dalibor.topic at oracle.com Wed May 9 11:03:23 2018 From: dalibor.topic at oracle.com (dalibor topic) Date: Wed, 9 May 2018 13:03:23 +0200 Subject: CFV: New JDK 8 Updates Committer: Bhanu Prakash Gopularam In-Reply-To: References: Message-ID: <2762a6b4-5005-55cc-5acd-6ddcd5d03d9e@oracle.com> Vote: yes. -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Jan Schultheiss, Val Maher Oracle is committed to developing practices and products that help protect the environment From sean.coffey at oracle.com Fri May 11 07:33:57 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 11 May 2018 08:33:57 +0100 Subject: Result: New JDK 8 Updates Committer : Bhanu Prakash Gopularam Message-ID: <588124e4-057e-cf6b-bada-5e81a86ea414@oracle.com> Voting for Bhanu Prakash Gopularam [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. regards, Sean. [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-April/007432.html From petrkuzel at eurofins.com Fri May 11 11:45:48 2018 From: petrkuzel at eurofins.com (Petr Kuzel) Date: Fri, 11 May 2018 11:45:48 +0000 Subject: Leaked debug messages? Message-ID: Hi, I wonder if http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/d70c21e5b413 have not sneaked in few debug messages, namely: if (magic == POST) { + System.err.println("DISABLED: " + disableIncomingHttp); + if (disableIncomingHttp) { + throw new RemoteException("RMI over HTTP is disabled"); + } tcpLog.log(Log.BRIEF, "decoding HTTP-wrapped call"); and LocateRegistry.createRegistry(FALLBACK_PORT); + System.err.println("1-DISABLED: " + System.getProperty("java.rmi.server.disableIncomingHttp")); + Hope it helps Cc. From sean.coffey at oracle.com Fri May 11 13:09:17 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 11 May 2018 14:09:17 +0100 Subject: Leaked debug messages? (JDK-8202996) In-Reply-To: References: Message-ID: <60a3aec6-efbe-a0ed-4331-eb2819b35f5c@oracle.com> Good spot Petr, Looks like an issue. I've logged https://bugs.openjdk.java.net/browse/JDK-8202996 The 2nd println statement is not a concern since it's in a testcase. Regards, Sean. On 11/05/18 12:45, Petr Kuzel wrote: > Hi, > > I wonder if http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/d70c21e5b413 > have not sneaked in few debug messages, namely: > > if (magic == POST) { > + System.err.println("DISABLED: " + disableIncomingHttp); > + if (disableIncomingHttp) { > + throw new RemoteException("RMI over HTTP is disabled"); > + } > tcpLog.log(Log.BRIEF, "decoding HTTP-wrapped call"); > > and > > > LocateRegistry.createRegistry(FALLBACK_PORT); > > > > + System.err.println("1-DISABLED: " + System.getProperty("java.rmi.server.disableIncomingHttp")); > > + > > > Hope it helps > Cc. From vladimir.x.ivanov at oracle.com Fri May 11 21:22:26 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 11 May 2018 14:22:26 -0700 Subject: [8u] RFA: 8162540: Crash in C2 escape analysis with assert: "node should be registered" Message-ID: Hi, I'd like to request approval to push a backport of JDK-8162540 into 8u-dev: JBS: https://bugs.openjdk.java.net/browse/JDK-8162540 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot /rev/82e3a58aca6f 8u webrev: http://cr.openjdk.java.net/~vlivanov/8162540/webrev.00/ 8u review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-May/028994.html It was fixed back in 9 long time ago, but hasn't been backported yet. Recently it was reported that the bug causes incorrect code being generated by C2. The fix didn't apply cleanly, but minor adjustments were enough. Thanks! Best regards, Vladimir Ivanov From rob.mckenna at oracle.com Sat May 12 22:08:41 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sat, 12 May 2018 23:08:41 +0100 Subject: [8u-dev] Request for approval & review: 8202996 - Remove debug print statements from RMI fix In-Reply-To: <60a3aec6-efbe-a0ed-4331-eb2819b35f5c@oracle.com> References: <60a3aec6-efbe-a0ed-4331-eb2819b35f5c@oracle.com> Message-ID: <20180512220841.GA4785@vimes> D'oh - thanks Petr: https://bugs.openjdk.java.net/browse/JDK-8202996 http://cr.openjdk.java.net/~robm/8202996/webrev.01/ Note: the test fix println has already been removed. -Rob On 11/05/18 14:09, Se?n Coffey wrote: > Good spot Petr, > > Looks like an issue. I've logged > https://bugs.openjdk.java.net/browse/JDK-8202996 > > The 2nd println statement is not a concern since it's in a testcase. > > Regards, > Sean. > > On 11/05/18 12:45, Petr Kuzel wrote: > >Hi, > > > >I wonder if http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/d70c21e5b413 > >have not sneaked in few debug messages, namely: > > > > if (magic == POST) { > >+ System.err.println("DISABLED: " + disableIncomingHttp); > >+ if (disableIncomingHttp) { > >+ throw new RemoteException("RMI over HTTP is disabled"); > >+ } > > tcpLog.log(Log.BRIEF, "decoding HTTP-wrapped call"); > > > >and > > > > > > LocateRegistry.createRegistry(FALLBACK_PORT); > > > > > > > >+ System.err.println("1-DISABLED: " + System.getProperty("java.rmi.server.disableIncomingHttp")); > > > >+ > > > > > > Hope it helps > > Cc. > From sean.coffey at oracle.com Sun May 13 21:55:41 2018 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Sun, 13 May 2018 22:55:41 +0100 Subject: [8u-dev] Request for approval & review: 8202996 - Remove debug print statements from RMI fix In-Reply-To: <20180512220841.GA4785@vimes> References: <60a3aec6-efbe-a0ed-4331-eb2819b35f5c@oracle.com> <20180512220841.GA4785@vimes> Message-ID: <58171DEE-C85A-479C-9A83-4C8B9D8C4A99@oracle.com> Looks fine. Approved for jdk8u-dev. Please add an appropriate noreg- label. Regards, Sean. On 12 May 2018 23:08:41 IST, Rob McKenna wrote: >D'oh - thanks Petr: > >https://bugs.openjdk.java.net/browse/JDK-8202996 >http://cr.openjdk.java.net/~robm/8202996/webrev.01/ > >Note: the test fix println has already been removed. > > -Rob > >On 11/05/18 14:09, Se?n Coffey wrote: >> Good spot Petr, >> >> Looks like an issue. I've logged >> https://bugs.openjdk.java.net/browse/JDK-8202996 >> >> The 2nd println statement is not a concern since it's in a testcase. >> >> Regards, >> Sean. >> >> On 11/05/18 12:45, Petr Kuzel wrote: >> >Hi, >> > >> >I wonder if >http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/d70c21e5b413 >> >have not sneaked in few debug messages, namely: >> > >> > if (magic == POST) { >> >+ System.err.println("DISABLED: " + >disableIncomingHttp); >> >+ if (disableIncomingHttp) { >> >+ throw new RemoteException("RMI over HTTP is >disabled"); >> >+ } >> > tcpLog.log(Log.BRIEF, "decoding HTTP-wrapped >call"); >> > >> >and >> > >> > >> > LocateRegistry.createRegistry(FALLBACK_PORT); >> > >> > >> > >> >+ System.err.println("1-DISABLED: " + >System.getProperty("java.rmi.server.disableIncomingHttp")); >> > >> >+ >> > >> > >> > Hope it helps >> > Cc. >> From sean.coffey at oracle.com Sun May 13 21:57:58 2018 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Sun, 13 May 2018 22:57:58 +0100 Subject: [8u] RFA: 8162540: Crash in C2 escape analysis with assert: "node should be registered" In-Reply-To: References: Message-ID: <0EAFCC46-34C4-4D47-BF72-E3AD92698D73@oracle.com> Approved. Regards, Sean. On 11 May 2018 22:22:26 IST, Vladimir Ivanov wrote: >Hi, > >I'd like to request approval to push a backport of JDK-8162540 into >8u-dev: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8162540 > > 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot >/rev/82e3a58aca6f > > 8u webrev: http://cr.openjdk.java.net/~vlivanov/8162540/webrev.00/ > > 8u review: >http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-May/028994.html > >It was fixed back in 9 long time ago, but hasn't been backported yet. >Recently it was reported that the bug causes incorrect code being >generated by C2. The fix didn't apply cleanly, but minor adjustments >were enough. > >Thanks! > >Best regards, >Vladimir Ivanov From vladimir.x.ivanov at oracle.com Mon May 14 19:46:50 2018 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Mon, 14 May 2018 12:46:50 -0700 Subject: [8u] RFA: 8162540: Crash in C2 escape analysis with assert: "node should be registered" In-Reply-To: <0EAFCC46-34C4-4D47-BF72-E3AD92698D73@oracle.com> References: <0EAFCC46-34C4-4D47-BF72-E3AD92698D73@oracle.com> Message-ID: <33cca448-5cb2-6e9b-4cfc-d4486ad1e74d@oracle.com> Thanks, Sean! Best regards, Vladimir Ivanov On 5/13/18 14:57, Se?n Coffey wrote: > Approved. > > Regards, > Sean. > > On 11 May 2018 22:22:26 IST, Vladimir Ivanov > wrote: > > Hi, > > I'd like to request approval to push a backport of JDK-8162540 into 8u-dev: > > JBS:https://bugs.openjdk.java.net/browse/JDK-8162540 > > 9 changeset:http://hg.openjdk.java.net/jdk9/jdk9/hotspot > /rev/82e3a58aca6f > > 8u webrev:http://cr.openjdk.java.net/~vlivanov/8162540/webrev.00/ > > 8u review: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-May/028994.html > > It was fixed back in 9 long time ago, but hasn't been backported yet. > Recently it was reported that the bug causes incorrect code being > generated by C2. The fix didn't apply cleanly, but minor adjustments > were enough. > > Thanks! > > Best regards, > Vladimir Ivanov > From kevin.walls at oracle.com Sat May 19 08:13:28 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Sat, 19 May 2018 09:13:28 +0100 Subject: [8u-dev] Request for approval for CR 8078437: Enable use of devkits for Windows. Message-ID: <65b0142a-61f0-9046-4332-33c1782d675c@oracle.com> Hi, I'd like to request approval to backport from 9 to 8u: 8078437: Enable use of devkits for Windows. JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92 9 review thread:/http://mail.openjdk.java.net/pipermail/build-dev/2015-April/014870.html / Webrev of proposed 8u change: http://cr.openjdk.java.net/~kevinw/8078437/webrev.00/ New 8u technical review: http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022132.html Thanks Kevin From kevin.walls at oracle.com Mon May 21 09:08:46 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Mon, 21 May 2018 10:08:46 +0100 Subject: [8u-dev] Request for approval: 8203349: 8u hotspot should recognise later Windows compilers Message-ID: <559a61ad-ea2d-8c88-0ae7-84013a990dee@oracle.com> Hi, I'd like to request approval to push a new hotspot Windows build-related change into 8u (not applicable to 9 and later): 8203349: 8u hotspot should recognise later Windows compilers JBS: https://bugs.openjdk.java.net/browse/JDK-8203349 8u webrev: http://cr.openjdk.java.net/~kevinw/8203349/webrev.01/ Review email thread: http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022126.html Thanks Kevin From sean.coffey at oracle.com Mon May 21 09:37:53 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 21 May 2018 10:37:53 +0100 Subject: [8u-dev] Request for approval for CR 8078437: Enable use of devkits for Windows. In-Reply-To: <65b0142a-61f0-9046-4332-33c1782d675c@oracle.com> References: <65b0142a-61f0-9046-4332-33c1782d675c@oracle.com> Message-ID: <5d362a46-f29e-543c-7eaa-5915aba5d0bd@oracle.com> Approved. Regards, Sean. On 19/05/18 09:13, Kevin Walls wrote: > Hi, > > I'd like to request approval to backport from 9 to 8u: > > 8078437: Enable use of devkits for Windows. > JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 > > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92 > > 9 review > thread:/http://mail.openjdk.java.net/pipermail/build-dev/2015-April/014870.html > / > Webrev of proposed 8u change: > http://cr.openjdk.java.net/~kevinw/8078437/webrev.00/ > > New 8u technical review: > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022132.html > > Thanks > Kevin > From sean.coffey at oracle.com Mon May 21 09:40:08 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 21 May 2018 10:40:08 +0100 Subject: [8u-dev] Request for approval: 8203349: 8u hotspot should recognise later Windows compilers In-Reply-To: <559a61ad-ea2d-8c88-0ae7-84013a990dee@oracle.com> References: <559a61ad-ea2d-8c88-0ae7-84013a990dee@oracle.com> Message-ID: <88d1bdee-38f8-10a1-9b74-1c4568d7b2b0@oracle.com> Approved. Regards, Sean. On 21/05/18 10:08, Kevin Walls wrote: > Hi, > > I'd like to request approval to push a new hotspot Windows > build-related change into 8u (not applicable to 9 and later): > > 8203349: 8u hotspot should recognise later Windows compilers > JBS: https://bugs.openjdk.java.net/browse/JDK-8203349 > > 8u webrev: http://cr.openjdk.java.net/~kevinw/8203349/webrev.01/ > > Review email thread: > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022126.html > > Thanks > Kevin > From kevin.walls at oracle.com Mon May 21 09:51:58 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Mon, 21 May 2018 10:51:58 +0100 Subject: [8u-dev] Request for approval for CR 8078437: Enable use of devkits for Windows. In-Reply-To: <5d362a46-f29e-543c-7eaa-5915aba5d0bd@oracle.com> References: <65b0142a-61f0-9046-4332-33c1782d675c@oracle.com> <5d362a46-f29e-543c-7eaa-5915aba5d0bd@oracle.com> Message-ID: <7a4c08c0-f72b-42da-17a5-7a2adfbfa3b1@oracle.com> Great, thanks! On 21/05/2018 10:37, Se?n Coffey wrote: > Approved. > > Regards, > Sean. > > On 19/05/18 09:13, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport from 9 to 8u: >> >> 8078437: Enable use of devkits for Windows. >> JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 >> >> 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92 >> >> 9 review >> thread:/http://mail.openjdk.java.net/pipermail/build-dev/2015-April/014870.html >> / >> Webrev of proposed 8u change: >> http://cr.openjdk.java.net/~kevinw/8078437/webrev.00/ >> >> New 8u technical review: >> http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022132.html >> >> Thanks >> Kevin >> > From sean.coffey at oracle.com Mon May 21 14:30:36 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 21 May 2018 15:30:36 +0100 Subject: [8u-dev] Request for approval for CR 8078437: Enable use of devkits for Windows. In-Reply-To: <5d362a46-f29e-543c-7eaa-5915aba5d0bd@oracle.com> References: <65b0142a-61f0-9046-4332-33c1782d675c@oracle.com> <5d362a46-f29e-543c-7eaa-5915aba5d0bd@oracle.com> Message-ID: <9c71a37e-00f4-6b23-a6d1-eb02206b3579@oracle.com> Kevin, just realised that this request falls under the realm of enhancement backports. For that, can you please also log an enhancement backport request and we'll get this reviewed. http://openjdk.java.net/projects/jdk8u/enhancement-template.html Thanks! Sean. On 21/05/18 10:37, Se?n Coffey wrote: > Approved. > > Regards, > Sean. > > On 19/05/18 09:13, Kevin Walls wrote: >> Hi, >> >> I'd like to request approval to backport from 9 to 8u: >> >> 8078437: Enable use of devkits for Windows. >> JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 >> >> 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92 >> >> 9 review >> thread:/http://mail.openjdk.java.net/pipermail/build-dev/2015-April/014870.html >> / >> Webrev of proposed 8u change: >> http://cr.openjdk.java.net/~kevinw/8078437/webrev.00/ >> >> New 8u technical review: >> http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022132.html >> >> Thanks >> Kevin >> > From kevin.walls at oracle.com Mon May 21 14:38:27 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Mon, 21 May 2018 15:38:27 +0100 Subject: [8u-dev] Request for enhancement backport approval for CR 8078437: Enable use of devkits for Windows. Message-ID: Hi, I'd like to request enhancement backport approval to 8u for: 8078437: Enable use of devkits for Windows. JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 This is to make jdk8u easier to build on Windows, and to give us more options to stay able to build jdk8u in the future. Thanks Kevin From sean.coffey at oracle.com Mon May 21 15:05:26 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 21 May 2018 16:05:26 +0100 Subject: [8u-dev] Request for enhancement backport approval for CR 8078437: Enable use of devkits for Windows. In-Reply-To: References: Message-ID: <2418df82-b94a-2a43-e872-6227eecf142f@oracle.com> Thanks Kevin. This is approved for jdk8u-dev push. Regards, Sean. On 21/05/18 15:38, Kevin Walls wrote: > Hi, > > I'd like to request enhancement backport approval to 8u for: > > 8078437: Enable use of devkits for Windows. > JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 > > This is to make jdk8u easier to build on Windows, and to give us more > options to stay able to build jdk8u in the future. > > Thanks > Kevin > > From jspurling at twitter.com Thu May 24 18:34:19 2018 From: jspurling at twitter.com (John Spurling) Date: Thu, 24 May 2018 11:34:19 -0700 Subject: Request for backport approval for 8195667: ProblemList exclusion of Secmod/AddTrustedCert.java and tls/TestKeyMaterial.java Message-ID: Hello, I'm requesting approval to backport JDK-8195667. It's causing test failures for us. I work for Twitter, and I don't have an OpenJDK username. Here is a modified version of the diff to apply to the current 8u repo: 8195667: ProblemList PKCS11 tests Secmod/AddTrustedCert.java and tls/TestKeyMaterial.java due to JDK-8180837 Summary: Puts sun/security/pkcs11/Secmod/AddTrustedCert.java and sun/security/pkcs11/tls/TestKeyMaterial.java into ProblemList Reviewed-by: weijun diff -r 556b17038b5c -r 24d7281e31bb test/ProblemList.txt --- a/test/ProblemList.txt Wed Apr 18 12:41:29 2018 -0700 +++ b/test/ProblemList.txt Thu May 24 11:20:54 2018 -0700 @@ -300,6 +300,11 @@ #8176354 sun/security/ssl/com/sun/net/ssl/internal/ssl/X509KeyManager/PreferredKey.java generic-all + +# 8180837 +sun/security/pkcs11/Secmod/AddTrustedCert.java generic-all +sun/security/pkcs11/tls/TestKeyMaterial.java generic-all + From sean.coffey at oracle.com Fri May 25 07:55:36 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 25 May 2018 08:55:36 +0100 Subject: Request for backport approval for 8195667: ProblemList exclusion of Secmod/AddTrustedCert.java and tls/TestKeyMaterial.java In-Reply-To: References: Message-ID: <19e930f7-8029-e879-ac04-5ed967167675@oracle.com> Hi John, Yes - probably best to have this patch ported to jdk8u-dev also. I'm not seeing the failures on our test systems (JPRT) but the test clients are probably at a different patch level. Approved for jdk8u-dev. Hopefully one of your work colleagues with committer rights can push this for you. If not, ping me off thread and I'll push. regards, Sean. On 24/05/2018 19:34, John Spurling wrote: > Hello, > > I'm requesting approval to backport JDK-8195667. It's causing test failures > for us. > > I work for Twitter, and I don't have an OpenJDK username. > > Here is a modified version of the diff to apply to the current 8u repo: > > 8195667: ProblemList PKCS11 tests Secmod/AddTrustedCert.java and > tls/TestKeyMaterial.java due to JDK-8180837 > Summary: Puts sun/security/pkcs11/Secmod/AddTrustedCert.java and > sun/security/pkcs11/tls/TestKeyMaterial.java into ProblemList > Reviewed-by: weijun > > diff -r 556b17038b5c -r 24d7281e31bb test/ProblemList.txt > --- a/test/ProblemList.txt Wed Apr 18 12:41:29 2018 -0700 > +++ b/test/ProblemList.txt Thu May 24 11:20:54 2018 -0700 > @@ -300,6 +300,11 @@ > > #8176354 > sun/security/ssl/com/sun/net/ssl/internal/ssl/X509KeyManager/PreferredKey.java > generic-all > + > +# 8180837 > +sun/security/pkcs11/Secmod/AddTrustedCert.java generic-all > +sun/security/pkcs11/tls/TestKeyMaterial.java generic-all > + From alexey.ivanov at oracle.com Fri May 25 08:27:57 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Fri, 25 May 2018 09:27:57 +0100 Subject: [8u-dev] RFR for JDK-8203790: MSVCP dependency introduced in awt.dll Message-ID: Hi, Could you please review the following fix for 8u-dev? jbs: https://bugs.openjdk.java.net/browse/JDK-8203790 webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ There's a missing ?C? in the name, and the compiler flags were not added which led to the dependency. Thank you, Alexey From magnus.ihse.bursie at oracle.com Fri May 25 08:45:09 2018 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 25 May 2018 10:45:09 +0200 Subject: [8u-dev] RFR for JDK-8203790: MSVCP dependency introduced in awt.dll In-Reply-To: References: Message-ID: <61b99b25-d90d-9469-9ebf-286119c830b9@oracle.com> On 2018-05-25 10:27, Alexey Ivanov wrote: > Hi, > > Could you please review the following fix for 8u-dev? > > jbs: https://bugs.openjdk.java.net/browse/JDK-8203790 > webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ > > There's a missing ?C? in the name, and the compiler flags were not > added which led to the dependency. Looks good to me. /Magnus > > > Thank you, > Alexey From kevin.walls at oracle.com Fri May 25 08:49:18 2018 From: kevin.walls at oracle.com (Kevin Walls) Date: Fri, 25 May 2018 09:49:18 +0100 Subject: [8u-dev] RFR for JDK-8203790: MSVCP dependency introduced in awt.dll In-Reply-To: References: Message-ID: <79e6f737-c886-2c23-c5de-602a9ca8be3c@oracle.com> Thanks Alexey - my build with this change completed OK too and the MSVCP dependency in awt.dll has gone, great! Thanks Kevin On 25/05/2018 09:27, Alexey Ivanov wrote: > Hi, > > Could you please review the following fix for 8u-dev? > > jbs: https://bugs.openjdk.java.net/browse/JDK-8203790 > webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ > > There's a missing ?C? in the name, and the compiler flags were not > added which led to the dependency. > > > Thank you, > Alexey From alexey.ivanov at oracle.com Fri May 25 09:18:22 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Fri, 25 May 2018 10:18:22 +0100 Subject: [8u-dev] RFA for JDK-8203790: MSVCP dependency introduced in awt.dll Message-ID: Hi, Can I get the approval for the fix to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8203790 Latest webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ Code review: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-May/007481.html http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022195.html Thank you, Alexey From alexey.ivanov at oracle.com Fri May 25 09:21:08 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Fri, 25 May 2018 10:21:08 +0100 Subject: [8u-dev] RFR for JDK-8203790: MSVCP dependency introduced in awt.dll In-Reply-To: <79e6f737-c886-2c23-c5de-602a9ca8be3c@oracle.com> References: <79e6f737-c886-2c23-c5de-602a9ca8be3c@oracle.com> Message-ID: <067ba72d-ca83-33af-3cc3-76a0fe76eedd@oracle.com> Thank you Magnus and Kevin for your quick reviews. Regards, Alexey On 25/05/2018 09:49, Kevin Walls wrote: > > Thanks Alexey - my build with this change completed OK too and the > MSVCP dependency in awt.dll has gone, great! > > Thanks > Kevin > > > On 25/05/2018 09:27, Alexey Ivanov wrote: >> Hi, >> >> Could you please review the following fix for 8u-dev? >> >> jbs: https://bugs.openjdk.java.net/browse/JDK-8203790 >> webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ >> >> There's a missing ?C? in the name, and the compiler flags were not >> added which led to the dependency. >> >> >> Thank you, >> Alexey > From sean.coffey at oracle.com Fri May 25 09:29:52 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 25 May 2018 10:29:52 +0100 Subject: [8u-dev] RFA for JDK-8203790: MSVCP dependency introduced in awt.dll In-Reply-To: References: Message-ID: Approved. Regards, Sean. On 25/05/18 10:18, Alexey Ivanov wrote: > Hi, > > Can I get the approval for the fix to 8u-dev? > > JBS: https://bugs.openjdk.java.net/browse/JDK-8203790 > Latest webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/ > > Code review: > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-May/007481.html > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022195.html > > > Thank you, > Alexey From ivan.gerasimov at oracle.com Sat May 26 00:49:24 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 25 May 2018 17:49:24 -0700 Subject: [8u-dev] Request for Review and Approval to Backport 8203369 : Check for both EAGAIN and EWOULDBLOCK error codes Message-ID: <9595c277-315e-0d17-0e35-5c956f74922b@oracle.com> Hello! I'd like to backport this fix to jdk8u-dev. Some changes were required, comparing to the fix in JDK 11 (mostly due to the difference in the way to generate UnixConstants.java), thus the Request for Review. The patch was successfully built and tested on all supported platforms with no issues. Bug: https://bugs.openjdk.java.net/browse/JDK-8203369 JDk8u-dev webrev: http://cr.openjdk.java.net/~igerasim/8203369/01/webrev/ Jdk11 change: http://hg.openjdk.java.net/jdk/jdk/rev/69204b98dc3d Jdk11 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053429.html Thanks in advance! -- With kind regards, Ivan Gerasimov From alexey.ivanov at oracle.com Tue May 29 12:27:12 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Tue, 29 May 2018 13:27:12 +0100 Subject: [8u-dev] RFA for JDK-8079788: Fix broken CL version detection in configure for some Visual Studio configurations Message-ID: <0364db56-a0e9-6037-de9b-0ba78c35b210@oracle.com> Hi, Could you please approve the following backport to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8079788 jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/d57780478145 Code review: http://mail.openjdk.java.net/pipermail/build-dev/2016-August/017566.html The patch applies cleanly to jdk8u-dev; generated-configure.sh is regenerated. Webrev: http://cr.openjdk.java.net/~aivanov/8079788/jdk8/webrev.0/ I recently faced this issue, and configure for 8u cannot complete. It could be related to backporting of JDK-8042707. Thank you in advance. Regards, Alexey From erik.joelsson at oracle.com Tue May 29 14:13:00 2018 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 29 May 2018 07:13:00 -0700 Subject: [8u-dev] RFA for JDK-8079788: Fix broken CL version detection in configure for some Visual Studio configurations In-Reply-To: <0364db56-a0e9-6037-de9b-0ba78c35b210@oracle.com> References: <0364db56-a0e9-6037-de9b-0ba78c35b210@oracle.com> Message-ID: <6449fd49-3afc-583e-12a9-31142915ea3f@oracle.com> Looks good (except for my spelling error in the comment "siutations". Not sure what the policy is for fixing such in backports.) /Erik On 2018-05-29 05:27, Alexey Ivanov wrote: > Hi, > > Could you please approve the following backport to 8u-dev? > > JBS: https://bugs.openjdk.java.net/browse/JDK-8079788 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/d57780478145 > Code review: > http://mail.openjdk.java.net/pipermail/build-dev/2016-August/017566.html > > The patch applies cleanly to jdk8u-dev; generated-configure.sh is > regenerated. > Webrev: http://cr.openjdk.java.net/~aivanov/8079788/jdk8/webrev.0/ > > I recently faced this issue, and configure for 8u cannot complete. It > could be related to backporting of JDK-8042707. > > Thank you in advance. > > Regards, > Alexey From alexey.ivanov at oracle.com Tue May 29 14:42:22 2018 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Tue, 29 May 2018 15:42:22 +0100 Subject: [8u-dev] RFA for JDK-8079788: Fix broken CL version detection in configure for some Visual Studio configurations In-Reply-To: <6449fd49-3afc-583e-12a9-31142915ea3f@oracle.com> References: <0364db56-a0e9-6037-de9b-0ba78c35b210@oracle.com> <6449fd49-3afc-583e-12a9-31142915ea3f@oracle.com> Message-ID: <99eb231e-2430-b8f4-e273-a24345cdb331@oracle.com> I can fix it before pushing. Regards, Alexey On 29/05/2018 15:13, Erik Joelsson wrote: > Looks good (except for my spelling error in the comment "siutations". > Not sure what the policy is for fixing such in backports.) > > /Erik > > On 2018-05-29 05:27, Alexey Ivanov wrote: >> Hi, >> >> Could you please approve the following backport to 8u-dev? >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8079788 >> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/d57780478145 >> Code review: >> http://mail.openjdk.java.net/pipermail/build-dev/2016-August/017566.html >> >> The patch applies cleanly to jdk8u-dev; generated-configure.sh is >> regenerated. >> Webrev: http://cr.openjdk.java.net/~aivanov/8079788/jdk8/webrev.0/ >> >> I recently faced this issue, and configure for 8u cannot complete. It >> could be related to backporting of JDK-8042707. >> >> Thank you in advance. >> >> Regards, >> Alexey > From david.buck at oracle.com Wed May 30 16:20:39 2018 From: david.buck at oracle.com (David Buck) Date: Thu, 31 May 2018 01:20:39 +0900 Subject: [8] RFA 8203845: backport of JDK-8034788 inadvertently rolled back JDK-8187045 changes to toolchain.m4 Message-ID: <985cdf9e-0479-a573-b988-4dd18378f3b1@oracle.com> Hi! Please approve the push of this simple regression fix to 8u-dev. As this is an issue in only JDK 8, there is no fix needed for later versions. bug report: https://bugs.openjdk.java.net/browse/JDK-8203845 webrev: http://cr.openjdk.java.net/~dbuck/8203845.0/ code review: http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022223.html JPRT hostspot tests passed and manual confirmation of fix done. Cheers, -Buck From ramanand.patil at oracle.com Wed May 30 18:39:18 2018 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Wed, 30 May 2018 11:39:18 -0700 (PDT) Subject: [8u-dev] Request for Approval: Backport of 8203233: (tz) Upgrade time-zone data to tzdata2018e Message-ID: <14304b79-8310-4c00-ba7f-171f9645675f@default> Hi, Please approve the backport of 8203233 to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8203233 JDK Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/4887e76f2493 JDK Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053366.html Changes apply cleanly to jdk8u-dev after path reshuffling. All the related testing is done and is a pass. Regards, Ramanand. From rob.mckenna at oracle.com Wed May 30 19:09:59 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 30 May 2018 20:09:59 +0100 Subject: [8] RFA 8203845: backport of JDK-8034788 inadvertently rolled back JDK-8187045 changes to toolchain.m4 In-Reply-To: <985cdf9e-0479-a573-b988-4dd18378f3b1@oracle.com> References: <985cdf9e-0479-a573-b988-4dd18378f3b1@oracle.com> Message-ID: <20180530190959.GG4404@vimes> Approved. -Rob On 31/05/18 01:20, David Buck wrote: > Hi! > > Please approve the push of this simple regression fix to 8u-dev. As this is > an issue in only JDK 8, there is no fix needed for later versions. > > bug report: > https://bugs.openjdk.java.net/browse/JDK-8203845 > > webrev: > http://cr.openjdk.java.net/~dbuck/8203845.0/ > > code review: > http://mail.openjdk.java.net/pipermail/build-dev/2018-May/022223.html > > JPRT hostspot tests passed and manual confirmation of fix done. > > Cheers, > -Buck From rob.mckenna at oracle.com Wed May 30 19:10:16 2018 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 30 May 2018 20:10:16 +0100 Subject: [8u-dev] Request for Approval: Backport of 8203233: (tz) Upgrade time-zone data to tzdata2018e In-Reply-To: <14304b79-8310-4c00-ba7f-171f9645675f@default> References: <14304b79-8310-4c00-ba7f-171f9645675f@default> Message-ID: <20180530191016.GH4404@vimes> Approved -Rob On 30/05/18 11:39, Ramanand Patil wrote: > Hi, > Please approve the backport of 8203233 to 8u-dev. > Bug: https://bugs.openjdk.java.net/browse/JDK-8203233 > JDK Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/4887e76f2493 > JDK Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053366.html > > Changes apply cleanly to jdk8u-dev after path reshuffling. > All the related testing is done and is a pass. > > Regards, > Ramanand. From ivan.gerasimov at oracle.com Thu May 31 01:40:23 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 30 May 2018 18:40:23 -0700 Subject: [8u-dev] Request for Review and Approval to Backport 8203368: ObjectInputStream filterCheck method throws NullPointerException Message-ID: <5ea10528-b421-976a-3069-9346b855d354@oracle.com> Hello! I'd like to backport the fix to JDK 8u-dev. Both source patch and the regression test had to be adjusted slightly due to the code divergence, thus the review request. Bug: https://bugs.openjdk.java.net/browse/JDK-8203368 Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8203368/00/webrev/ Jdk 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/697b49a04e19 Jdk 11 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053318.html Thanks in advance! -- With kind regards, Ivan Gerasimov From sean.coffey at oracle.com Thu May 31 07:32:14 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 31 May 2018 08:32:14 +0100 Subject: [8u-dev] RFA for JDK-8079788: Fix broken CL version detection in configure for some Visual Studio configurations In-Reply-To: <99eb231e-2430-b8f4-e273-a24345cdb331@oracle.com> References: <0364db56-a0e9-6037-de9b-0ba78c35b210@oracle.com> <6449fd49-3afc-583e-12a9-31142915ea3f@oracle.com> <99eb231e-2430-b8f4-e273-a24345cdb331@oracle.com> Message-ID: <0c1318b9-cc61-1eca-81da-d48aafe6684c@oracle.com> Approved for jdk8u-dev. regards, Sean. On 29/05/2018 15:42, Alexey Ivanov wrote: > I can fix it before pushing. > > > Regards, > Alexey > > On 29/05/2018 15:13, Erik Joelsson wrote: >> Looks good (except for my spelling error in the comment "siutations". >> Not sure what the policy is for fixing such in backports.) >> >> /Erik >> >> On 2018-05-29 05:27, Alexey Ivanov wrote: >>> Hi, >>> >>> Could you please approve the following backport to 8u-dev? >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8079788 >>> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/d57780478145 >>> Code review: >>> http://mail.openjdk.java.net/pipermail/build-dev/2016-August/017566.html >>> >>> >>> The patch applies cleanly to jdk8u-dev; generated-configure.sh is >>> regenerated. >>> Webrev: http://cr.openjdk.java.net/~aivanov/8079788/jdk8/webrev.0/ >>> >>> I recently faced this issue, and configure for 8u cannot complete. >>> It could be related to backporting of JDK-8042707. >>> >>> Thank you in advance. >>> >>> Regards, >>> Alexey >> > From sean.coffey at oracle.com Thu May 31 07:34:56 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 31 May 2018 08:34:56 +0100 Subject: [8u-dev] Request for Review and Approval to Backport 8203368: ObjectInputStream filterCheck method throws NullPointerException In-Reply-To: <5ea10528-b421-976a-3069-9346b855d354@oracle.com> References: <5ea10528-b421-976a-3069-9346b855d354@oracle.com> Message-ID: Looks fine. Approved for jdk8u-dev. regards, Sean. On 31/05/2018 02:40, Ivan Gerasimov wrote: > Hello! > > I'd like to backport the fix to JDK 8u-dev. > > Both source patch and the regression test had to be adjusted slightly > due to the code divergence, thus the review request. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203368 > > Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8203368/00/webrev/ > > Jdk 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/697b49a04e19 > > Jdk 11 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053318.html > > > Thanks in advance! > From roger.riggs at oracle.com Thu May 31 12:49:22 2018 From: roger.riggs at oracle.com (Roger Riggs) Date: Thu, 31 May 2018 08:49:22 -0400 Subject: [8u-dev] Request for Review and Approval to Backport 8203368: ObjectInputStream filterCheck method throws NullPointerException In-Reply-To: <5ea10528-b421-976a-3069-9346b855d354@oracle.com> References: <5ea10528-b421-976a-3069-9346b855d354@oracle.com> Message-ID: Hi, The changes for JDK 8 look fine to me. Thanks, Roger On 5/30/18 9:40 PM, Ivan Gerasimov wrote: > Hello! > > I'd like to backport the fix to JDK 8u-dev. > > Both source patch and the regression test had to be adjusted slightly > due to the code divergence, thus the review request. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203368 > > Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8203368/00/webrev/ > > Jdk 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/697b49a04e19 > > Jdk 11 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-May/053318.html > > > Thanks in advance! > From ivan.gerasimov at oracle.com Thu May 31 17:20:18 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 31 May 2018 10:20:18 -0700 Subject: [8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently Message-ID: <9ad953fb-aabf-95a0-5338-abcfe09ab485@oracle.com> Hello! The test failure (in the subj. line) was observed in JDK 8u, so I'd like to backport the fix. The patch did not apply cleanly due to the difference in couple of lines, thus the re-review request. (Specifically, the difference is in TLSRestrictions.java, lines 216 and 221 of patched version; otherwise, the fix is essentially the same.) The patched test passed well on all supported platforms. Bug: https://bugs.openjdk.java.net/browse/JDK-8189760 Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8189760/00/webrev/ Jdk 11 change: http://closedjdk.us.oracle.com/jdk/jdk-cpu/open/rev/2d250a0174a6 Jdk 11 review: http://mail.openjdk.java.net/pipermail/security-dev/2018-January/016675.html Thanks in advance! -- With kind regards, Ivan Gerasimov From sean.coffey at oracle.com Thu May 31 19:13:05 2018 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 31 May 2018 20:13:05 +0100 Subject: [8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently In-Reply-To: <9ad953fb-aabf-95a0-5338-abcfe09ab485@oracle.com> References: <9ad953fb-aabf-95a0-5338-abcfe09ab485@oracle.com> Message-ID: <3e1e1db8-11eb-40a2-487f-d14bd6927591@oracle.com> Looks fine Ivan. Approved for jdk8u-dev. regards, Sean. On 31/05/2018 18:20, Ivan Gerasimov wrote: > Hello! > > The test failure (in the subj. line) was observed in JDK 8u, so I'd > like to backport the fix. > > The patch did not apply cleanly due to the difference in couple of > lines, thus the re-review request. > > (Specifically, the difference is in TLSRestrictions.java, lines 216 > and 221 of patched version; otherwise, the fix is essentially the same.) > > The patched test passed well on all supported platforms. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8189760 > > Jdk 8u webrev: http://cr.openjdk.java.net/~igerasim/8189760/00/webrev/ > > Jdk 11 change: > http://closedjdk.us.oracle.com/jdk/jdk-cpu/open/rev/2d250a0174a6 > > Jdk 11 review: > http://mail.openjdk.java.net/pipermail/security-dev/2018-January/016675.html > > Thanks in advance! > From ivan.gerasimov at oracle.com Thu May 31 19:33:29 2018 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 31 May 2018 12:33:29 -0700 Subject: [8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently In-Reply-To: <3e1e1db8-11eb-40a2-487f-d14bd6927591@oracle.com> References: <9ad953fb-aabf-95a0-5338-abcfe09ab485@oracle.com> <3e1e1db8-11eb-40a2-487f-d14bd6927591@oracle.com> Message-ID: Thanks Se?n! On 5/31/18 12:13 PM, Se?n Coffey wrote: > Looks fine Ivan. > > Approved for jdk8u-dev. > > regards, > Sean.