RFD: Draft guidelines for working on jdk8u

Andrew Haley aph at redhat.com
Fri Feb 8 14:04:09 UTC 2019


On 2/8/19 2:02 PM, Aleksey Shipilev wrote:
> On 2/8/19 2:54 PM, Andrew Haley wrote:
>> On 2/8/19 1:49 PM, Andrew Haley wrote:
>>> I'm not sure. I welcome further input.
>>
>> Just to be clear: we must have tags in the bug database for 8u backports,
>> I'm just ruminating on whether we must have maintainer approval for every
>> little patch. IMO, anyone who is a jdk8u reviewer should be able to apply
>> the rules for minor changes, and it's only for changes with significant
>> risk where we need multiple reviews.
> 
> I think _maintainers_ have to approve every patch, no matter how
> little it looks like. "JDK 8u reviewer" is too broad of the group
> [1], and we cannot expect them to have cached understanding of how
> the 8u updates project works.

Hmph. Should they really be reviewers, then?

> With JBS tagging, the work for maintainers to approve the fixes
> should be small. And, we can also have more maintainers, right?
> (ducks)

You'll be ideal, I imagine.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the jdk8u-dev mailing list